From: Volker Diels-Grabsch <v@njh.eu>
To: passt-dev@passt.top
Cc: Volker Diels-Grabsch <v@njh.eu>
Subject: [PATCH 5/5] Improve clarity of comment
Date: Tue, 16 Sep 2025 21:21:16 +0200 [thread overview]
Message-ID: <20250916192209.3986375-6-v@njh.eu> (raw)
In-Reply-To: <20250916192209.3986375-1-v@njh.eu>
The new wording clarifies that we (1) use the broadcast MAC address
only until we know the actual MAC address of the guest, and (2) our
first packets will not necessarily "reach" the guest, in the sense of
being processed rather than dropped. (Which is why we actively send an
initial ARP and/or NDP message, to get the guest MAC address as soon
as possible.)
Signed-off-by: Volker Diels-Grabsch <v@njh.eu>
---
tap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tap.c b/tap.c
index 0f8ee25..399eeaa 100644
--- a/tap.c
+++ b/tap.c
@@ -1512,9 +1512,9 @@ void tap_backend_init(struct ctx *c)
case MODE_PASST:
tap_sock_unix_init(c);
- /* In passt mode, we don't know the guest's MAC address until it
- * sends us packets. Use the broadcast address so that our
- * first packets will reach it.
+ /* In passt mode, we don't know the guest's MAC address until
+ * it sends us packets. Until then, use the broadcast address
+ * so that our first packets will have a chance to reach it.
*/
memcpy(&c->guest_mac, MAC_BROADCAST, sizeof(c->guest_mac));
break;
--
2.47.3
next prev parent reply other threads:[~2025-09-16 19:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 19:21 [PATCH v6 1/5] Volker Diels-Grabsch
2025-09-16 19:21 ` [PATCH 1/5] Show debug message whenever we observe a new guest MAC address Volker Diels-Grabsch
2025-09-17 5:05 ` David Gibson
2025-09-16 19:21 ` [PATCH 2/5] Introduce constant MAC_BROADCAST Volker Diels-Grabsch
2025-09-17 7:29 ` David Gibson
2025-09-16 19:21 ` [PATCH 3/5] Fix --no-icmp description and make it imply --no-ndp Volker Diels-Grabsch
2025-09-17 7:29 ` David Gibson
2025-09-16 19:21 ` [PATCH 4/5] Send an initial ARP and NDP request to resolve the guest IP address Volker Diels-Grabsch
2025-09-18 2:32 ` David Gibson
2025-09-16 19:21 ` Volker Diels-Grabsch [this message]
2025-09-18 2:43 ` [PATCH 5/5] Improve clarity of comment David Gibson
2025-09-17 14:32 ` [PATCH v6 1/5] Stefano Brivio
2025-09-19 0:59 ` Volker Diels-Grabsch
2025-09-19 1:45 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916192209.3986375-6-v@njh.eu \
--to=v@njh.eu \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).