From: Laurent Vivier <lvivier@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH] dhcp: Fix coding style violations in dhcp() function
Date: Wed, 17 Sep 2025 08:41:42 +0200 [thread overview]
Message-ID: <20250917064142.3854816-1-lvivier@redhat.com> (raw)
The dhcp() function wasn't following the inverted Christmas tree
variable declaration ordering convention.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
dhcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dhcp.c b/dhcp.c
index 012cec6c0d04..6b9c2e3b9e5a 100644
--- a/dhcp.c
+++ b/dhcp.c
@@ -311,10 +311,10 @@ int dhcp(const struct ctx *c, struct iov_tail *data)
const struct ethhdr *eh;
const struct iphdr *iph;
const struct udphdr *uh;
+ struct msg m_storage;
struct msg const *m;
struct msg reply;
unsigned int i;
- struct msg m_storage;
eh = IOV_REMOVE_HEADER(data, eh_storage);
iph = IOV_PEEK_HEADER(data, iph_storage);
--
2.50.1
next reply other threads:[~2025-09-17 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 6:41 Laurent Vivier [this message]
2025-09-17 7:28 ` David Gibson
2025-09-18 16:01 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917064142.3854816-1-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).