From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Q5GmUUQf; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 330625A0271 for ; Wed, 17 Sep 2025 08:41:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758091308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=32cuLTCm3ukM7funL1mEzFqkhEH9kzjfybAN+LVi0+c=; b=Q5GmUUQflRztZFpf3anCdZrJ66KiX29l/DT6tC1oSszjjhxOrhzbVGjPOIndWxRW/LzCq2 ljkDUutZk4LvzAVr8InGu0Tu4/WhSFW17lpFqnTXWViqfxoTfkYqvvlIhQD2i5IKIfCizV fau/XVDSGYr/qB2ucvbizJNHO6ESmqU= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-zgQAY6DLNoORoWKG3nrSbQ-1; Wed, 17 Sep 2025 02:41:46 -0400 X-MC-Unique: zgQAY6DLNoORoWKG3nrSbQ-1 X-Mimecast-MFC-AGG-ID: zgQAY6DLNoORoWKG3nrSbQ_1758091306 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 12B1E1800343 for ; Wed, 17 Sep 2025 06:41:46 +0000 (UTC) Received: from lenovo-t14s.redhat.com (unknown [10.45.224.236]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E8D12195608E; Wed, 17 Sep 2025 06:41:44 +0000 (UTC) From: Laurent Vivier To: passt-dev@passt.top Subject: [PATCH] dhcp: Fix coding style violations in dhcp() function Date: Wed, 17 Sep 2025 08:41:42 +0200 Message-ID: <20250917064142.3854816-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yJBENpNw0rSII-XCHazpHzz58WpVrX1pWffOwJ57CTg_1758091306 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: X7S24UZQVPD7IGZSP5QCLMRUTOVDNZSE X-Message-ID-Hash: X7S24UZQVPD7IGZSP5QCLMRUTOVDNZSE X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The dhcp() function wasn't following the inverted Christmas tree variable declaration ordering convention. Signed-off-by: Laurent Vivier --- dhcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dhcp.c b/dhcp.c index 012cec6c0d04..6b9c2e3b9e5a 100644 --- a/dhcp.c +++ b/dhcp.c @@ -311,10 +311,10 @@ int dhcp(const struct ctx *c, struct iov_tail *data) const struct ethhdr *eh; const struct iphdr *iph; const struct udphdr *uh; + struct msg m_storage; struct msg const *m; struct msg reply; unsigned int i; - struct msg m_storage; eh = IOV_REMOVE_HEADER(data, eh_storage); iph = IOV_PEEK_HEADER(data, iph_storage); -- 2.50.1