* [PATCH] dhcp: Fix coding style violations in dhcp() function
@ 2025-09-17 6:41 Laurent Vivier
2025-09-17 7:28 ` David Gibson
2025-09-18 16:01 ` Stefano Brivio
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Vivier @ 2025-09-17 6:41 UTC (permalink / raw)
To: passt-dev; +Cc: Laurent Vivier
The dhcp() function wasn't following the inverted Christmas tree
variable declaration ordering convention.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
dhcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dhcp.c b/dhcp.c
index 012cec6c0d04..6b9c2e3b9e5a 100644
--- a/dhcp.c
+++ b/dhcp.c
@@ -311,10 +311,10 @@ int dhcp(const struct ctx *c, struct iov_tail *data)
const struct ethhdr *eh;
const struct iphdr *iph;
const struct udphdr *uh;
+ struct msg m_storage;
struct msg const *m;
struct msg reply;
unsigned int i;
- struct msg m_storage;
eh = IOV_REMOVE_HEADER(data, eh_storage);
iph = IOV_PEEK_HEADER(data, iph_storage);
--
2.50.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dhcp: Fix coding style violations in dhcp() function
2025-09-17 6:41 [PATCH] dhcp: Fix coding style violations in dhcp() function Laurent Vivier
@ 2025-09-17 7:28 ` David Gibson
2025-09-18 16:01 ` Stefano Brivio
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2025-09-17 7:28 UTC (permalink / raw)
To: Laurent Vivier; +Cc: passt-dev
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Wed, Sep 17, 2025 at 08:41:42AM +0200, Laurent Vivier wrote:
> The dhcp() function wasn't following the inverted Christmas tree
> variable declaration ordering convention.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> dhcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dhcp.c b/dhcp.c
> index 012cec6c0d04..6b9c2e3b9e5a 100644
> --- a/dhcp.c
> +++ b/dhcp.c
> @@ -311,10 +311,10 @@ int dhcp(const struct ctx *c, struct iov_tail *data)
> const struct ethhdr *eh;
> const struct iphdr *iph;
> const struct udphdr *uh;
> + struct msg m_storage;
> struct msg const *m;
> struct msg reply;
> unsigned int i;
> - struct msg m_storage;
>
> eh = IOV_REMOVE_HEADER(data, eh_storage);
> iph = IOV_PEEK_HEADER(data, iph_storage);
> --
> 2.50.1
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dhcp: Fix coding style violations in dhcp() function
2025-09-17 6:41 [PATCH] dhcp: Fix coding style violations in dhcp() function Laurent Vivier
2025-09-17 7:28 ` David Gibson
@ 2025-09-18 16:01 ` Stefano Brivio
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Brivio @ 2025-09-18 16:01 UTC (permalink / raw)
To: Laurent Vivier; +Cc: passt-dev
On Wed, 17 Sep 2025 08:41:42 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> The dhcp() function wasn't following the inverted Christmas tree
> variable declaration ordering convention.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Applied.
--
Stefano
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-18 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-17 6:41 [PATCH] dhcp: Fix coding style violations in dhcp() function Laurent Vivier
2025-09-17 7:28 ` David Gibson
2025-09-18 16:01 ` Stefano Brivio
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).