public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Paul Holzinger <pholzing@redhat.com>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: Max Chernoff <git@maxchernoff.ca>,
	Giuseppe Scrivano <gscrivan@redhat.com>,
	Lokesh Mandvekar <lmandvek@redhat.com>,
	Dan Walsh <dwalsh@redhat.com>,
	Paul Holzinger <pholzing@redhat.com>
Subject: [PATCH 1/2] selinux: add container_var_run_t type transition
Date: Wed, 17 Sep 2025 14:04:50 +0200	[thread overview]
Message-ID: <20250917120450.36181-2-pholzing@redhat.com> (raw)

In some cases the podman runroot directory used to be labelled
container_var_run_t instead of user_tmp_t which was expected here.
Starting with a recent container-selinux change the runroot is now
always container_var_run_t so make the policy handle both types to allow
for a better upgrade path where passt-selinux and container-selinux are
not updated at the same time.

Link: https://github.com/containers/container-selinux/pull/405
Link: https://github.com/containers/podman/issues/26473

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
---
 contrib/selinux/pasta.te | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/contrib/selinux/pasta.te b/contrib/selinux/pasta.te
index c0a1e9b..24e58c8 100644
--- a/contrib/selinux/pasta.te
+++ b/contrib/selinux/pasta.te
@@ -96,6 +96,7 @@ require {
 	role staff_r;
 	role user_r;
 	type container_runtime_t;
+	type container_var_run_t;
 	type container_t;
 	type systemd_user_runtimedir_t;
 }
@@ -242,8 +243,12 @@ type_transition container_runtime_t pasta_exec_t : process pasta_t;
 allow container_runtime_t pasta_t:process transition;
 
 # Label the user network namespace files
+# Note podman files used to be user_tmp_t but now are container_var_run_t since
+# https://github.com/containers/container-selinux/issues/404.
 type_transition container_runtime_t user_tmp_t : dir ifconfig_var_run_t "netns";
+type_transition container_runtime_t container_var_run_t : dir ifconfig_var_run_t "netns";
 type_transition container_runtime_t user_tmp_t : dir ifconfig_var_run_t "rootless-netns";
+type_transition container_runtime_t container_var_run_t : dir ifconfig_var_run_t "rootless-netns";
 allow pasta_t ifconfig_var_run_t:dir { add_name open rmdir write };
 allow pasta_t ifconfig_var_run_t:file { create open write };
 allow systemd_user_runtimedir_t ifconfig_var_run_t:dir rmdir;
-- 
2.51.0


             reply	other threads:[~2025-09-17 12:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17 12:04 Paul Holzinger [this message]
2025-09-17 12:04 ` [PATCH 2/2] selinux: add missing file contexts for Podman Paul Holzinger
2025-09-17 15:05   ` Stefano Brivio
2025-09-17 15:05 ` [PATCH 1/2] selinux: add container_var_run_t type transition Stefano Brivio
2025-09-17 15:54   ` Paul Holzinger
2025-09-18 16:01 ` Stefano Brivio
     [not found]   ` <CAFiEh0am6Pn7RGANe-0oQM-=-U=BXKD3afoRoefH4-3Ou1gVvA@mail.gmail.com>
2025-09-19 23:06     ` Stefano Brivio
2025-09-19 23:13       ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250917120450.36181-2-pholzing@redhat.com \
    --to=pholzing@redhat.com \
    --cc=dwalsh@redhat.com \
    --cc=git@maxchernoff.ca \
    --cc=gscrivan@redhat.com \
    --cc=lmandvek@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).