public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Volker Diels-Grabsch <v@njh.eu>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v6 1/5]
Date: Wed, 17 Sep 2025 16:32:42 +0200	[thread overview]
Message-ID: <20250917163242.34096a32@elisabeth> (raw)
In-Reply-To: <20250916192209.3986375-1-v@njh.eu>

On Tue, 16 Sep 2025 21:21:11 +0200
Volker Diels-Grabsch <v@njh.eu> wrote:

> This incorporates all feedback of v5, and the commits are
> slightly reordered so the comment of the last commit makes
> more sense.

Applied, thanks to sticking to this! I hope this will finally
make the QEMU disconnect/reconnect behaviour robust enough.

A couple of notes for future changes:

- you can add this kind of message as cover letter instead, just
  git format-patch --cover-letter and git will format things as
  needed, and concatenate In-Reply-To: and References: email
  headers

- reporting the version number in every subject line might make
  reviewers' life marginally easier and it just takes a
  --subject-prefix="PATCH v6" (in this case) or even something
  like -v6 argument to git format-patch

- carry Reviewed-by: tags if you don't... change the change. For
  example, here, 4/5 was already reviewed by David. I added the
  tag back (and will always do anyway)

...in any case, those are very minor details that don't really
cause me any trouble as a maintainer.

-- 
Stefano


  parent reply	other threads:[~2025-09-17 14:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 19:21 Volker Diels-Grabsch
2025-09-16 19:21 ` [PATCH 1/5] Show debug message whenever we observe a new guest MAC address Volker Diels-Grabsch
2025-09-17  5:05   ` David Gibson
2025-09-16 19:21 ` [PATCH 2/5] Introduce constant MAC_BROADCAST Volker Diels-Grabsch
2025-09-17  7:29   ` David Gibson
2025-09-16 19:21 ` [PATCH 3/5] Fix --no-icmp description and make it imply --no-ndp Volker Diels-Grabsch
2025-09-17  7:29   ` David Gibson
2025-09-16 19:21 ` [PATCH 4/5] Send an initial ARP and NDP request to resolve the guest IP address Volker Diels-Grabsch
2025-09-18  2:32   ` David Gibson
2025-09-16 19:21 ` [PATCH 5/5] Improve clarity of comment Volker Diels-Grabsch
2025-09-18  2:43   ` David Gibson
2025-09-17 14:32 ` Stefano Brivio [this message]
2025-09-19  0:59   ` [PATCH v6 1/5] Volker Diels-Grabsch
2025-09-19  1:45     ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250917163242.34096a32@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=v@njh.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).