From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Dejsf/ge; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id BECB75A0271 for ; Fri, 19 Sep 2025 11:58:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758275910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aTNRwWjlAS/EKct2+S37InL7zeCfafBaBx4EE9/LsQw=; b=Dejsf/ge5AGDdajbebRpv3cK93oGTCfcbV2BayFpjwt7YQGKYxaRRtNvpRXFrM6tGGe31/ sqNkxE3BEHD2gWPQYL1Nx4w3bxiTdZTFf5sZiI8YQDBIBVgnfAsgy0QpRUL5iXjoS10lTb 49DqECx8ZjT8k6O+FRAVyFJQFgCe+L8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-Menzpj57MZ-3FI5itBJhMA-1; Fri, 19 Sep 2025 05:58:27 -0400 X-MC-Unique: Menzpj57MZ-3FI5itBJhMA-1 X-Mimecast-MFC-AGG-ID: Menzpj57MZ-3FI5itBJhMA_1758275906 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45dd66e1971so16971355e9.2 for ; Fri, 19 Sep 2025 02:58:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758275906; x=1758880706; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=aTNRwWjlAS/EKct2+S37InL7zeCfafBaBx4EE9/LsQw=; b=aedCVXBqeI2QpBZtwPMHyv52SOYemIT+UvBoaC+z0Dx7E5cnOMOwitairNsruoeg1d rlsaM0x74Ytj8araZibix/lb7tIqYt6NO3PKCJ8oV2XCOrIOxctT3jKe4PU7WFhKLkJU xQYUl7U+3oRtay3kYOME+qOHsC3QTFtGm/rDTcjGLoaTtCihLmK8I1zQk4fXhNhOxIGc 4kYvCC36w/iXSt80ndY5LDET9kxw9+BEl2APTwNHGhTgL53GAUsBkHgYZ6JD29FCJxxf 4R9Z3ATNQBrjdszCx/PNJaj18aVrSDpP/0HseIJXVwLQM5HNUbvvOp3RYBAUhvIhxnRJ s5jQ== X-Gm-Message-State: AOJu0YxMf2/1cLIqJR1YeqPhpAFuOSokw0xPjcj3VTrFQSSSEsJdzv5X ltuLVKLAa44HUk3rUlP3a/Vo+Lxf+jTfw124IafbbO0DXO9+/f/YL8bdBzkLjv8w1GU5DG73Bpb q6KJ2I9nquIDYxHt87C+veM8D2MgJqIPDA+WUy2RJr1LHXZXnFUgy+g== X-Gm-Gg: ASbGncuA4MzwqgkzWcuWuN+AKpkHvhMAFH2AbxI3iXAYSvodcuFD5oxPdKdiBsPar9N QiprQ3pFKjgPkVdk0YtHYmTd+atl7/1Ife7GuzuH4ACjqkapqjBlJnM3Z9/UxMxSSwWuT8udQB1 b99gPl7ZJTduEQ9pAtBAbbY7NHpbjt8M7jk2TsiHj7TU77OYyrf4af5mk4OqBtQ1ZcoARcBBthJ zYfRclEHbjB6jjgHTlmDP82WNz9UJ7xoXU3sqNcf5WF+nODRmSuu1VVjAHVP5E4zTagEu+4Y7tA jRE6RvJD5PYjdHr35u2+YZXFNPsWiPRBKTd22wFmdDByN5Xo9dTnP9IX74ejjKwOvyaL X-Received: by 2002:a05:600c:4e91:b0:45d:d9d1:80a3 with SMTP id 5b1f17b1804b1-467eb603270mr21955835e9.37.1758275906025; Fri, 19 Sep 2025 02:58:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvYzGe81WjOzE30wMeIaFSBCyfcQndFbMvRaZuE5DFkpXr0w2rjHaamjI8HEu2pyzPBahFHA== X-Received: by 2002:a05:600c:4e91:b0:45d:d9d1:80a3 with SMTP id 5b1f17b1804b1-467eb603270mr21955495e9.37.1758275905576; Fri, 19 Sep 2025 02:58:25 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f32081248sm82030865e9.0.2025.09.19.02.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Sep 2025 02:58:24 -0700 (PDT) Date: Fri, 19 Sep 2025 11:58:22 +0200 From: Stefano Brivio To: Yumei Huang Subject: Re: [PATCH] test: Update README.md Message-ID: <20250919115822.4e3aab21@elisabeth> In-Reply-To: <20250919014329.6007-1-yuhuang@redhat.com> References: <20250919014329.6007-1-yuhuang@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hoUOoG8YvmWd3Z2zyKQxGLWf5-OToFY3pC3miyf26UE_1758275906 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 6YABUWVFPHRICY6CVBYKVHOINJ5CVEZ2 X-Message-ID-Hash: 6YABUWVFPHRICY6CVBYKVHOINJ5CVEZ2 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 19 Sep 2025 09:43:29 +0800 Yumei Huang wrote: > Signed-off-by: Yumei Huang > --- > test/README.md | 31 +++++++++++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/test/README.md b/test/README.md > index 91ca603..e3e9d37 100644 > --- a/test/README.md > +++ b/test/README.md > @@ -32,7 +32,7 @@ Example for Debian, and possibly most Debian-based distributions: > git go iperf3 isc-dhcp-common jq libgpgme-dev libseccomp-dev linux-cpupower > lm-sensors lz4 netavark netcat-openbsd psmisc qemu-efi-aarch64 > qemu-system-arm qemu-system-misc qemu-system-ppc qemu-system-x86 > - qemu-system-x86 sipcalc socat strace tmux uidmap valgrind > + sipcalc socat strace tmux uidmap valgrind > > NOTE: the tests need a qemu version >= 7.2, or one that contains commit > 13c6be96618c ("net: stream: add unix socket"): this change introduces support > @@ -81,7 +81,12 @@ The following additional packages are commonly needed: > > ## Regular test > > -Just issue: > +Before running the tests, you need to prepare the required assets: > + > + cd test > + make assets > + > +Then issue: > > ./run > > @@ -91,6 +96,28 @@ variable settings: DEBUG=1 enables debugging messages, TRACE=1 enables tracing > > PCAP=1 TRACE=1 ./run > > +**Note:** > + > +* It's recommended to run the commands as a non-root user. > + Due to [Bug 967509](https://bugzilla.redhat.com/show_bug.cgi?id=967509), > + if you switch users with `su` or `sudo`, the directory `/run/user/ID` may > + not be created. In that case, `XDG_RUNTIME_DIR` will incorrectly point to > + `/run/user/0` instead of `/run/user/ID`, which can cause error. Thanks for the research, I wasn't aware of that, and recently spent quite some time figuring that out (for other reasons): https://issues.redhat.com/browse/RHEL-70222 in that case, XDG_RUNTIME_DIR was simply not set. Things were working with 'machinectl shell' instead. At the same time: running this whole stuff as root sounds rather crazy, unless it's a throw-away VMs with absolutely nothing important on it. That is, regardless of the issue with XDG_RUNTIME_DIR. I would maybe make the wording stronger, something like: * Don't run the tests as root, it's not needed! * If you really need to, note that ... > + **Workaround:** Log out and log back in as the intended user to ensure the > + correct runtime directory is set up. We could also suggest 'machinectl shell' if it's really needed for whatever reason. > +* SELinux may prevent the tests from running correctly. To avoid this, > + temporarily disable it by running: > + > + setenforce 0 By the way, other than the DHCP client not working on Fedora in a namespace (which we should really fix, I can look into it if you share the messages you're getting from /var/log/audit/audit.log), did you hit any other issue with it? I haven't tried running tests on Fedora for a long time now. > +* Some tests require a QEMU build that includes the following commits: > + > + 60f543ad917f ("virtio-net: vhost-user: Implement internal migration") > + 3f65357313e0 ("vhost: Add stubs for the migration state transfer > + interface") Given: $ git describe --contain 60f543ad917f 3f65357313e0 v10.0.0-rc0~89^2~1 v10.0.0-rc0~89^2~2 we might also save the reader from checking out a QEMU tree to check and say something like "Some tests require a QEMU version >= 10.0.0, or a build that includes ..." > + > ## Running selected tests > > Rudimentary support to run a list of selected tests, without support for The rest looks good to me and it's an improvement on the original anyway so I'm fine applying as it is, as well, but those few suggestions shouldn't take that long either. -- Stefano