From: Yumei Huang <yuhuang@redhat.com>
To: passt-dev@passt.top, sbrivio@redhat.com
Cc: david@gibson.dropbear.id.au, yuhuang@redhat.com,
rjones@redhat.com, berrange@redhat.com
Subject: [PATCH] test: fix 'make assets' failure as root
Date: Thu, 25 Sep 2025 13:43:06 +0800 [thread overview]
Message-ID: <20250925054306.15964-1-yuhuang@redhat.com> (raw)
Running `make assets` under `test` as root fails with a "Permission denied"
error when `prepare-distro-img.sh` invokes `virt-edit` and `guestfish`. This
is due to a known bug in libvirt.
Work around the issue by switching to the direct backend.
Signed-off-by: Yumei Huang <yuhuang@redhat.com>
---
test/prepare-distro-img.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/prepare-distro-img.sh b/test/prepare-distro-img.sh
index 0d967c9..423eea7 100755
--- a/test/prepare-distro-img.sh
+++ b/test/prepare-distro-img.sh
@@ -3,6 +3,8 @@
IMG="$1"
PASST_FILES="$(echo ../*.c ../*.h ../*.sh ../*.1 ../Makefile ../README.md)"
+export LIBGUESTFS_BACKEND=direct
+
virt-edit -a $IMG /lib/systemd/system/serial-getty@.service -e 's/ExecStart=.*/ExecStart=\/sbin\/agetty --autologin root -8 --keep-baud 115200,38400,9600 %I $TERM/g'
guestfish --rw -a $IMG -i <<EOF
--
2.47.0
next reply other threads:[~2025-09-25 5:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 5:43 Yumei Huang [this message]
2025-09-25 6:25 ` David Gibson
2025-09-25 8:53 ` Richard W.M. Jones
2025-09-25 9:40 ` Stefano Brivio
2025-09-25 10:27 ` Richard W.M. Jones
2025-09-25 10:54 ` Stefano Brivio
2025-09-26 1:00 ` Yumei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925054306.15964-1-yuhuang@redhat.com \
--to=yuhuang@redhat.com \
--cc=berrange@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=rjones@redhat.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).