From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IIWIBu6Q; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id B5B385A0275 for ; Thu, 25 Sep 2025 11:40:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758793231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IZYydAJPqUOUFQPKehKuZ+lcOqO9V20D96QzHNLxG60=; b=IIWIBu6Qj9t9rfM9BZ2qDn+gpc2y1meob627T8rX6zWAynKwUR5tcmCuYwVa6myRPRzQT5 iVHos/DfvKg3BCO+0mVaxA4Nky+vDtfn9ZsnlFbXs6td239Q5pKB+ukR7UfHmpzNaXq83F Ea+6wk3O1WV/ua7C4dacQK8kRINd5Tg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-KXN3LPraNquoxWui99BT2Q-1; Thu, 25 Sep 2025 05:40:30 -0400 X-MC-Unique: KXN3LPraNquoxWui99BT2Q-1 X-Mimecast-MFC-AGG-ID: KXN3LPraNquoxWui99BT2Q_1758793229 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3f7b5c27d41so365783f8f.0 for ; Thu, 25 Sep 2025 02:40:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758793229; x=1759398029; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IZYydAJPqUOUFQPKehKuZ+lcOqO9V20D96QzHNLxG60=; b=SrwEiJGVjxCRwX16dToAcpZsuh+olnr7AiwTH46m6essnDKV7OCBc5nN9VoLNXXMgw 1wOok9VmNYyxieFPKfwUU5FQdDgixuTo+8d/1N8Xv9gy0cszlcGgd+J4JrUi7Mb/4n1e 6QPDisneFKCiDWXixMwn+p5aCxV49AdW6MJketl+UFIqQ6xPyrd9QGI2+h2Jfi7dMFTS u0c1w28Ip8rrEEne29UGugx+WlFK9s3nzo+kzKEByt/oLPqAbFHsd1E+mfVGtdOsBL/I o35XHwaO24ChXXzXXId2jI+lt79zWD4b1Rf3B0gj8h2I1Wqs3WBTxKKUkKm/seWvig9g 11yA== X-Forwarded-Encrypted: i=1; AJvYcCUOq3oflvsG7ROL7VnTLQFoZWTWhZ6YNgniSYyz4TB7XPqcDIAH+IH+/GZblaBQw4/SYPz47EZoA3U=@passt.top X-Gm-Message-State: AOJu0Yw9aZprVM866U5GeR+OONr7M6F5NfWZMBWjy5f26n69Aoc/QyZW /BBzlbNuUh2niHxCXBj76jUD5c6KXwYLJW6phyQZawgQtXcIU2AHJSaDnUUVd6mb6oJKv/4wKmy 0llOWkk5RTLL5mqk4EKRJf6iWaHYaOPRO3HG4p0QYik77uo0p+Iz+hQ== X-Gm-Gg: ASbGncs3sLiRCAfDQvcMhnDqqGKR5T3SWqn0lJeg3t2k6161CDJ/HgRubeX5odVr+mq mQikSlgZsWxP16g689o0ejiyhFmgAis4koJbrWLMGQTlKLhtmXhEzoveiWBg8w8Fxdnw/EDKzth 1uw/StVqHhC4P2wX13cRisRIAhqyQ5fHVD3yiXcGQC8QQuUE3rJn544C4Gf75zqtcU1pj1k3+Jc 96Uixg8elwhWV37r0tXNoZHf6UEXKkBk2Chw+sTiNkjGctm7+r0m0R2XKazyd0skuwmp1ih4Ko9 t26AWGRrtVqWK+tpCGorojwCkxV1j4xFCMgcY8ywGW/YdWOBto0= X-Received: by 2002:a05:6000:25c3:b0:3f4:5bda:2710 with SMTP id ffacd0b85a97d-40f5fdb1113mr1579580f8f.9.1758793228674; Thu, 25 Sep 2025 02:40:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEstMByIWU/y5dEXObXDL3e76OIthLUrMePvOQzTxmtcL5v9fxbQZAJrM2kD5v6Omh4J3Jo2w== X-Received: by 2002:a05:6000:25c3:b0:3f4:5bda:2710 with SMTP id ffacd0b85a97d-40f5fdb1113mr1579569f8f.9.1758793228282; Thu, 25 Sep 2025 02:40:28 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e33bf701dsm25468405e9.24.2025.09.25.02.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Sep 2025 02:40:27 -0700 (PDT) Date: Thu, 25 Sep 2025 11:40:25 +0200 From: Stefano Brivio To: "Richard W.M. Jones" Subject: Re: [PATCH] test: fix 'make assets' failure as root Message-ID: <20250925114025.14ea1815@elisabeth> In-Reply-To: <20250925085305.GW1460@redhat.com> References: <20250925054306.15964-1-yuhuang@redhat.com> <20250925085305.GW1460@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sge2a9Wq0Hqp73LEqYvtUlkbucDJ_l0lo1ATB3P4DAU_1758793229 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: T5TONXYOGTPDTGHIPUIGFRA6FNEGWLQR X-Message-ID-Hash: T5TONXYOGTPDTGHIPUIGFRA6FNEGWLQR X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Yumei Huang , passt-dev@passt.top, david@gibson.dropbear.id.au, berrange@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 25 Sep 2025 09:53:06 +0100 "Richard W.M. Jones" wrote: > On Thu, Sep 25, 2025 at 01:43:06PM +0800, Yumei Huang wrote: > > Running `make assets` under `test` as root fails with a "Permission denied" > > error when `prepare-distro-img.sh` invokes `virt-edit` and `guestfish`. This > > is due to a known bug in libvirt. > > > > Work around the issue by switching to the direct backend. > > > > Signed-off-by: Yumei Huang > > --- > > test/prepare-distro-img.sh | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/test/prepare-distro-img.sh b/test/prepare-distro-img.sh > > index 0d967c9..423eea7 100755 > > --- a/test/prepare-distro-img.sh > > +++ b/test/prepare-distro-img.sh > > @@ -3,6 +3,8 @@ > > IMG="$1" > > PASST_FILES="$(echo ../*.c ../*.h ../*.sh ../*.1 ../Makefile ../README.md)" > > > > +export LIBGUESTFS_BACKEND=direct > > Please add a comment that this is only added as a temporary hack until > we can get a proper fix (in libguestfs possibly, see Dan's earlier > email). On the other hand, regardless of that fix, I would be happy to be run this on single-user Alpine L1 guests, eventually, where libguestfs doesn't depend on libvirt (see my caveat 2.), and I usually reserve very little disk space for those. If you don't have compelling reasons (like you're dropping LIBGUESTFS_BACKEND=direct in two weeks), I would simply keep this as long as it works. The day you drop that, we'll drop this too. This part won't be executed as part of automated distribution tests either, so occasional breakages are really unproblematic. Do you see any further issue with it? -- Stefano