public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
* [PATCH] test: Update mbuto profile to fix the symlink of /bin
@ 2025-09-26  8:47 Yumei Huang
  2025-09-26 12:37 ` Stefano Brivio
  0 siblings, 1 reply; 2+ messages in thread
From: Yumei Huang @ 2025-09-26  8:47 UTC (permalink / raw)
  To: passt-dev, sbrivio; +Cc: david, yuhuang

When running test 'migrate/rampstream_out' on fedora, test fails
with error like this:

  guest_1$ socat -u EXEC:"rampstream send 6000000" TCP4:192.0.2.1:10006
  2025/09/24 04:06:12 socat[405] E execvp("rampstream", "rampstream", "send", "6000000", ...): No such file or directory

It's because on fedora, /bin is not in the PATH, and some binaries
are under /usr/bin. mbuto will find the binaries on the host and put
them into the guest under same directories. As a result, /usr/bin in
mbuto guest are not empty, causing creating /usr/bin symlink failed.
Thus, the script 'rampstream' under /bin is not found during testing.

This patch fixes the issue and creates the symlink for consistency
with /sbin.

Link: https://bugs.passt.top/show_bug.cgi?id=151
Suggested-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Yumei Huang <yuhuang@redhat.com>
---
 test/passt.mbuto | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/passt.mbuto b/test/passt.mbuto
index 176cf3f..231b9c9 100755
--- a/test/passt.mbuto
+++ b/test/passt.mbuto
@@ -64,7 +64,9 @@ set >> \$LOG
 exit 0
 EOF
 	chmod 755 /sbin/dhclient-script
-	ln -s /bin /usr/bin
+	mv /bin/* /usr/bin || :
+	rm -rf /bin
+	ln -s /usr/bin /bin
 	ln -s /run /var/run
 	:> /etc/fstab
 
-- 
2.47.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] test: Update mbuto profile to fix the symlink of /bin
  2025-09-26  8:47 [PATCH] test: Update mbuto profile to fix the symlink of /bin Yumei Huang
@ 2025-09-26 12:37 ` Stefano Brivio
  0 siblings, 0 replies; 2+ messages in thread
From: Stefano Brivio @ 2025-09-26 12:37 UTC (permalink / raw)
  To: Yumei Huang; +Cc: passt-dev, david

On Fri, 26 Sep 2025 16:47:40 +0800
Yumei Huang <yuhuang@redhat.com> wrote:

> When running test 'migrate/rampstream_out' on fedora, test fails
> with error like this:
> 
>   guest_1$ socat -u EXEC:"rampstream send 6000000" TCP4:192.0.2.1:10006
>   2025/09/24 04:06:12 socat[405] E execvp("rampstream", "rampstream", "send", "6000000", ...): No such file or directory
> 
> It's because on fedora, /bin is not in the PATH, and some binaries
> are under /usr/bin. mbuto will find the binaries on the host and put
> them into the guest under same directories. As a result, /usr/bin in
> mbuto guest are not empty, causing creating /usr/bin symlink failed.
> Thus, the script 'rampstream' under /bin is not found during testing.
> 
> This patch fixes the issue and creates the symlink for consistency
> with /sbin.
> 
> Link: https://bugs.passt.top/show_bug.cgi?id=151
> Suggested-by: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>

Applied.

-- 
Stefano


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-26 12:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-26  8:47 [PATCH] test: Update mbuto profile to fix the symlink of /bin Yumei Huang
2025-09-26 12:37 ` Stefano Brivio

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).