From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZgqtFGLd; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 036CD5A0271 for ; Fri, 26 Sep 2025 11:12:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758877973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hTcT1ijpKa/+IRVjeGlRd1OydtJMYYEAl+QiT10t2XM=; b=ZgqtFGLdXKzW1yTcS4oTOrn6Imzb3PCO5SUC6tYfPhg4JR35eWI4ss5otnqcfe3gWyyZUJ Yb6kP7zBlX1Yumam2LvhPDfWz+jSDM6ZuDS3AWNN4HeNg2jt/jyzTBy2adsOOXDwtEJlQC 39lYy+Z0gOxjSpHdmeQ1mjUASXJDcOY= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-CAQ8LUzfNnGuSTzdAG6Z2g-1; Fri, 26 Sep 2025 05:12:52 -0400 X-MC-Unique: CAQ8LUzfNnGuSTzdAG6Z2g-1 X-Mimecast-MFC-AGG-ID: CAQ8LUzfNnGuSTzdAG6Z2g_1758877971 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 994A118004D4; Fri, 26 Sep 2025 09:12:50 +0000 (UTC) Received: from localhost (unknown [10.45.224.19]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ACC3119560AB; Fri, 26 Sep 2025 09:12:49 +0000 (UTC) Date: Fri, 26 Sep 2025 10:12:48 +0100 From: "Richard W.M. Jones" To: Yumei Huang Subject: Re: [PATCH v2] test: fix 'make assets' failure as root Message-ID: <20250926091248.GB1460@redhat.com> References: <20250926011714.5978-1-yuhuang@redhat.com> MIME-Version: 1.0 In-Reply-To: <20250926011714.5978-1-yuhuang@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aclTHfBC3Rg0X97udjrJ8BuoCPo-F30Uq8bBbsuvPsg_1758877971 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Message-ID-Hash: WZHGANS3PBTKKYJNHEKED3B5TMICGTH3 X-Message-ID-Hash: WZHGANS3PBTKKYJNHEKED3B5TMICGTH3 X-MailFrom: rjones@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, david@gibson.dropbear.id.au, berrange@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Sep 26, 2025 at 09:17:14AM +0800, Yumei Huang wrote: > Running `make assets` under `test` as root fails with a "Permission denied" > error when `prepare-distro-img.sh` invokes `virt-edit` and `guestfish`. This > is due to a known bug in libvirt. > > Work around the issue by switching to the direct backend. > > Signed-off-by: Yumei Huang > --- > test/prepare-distro-img.sh | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/test/prepare-distro-img.sh b/test/prepare-distro-img.sh > index 0d967c9..be2386e 100755 > --- a/test/prepare-distro-img.sh > +++ b/test/prepare-distro-img.sh > @@ -3,6 +3,10 @@ > IMG="$1" > PASST_FILES="$(echo ../*.c ../*.h ../*.sh ../*.1 ../Makefile ../README.md)" > > +# This is just a workaround for Fedora and related distributions. > +# Once it gets fixed, we can drop this. > +export LIBGUESTFS_BACKEND=direct > + > virt-edit -a $IMG /lib/systemd/system/serial-getty@.service -e 's/ExecStart=.*/ExecStart=\/sbin\/agetty --autologin root -8 --keep-baud 115200,38400,9600 %I $TERM/g' > > guestfish --rw -a $IMG -i < -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW