[PATCH v2] test: fix 'make assets' failure as root

[PATCH v2] test: fix 'make assets' failure as root

[Yumei Huang]

Running `make assets` under `test` as root fails with a "Permission denied"
error when `prepare-distro-img.sh` invokes `virt-edit` and `guestfish`. This
is due to a known bug in libvirt.

Work around the issue by switching to the direct backend.

Signed-off-by: Yumei Huang <yuhuang@redhat.com>
---
 test/prepare-distro-img.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/test/prepare-distro-img.sh b/test/prepare-distro-img.sh
index 0d967c9..be2386e 100755
--- a/test/prepare-distro-img.sh
+++ b/test/prepare-distro-img.sh
@@ -3,6 +3,10 @@
 IMG="$1"
 PASST_FILES="$(echo ../*.c ../*.h ../*.sh ../*.1 ../Makefile ../README.md)"
 
+# This is just a workaround for Fedora and related distributions.
+# Once it gets fixed, we can drop this.
+export LIBGUESTFS_BACKEND=direct
+
 virt-edit -a $IMG /lib/systemd/system/serial-getty@.service -e 's/ExecStart=.*/ExecStart=\/sbin\/agetty --autologin root -8 --keep-baud 115200,38400,9600 %I $TERM/g'
 
 guestfish --rw -a $IMG -i <<EOF
-- 
2.47.0

Re: [PATCH v2] test: fix 'make assets' failure as root

[Richard W.M. Jones]

On Fri, Sep 26, 2025 at 09:17:14AM +0800, Yumei Huang wrote:
> Running `make assets` under `test` as root fails with a "Permission denied"
> error when `prepare-distro-img.sh` invokes `virt-edit` and `guestfish`. This
> is due to a known bug in libvirt.
> 
> Work around the issue by switching to the direct backend.
> 
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>
> ---
>  test/prepare-distro-img.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/test/prepare-distro-img.sh b/test/prepare-distro-img.sh
> index 0d967c9..be2386e 100755
> --- a/test/prepare-distro-img.sh
> +++ b/test/prepare-distro-img.sh
> @@ -3,6 +3,10 @@
>  IMG="$1"
>  PASST_FILES="$(echo ../*.c ../*.h ../*.sh ../*.1 ../Makefile ../README.md)"
>  
> +# This is just a workaround for Fedora and related distributions.
> +# Once it gets fixed, we can drop this.
> +export LIBGUESTFS_BACKEND=direct
> +
>  virt-edit -a $IMG /lib/systemd/system/serial-getty@.service -e 's/ExecStart=.*/ExecStart=\/sbin\/agetty --autologin root -8 --keep-baud 115200,38400,9600 %I $TERM/g'
>  
>  guestfish --rw -a $IMG -i <<EOF

Reviewed-by: Richard W.M. Jones <rjones@redhat.com>

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW

Re: [PATCH v2] test: fix 'make assets' failure as root

[Stefano Brivio]

On Fri, 26 Sep 2025 09:17:14 +0800
Yumei Huang <yuhuang@redhat.com> wrote:

> Running `make assets` under `test` as root fails with a "Permission denied"
> error when `prepare-distro-img.sh` invokes `virt-edit` and `guestfish`. This
> is due to a known bug in libvirt.
> 
> Work around the issue by switching to the direct backend.
> 
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>

Applied.

-- 
Stefano