From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Yumei Huang <yuhuang@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] test: Update lib/term for clearer output when DEBUG is enabled
Date: Fri, 26 Sep 2025 14:37:51 +0200 [thread overview]
Message-ID: <20250926143751.14a4d072@elisabeth> (raw)
In-Reply-To: <aNYxdMUxa2KZPv1Y@zatzit>
On Fri, 26 Sep 2025 16:23:48 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Fri, Sep 26, 2025 at 02:15:53PM +0800, Yumei Huang wrote:
> > When running tests with DEBUG=1, we used to get some
> > "DEBUG:DEBUG:DEBUG:" in logs, which is not very helpful for
> > debugging.
> >
> > With this patch, the log would show the steps like below:
> >
> > DEBUG: g1tools ip jq dhclient socat cat
> > DEBUG: htools ip jq
> > DEBUG:
> > DEBUG: set MAP_HOST4 192.0.2.1
> > DEBUG: set MAP_HOST6 2001:db8:9a55::1
> >
> > Suggested-by: David Gibson <david@gibson.dropbear.id.au>
> > Signed-off-by: Yumei Huang <yuhuang@redhat.com>
>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
> Some extra background that might be useful in the commit message:
>
>
> The problem here is that "${@}" is magic and expands to multiple
> arguments, even though it's quoted. That means instead of the whole
> message going into a single string, the "DEBUG:" becomes the format
> string and the rest goes into unused parameters.
Applied, with this addition to the commit message.
--
Stefano
next prev parent reply other threads:[~2025-09-26 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 6:15 Yumei Huang
2025-09-26 6:23 ` Stefano Brivio
2025-09-26 6:23 ` David Gibson
2025-09-26 12:37 ` Stefano Brivio [this message]
2025-09-28 1:40 ` Yumei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250926143751.14a4d072@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).