From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jACfmemz; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 004125A0271 for ; Fri, 26 Sep 2025 14:37:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758890276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=69LuX3zswZSsMgrC1ybKSOiZkg2XLZLbvkgw5Xa4b4A=; b=jACfmemznQZCTlLNCGASdxRV5mk7GkOiQzCZ8fizl51s1DgIWV/hEU2/aidQi1t3Zw/qgW +B6M0LONrhIA47ToPuxNz8YPUVY6y2k86wX1kWGvQoktfzCk1sKq3ep0YGyX1AfUL+vM42 MGnBSQFe8H1vN/wuNPSFiQVtbSUu5F0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-Ucd4DnHLMFW0BOFAgb_zxA-1; Fri, 26 Sep 2025 08:37:54 -0400 X-MC-Unique: Ucd4DnHLMFW0BOFAgb_zxA-1 X-Mimecast-MFC-AGG-ID: Ucd4DnHLMFW0BOFAgb_zxA_1758890273 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3ecdfe971abso1531881f8f.2 for ; Fri, 26 Sep 2025 05:37:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758890273; x=1759495073; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=69LuX3zswZSsMgrC1ybKSOiZkg2XLZLbvkgw5Xa4b4A=; b=t2HDqtd3iUr0iDbh7goXN4nrdeK4YMYoO+ciU/+4id767DepDk2N89tVzhd8/PrZDs HxtJ2GbSuusYuqUk+G0Ony7yAid/IPIFjcq4Bst9w8H2M9jaMUldkBSEYgs6dHvFh00W HmsfR5YbmD8Gfb62u13pepqbY240QwUzChmHxeCg004tEiPAbpbqBwbctwBqSi8W81Bk udNaor/n1eBQI9nmplu3zDZiofSD2j3sil99JR9pzQzaCzdKwo2G3ROHqrYUWFmbbutB EAxzBmDpi/BmkULRDzv9ULFJ/kp7T4pZ5suWSvJiEAiOIsJhcSTpmmqQNmHqglZ3pnRr U5pA== X-Gm-Message-State: AOJu0Ywo/CQBnD7HMCUyqoeA8vqwJ+TKJS2FiJkxW6rT8dGtHgFZ/jwF IfKij2h5RR5c22rq+weCakNw8DJtQMCpBkQjzi4yLVlJKfpvUdxCXJnT6Q6y6SJB9txhOTonAAw /dBEF+49PS9dg4jUPa+Y7Jy4guSaET0BNb3KwNrwV16HvAwi0v37A7A== X-Gm-Gg: ASbGnctkB8d8EO4ECGOE5zcfv3eGz4SpzXK5GDwhfjHBbaBVFCRoWwMgsbYrpVUbMQw GurElSeCiJ/1EqcZR0SlRcIy183C8huYPwOV4fEIqTjNULJxiBLOoNA6kO1/prer0cAFVwKJEPg ZiQn3t7Uy8rnSJDrSSncJRghUEx2g2eizwiuxdPKU0UT7ojH4iBRg3LuY74oIv8OSYFIgTTkfqt HpZgdxSVkbMSCiOJ8eQq7dsnbxY2/1Ii2cTrTA1zhtWzhBIBRiafZ4EQt+18mmNumI0lPtOpHGy dF9ZjRfg/fTHIguGlOouW0oM7pDL/UFXNELIybsRRINSr4cw+1UB36RnawqVScD8bcZL X-Received: by 2002:a5d:64e8:0:b0:3ff:17ac:a34b with SMTP id ffacd0b85a97d-40e499acbf7mr6438493f8f.42.1758890273283; Fri, 26 Sep 2025 05:37:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG5LDwsriNbFWHvLmhQ8GwUpiW8HZzk6qDBQHfLXYUN7XfEqYyDVSPSTyF1Mh3Nst7vpm3mKg== X-Received: by 2002:a5d:64e8:0:b0:3ff:17ac:a34b with SMTP id ffacd0b85a97d-40e499acbf7mr6438478f8f.42.1758890272881; Fri, 26 Sep 2025 05:37:52 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e2a9ac55esm128011245e9.6.2025.09.26.05.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Sep 2025 05:37:52 -0700 (PDT) Date: Fri, 26 Sep 2025 14:37:51 +0200 From: Stefano Brivio To: David Gibson , Yumei Huang Subject: Re: [PATCH] test: Update lib/term for clearer output when DEBUG is enabled Message-ID: <20250926143751.14a4d072@elisabeth> In-Reply-To: References: <20250926061553.16039-1-yuhuang@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: iL9mZzhG5fNgX_tGBRVh5uvU86uHwT3KGd55zID_80g_1758890273 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: WNE6S44WHLDJU7WSUOIKOD3V6XKVZ6GH X-Message-ID-Hash: WNE6S44WHLDJU7WSUOIKOD3V6XKVZ6GH X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 26 Sep 2025 16:23:48 +1000 David Gibson wrote: > On Fri, Sep 26, 2025 at 02:15:53PM +0800, Yumei Huang wrote: > > When running tests with DEBUG=1, we used to get some > > "DEBUG:DEBUG:DEBUG:" in logs, which is not very helpful for > > debugging. > > > > With this patch, the log would show the steps like below: > > > > DEBUG: g1tools ip jq dhclient socat cat > > DEBUG: htools ip jq > > DEBUG: > > DEBUG: set MAP_HOST4 192.0.2.1 > > DEBUG: set MAP_HOST6 2001:db8:9a55::1 > > > > Suggested-by: David Gibson > > Signed-off-by: Yumei Huang > > Reviewed-by: David Gibson > > Some extra background that might be useful in the commit message: > > > The problem here is that "${@}" is magic and expands to multiple > arguments, even though it's quoted. That means instead of the whole > message going into a single string, the "DEBUG:" becomes the format > string and the rest goes into unused parameters. Applied, with this addition to the commit message. -- Stefano