From: Stefano Brivio <sbrivio@redhat.com>
To: Yumei Huang <yuhuang@redhat.com>
Cc: passt-dev@passt.top, david@gibson.dropbear.id.au
Subject: Re: [PATCH v2] test: Fix printf error when debug is enabled
Date: Tue, 30 Sep 2025 13:13:53 +0200 [thread overview]
Message-ID: <20250930131353.5b9d75fa@elisabeth> (raw)
In-Reply-To: <20250930014158.6949-1-yuhuang@redhat.com>
On Tue, 30 Sep 2025 09:41:58 +0800
Yumei Huang <yuhuang@redhat.com> wrote:
> Running test pasta/tcp with debug enabled would get stuck with
> below error:
>
> + printf 'DEBUG: ns socat -u OPEN:__BASEPATH__/big.bin TCP6:[__GW6__%__IFNAME__]:10003\n'
> lib/term: line 38: printf: `_': invalid format character
>
> The error occurs because printf interprets the % character as the
> start of a format specifier, and the following '_' isn't one of
> them.
>
> Fix it by replacing 'printf "${*}"' with 'printf "%b" "${*}"'.
> Also update the docstring.
>
> Link: https://bugs.passt.top/show_bug.cgi?id=154
> Fixes: de28c20d8051 ("test: Update lib/term for clearer output when DEBUG is enabled")
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>
Applied.
--
Stefano
prev parent reply other threads:[~2025-09-30 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 1:41 Yumei Huang
2025-09-30 2:10 ` David Gibson
2025-09-30 11:13 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930131353.5b9d75fa@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).