From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cToo1pSN; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 6DC255A0271 for ; Tue, 30 Sep 2025 13:14:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759230848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/P0G3CeEUjWaab2Z5Hm/JjMxNGVDMdW/OTZ0yvZMi68=; b=cToo1pSNffN8YlxaxvtwkRHq/ZTeBqAYHND3KlhjqRj2SUb0KFU0xiZQ8g7fza8KBPEmYg vH/mk2SMlMqCesIRp4t5YT//NGKZ3N8lm/YuA44+1Bkm8f2D+EN5CMjHauG98CSAB482IW oZThAGre3HVZSu9urb8g4/0tw9c8vPM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-Go29So49MnG5VCuHuRIxXg-1; Tue, 30 Sep 2025 07:14:06 -0400 X-MC-Unique: Go29So49MnG5VCuHuRIxXg-1 X-Mimecast-MFC-AGG-ID: Go29So49MnG5VCuHuRIxXg_1759230845 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-46e4c8fa2b1so9628765e9.0 for ; Tue, 30 Sep 2025 04:14:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759230845; x=1759835645; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/P0G3CeEUjWaab2Z5Hm/JjMxNGVDMdW/OTZ0yvZMi68=; b=wHjs6HsGCNRg1ATI9CBvj+00LUiK2ZfzZSMnHieCnEyrPEL0uDP1CISg911WiYt5Jw BrsBVHFmarX3VDNYmo/xgkj17II7jmtUDlsSofH4lMYTfvp/HcV38g9dIpcLaZHDUXUc JrSH5RX6cKjEgfd8Ibbgc+D0/8IyezcY/zdsntUcVei3gThLGLUtPV5S8xL1WD97LQQU iGx2V1bFFSaxqQ2mK9MUdeL8MAo8mfBPSKfcIYg0OfMB4azQx7kSxKk7GWUX7+McDYcP 08/szWpkP7rCGbF98bmBK48xRLSAGfHam7YmMfm9poWTJE45QKZPNXq/0m5Ejb+x7nHt 5ofg== X-Gm-Message-State: AOJu0YyMcMu3UhBkaEOKSk5qzM04ibwUAPCQTU9hQdla2jCUvdKTbiZB lC16AJFwdh/jnym2TisSFNQdChbAhXuRMo3L4TXaSrDXf4dmGOyy+gpyplXcKVLDsLHQaFaNWoQ GQu/rXV2gMSQLJoIxmJCpHS0yj2TjS+6vx+qdatoyEJXuJb28YlvgOQ== X-Gm-Gg: ASbGncutUGsZz1nzDcibphxL7Ii21wlUx+Rff5QEpNL5OMB67XRbjWckKL41WdOSviK bkLRUEJBqjP1M4wrMMJEy3D202yDFUgBpK5oYPxHVo3sTFbLIcgqZz3TonXACLEqoqH9zdh2xIh uT/PMEPx44/yqEOfyYnExSwmOupi1TjK/CUVV4FEbfUCSGnILZecYq9jIU9fTzvZsjpm4pwRhYs THcmh2JrbMhe9rCwElu+n5wLt0xJXzzjuB6iV+6cQnAbuxk1gUT1mWrY1JrIiQFNp4l2jVJVe2C 1FqH6lBq///xLIDA49DYAzRRZpSQi3Ns55bMyOpNuntNUCVM5L0Rs1j0TT5LKs31dwu1q6zz7g= = X-Received: by 2002:a05:600c:1d06:b0:45b:9912:9f30 with SMTP id 5b1f17b1804b1-46e329a0d0amr172185525e9.6.1759230845334; Tue, 30 Sep 2025 04:14:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeKGlq1G3MEtLRRXwABxzhnzM7A/faYFED8xiVmcmk0GWOvEzw6SWVnuPjNDQ3+ZROWgFj1w== X-Received: by 2002:a05:600c:1d06:b0:45b:9912:9f30 with SMTP id 5b1f17b1804b1-46e329a0d0amr172185325e9.6.1759230844944; Tue, 30 Sep 2025 04:14:04 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e56ee6b19sm59628175e9.0.2025.09.30.04.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Sep 2025 04:14:03 -0700 (PDT) Date: Tue, 30 Sep 2025 13:14:02 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] netlink: Don't require address to be global, just not link local Message-ID: <20250930131402.7f6797d5@elisabeth> In-Reply-To: <20250930054911.1800690-1-david@gibson.dropbear.id.au> References: <20250930054911.1800690-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: i5CsMSdFvmyvG9S_l4CwTHGDOkciAwjsUXOvBCzr0rk_1759230845 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ZF3KINAUV5OMR5LFZWMN3Z3EYYNV3T5Q X-Message-ID-Hash: ZF3KINAUV5OMR5LFZWMN3Z3EYYNV3T5Q X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Xun Gu X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 30 Sep 2025 15:49:11 +1000 David Gibson wrote: > nl_addr_get() will only pick up global IPv6 addresses (RT_SCOPE_UNIVERSE). > This is because link-local addresses aren't suitable. However site-local > addresses (in the rare occassions they're used) would be fine for our > purposes. In fact, anything wider than link scope is fine, so update the > check to reflect that. > > Change the logic in the test scripts to match as well. > > Reported-by: Xun Gu > Link: https://bugs.passt.top/show_bug.cgi?id=122 > > Signed-off-by: David Gibson > --- > netlink.c | 2 +- > test/demo/podman | 4 ++-- > test/migrate/basic | 2 +- > test/migrate/basic_fin | 2 +- > test/migrate/iperf3_bidir6 | 2 +- > test/migrate/iperf3_in6 | 2 +- > test/migrate/iperf3_many_out6 | 2 +- > test/migrate/iperf3_out6 | 2 +- > test/migrate/rampstream_in | 2 +- > test/migrate/rampstream_out | 2 +- > test/passt/dhcp | 2 +- > test/passt/ndp | 2 +- > test/passt_in_ns/dhcp | 2 +- > test/pasta/dhcp | 2 +- > test/pasta/ndp | 2 +- > test/perf/pasta_tcp | 2 +- > test/perf/pasta_udp | 2 +- > test/two_guests/basic | 2 +- > 18 files changed, 19 insertions(+), 19 deletions(-) > > diff --git a/netlink.c b/netlink.c > index c4367807..9fe70f2c 100644 > --- a/netlink.c > +++ b/netlink.c > @@ -786,7 +786,7 @@ int nl_addr_get(int s, unsigned int ifi, sa_family_t af, > > prefix_max = *prefix_len = ifa->ifa_prefixlen; > } else if (af == AF_INET6 && addr && > - ifa->ifa_scope == RT_SCOPE_UNIVERSE && > + ifa->ifa_scope < RT_SCOPE_LINK && Oh, I had no idea RT_SCOPE_SITE even existed. Applied. -- Stefano