From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 1/6] test: Convince make not to accidentally delete exetool
Date: Wed, 1 Oct 2025 19:51:57 +1000 [thread overview]
Message-ID: <20251001095202.3875003-2-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20251001095202.3875003-1-david@gibson.dropbear.id.au>
Our exeter tests make use of exetool, a tool that's part of the exeter
tree. Both Yumei and I have seen cases where exetool is missing, despite
it being from an external tree we shouldn't be touching.
I haven't pinned down the exact circumstances in which this happens, but I
think this is occurring because the way the Makefile refers to it can make
it look like an intermediate target that make may delete when interrupted.
Mark it as .PRECIOUS to prevent that.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
test/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/Makefile b/test/Makefile
index 49388276..69987d0b 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -81,6 +81,8 @@ pull-%: %
exeter:
git clone https://gitlab.com/dgibson/exeter.git
+# Don't delete this, make, even though it looks like an intermediate target
+.PRECIOUS: exeter/exetool/exetool
exeter/exetool/exetool: pull-exeter
mbuto:
--
2.51.0
next prev parent reply other threads:[~2025-10-01 9:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 9:51 [PATCH 0/6] Test and linter fixups David Gibson
2025-10-01 9:51 ` David Gibson [this message]
2025-10-02 3:26 ` [PATCH 1/6] test: Convince make not to accidentally delete exetool David Gibson
2025-10-01 9:51 ` [PATCH 2/6] test: Add linting of Python test scripts David Gibson
2025-10-01 10:23 ` Stefano Brivio
2025-10-01 10:40 ` Paul Holzinger
2025-10-01 10:48 ` Stefano Brivio
2025-10-02 1:31 ` David Gibson
2025-10-02 1:09 ` David Gibson
2025-10-01 9:51 ` [PATCH 3/6] clang-tidy: Suppress redundant expression warning David Gibson
2025-10-01 9:52 ` [PATCH 4/6] cppcheck: Suppress the suppression of a suppression David Gibson
2025-10-01 9:52 ` [PATCH 5/6] cppcheck: Suppress a buggy cppcheck warning David Gibson
2025-10-01 9:52 ` [PATCH 6/6] cppcheck: Suppress variable scope warnings in dhcpv6() David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251001095202.3875003-2-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).