From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=SJlQNU3Z; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id A370C5A0276 for ; Wed, 01 Oct 2025 11:52:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759312328; bh=ksCvZoFbcwjmIdjt6zmnTLryJDEXB7gunYmt7PGetaQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SJlQNU3ZoTE/4AGPuNYjPSxqnq0XovtbwqqqUS+Wcjs10Hc5aDTnFWJIKTJ1mdnnL LMCeNSylIAy2adYjd10C8UPy0sOmkNqHEBvhufes+TWly6XdT3RvYWT//xwY8qOIa+ VKtwlKxcLu02Oow1025FbbiKHQObPDp0aDcns2jv/PJE6kE4diZKeHKPpv1JEyfOIy jYFVit1yZGlgOmGZ2TNY0TaxjwLqVyFP1XpW/g1BP95K5+F515JRwDjDLTtZJp80xf hOEYezIXT5s3+q0YyeYHT7rCdcTYjgsFx/KaWqVhy4bLSJHE5EQHwU+RS64FKeEn37 zGly4JEhjt/bg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cc9FN2PSfz4wDG; Wed, 1 Oct 2025 19:52:08 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 1/6] test: Convince make not to accidentally delete exetool Date: Wed, 1 Oct 2025 19:51:57 +1000 Message-ID: <20251001095202.3875003-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001095202.3875003-1-david@gibson.dropbear.id.au> References: <20251001095202.3875003-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: HQTRY2IMPYWDUUXN2AD6MKTMFBJC7WVA X-Message-ID-Hash: HQTRY2IMPYWDUUXN2AD6MKTMFBJC7WVA X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Our exeter tests make use of exetool, a tool that's part of the exeter tree. Both Yumei and I have seen cases where exetool is missing, despite it being from an external tree we shouldn't be touching. I haven't pinned down the exact circumstances in which this happens, but I think this is occurring because the way the Makefile refers to it can make it look like an intermediate target that make may delete when interrupted. Mark it as .PRECIOUS to prevent that. Signed-off-by: David Gibson --- test/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/Makefile b/test/Makefile index 49388276..69987d0b 100644 --- a/test/Makefile +++ b/test/Makefile @@ -81,6 +81,8 @@ pull-%: % exeter: git clone https://gitlab.com/dgibson/exeter.git +# Don't delete this, make, even though it looks like an intermediate target +.PRECIOUS: exeter/exetool/exetool exeter/exetool/exetool: pull-exeter mbuto: -- 2.51.0