From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=o4PdMmcH; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 4E74C5A061B for ; Wed, 01 Oct 2025 11:52:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759312328; bh=o5Jdh/OJAetFWrP017FjWuuvXLCgZNAjyJdGjueNiGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o4PdMmcHqoFJdejhgmK8Me30rQ3+NCJRoer2c3raomxLmX81oaPIiTweg2Oue8ocI UJM87wG1f0NTvj834/yTJaEqeT2OQm2fBxNu+oaYAmE4TqXKS9bkA48aMGSP6g9Wqb mFYs94BnceJGul4/lCVZlgpF8HCbVnDsG3h3quvuXbzBCt4FDhK90PV7vfkISUzjNj YeFTG7A9bSSb/rqC1L3QFCaVilADSLPTend9ihIBDgl1aP7qAOE/zim2TiBbwbzy2h hMV12O+pNGJH9cSbWhTvaN+gB9oqoVIhSOZ/ulzRQ2RMc3CnAv+9OxWu/Y+aetBINN YmnHnu+jvYSjQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cc9FN325Vz4wDL; Wed, 1 Oct 2025 19:52:08 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 5/6] cppcheck: Suppress a buggy cppcheck warning Date: Wed, 1 Oct 2025 19:52:01 +1000 Message-ID: <20251001095202.3875003-6-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001095202.3875003-1-david@gibson.dropbear.id.au> References: <20251001095202.3875003-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: NWKZZXPPG677ZDKLHQOLFUMTCKAPBDED X-Message-ID-Hash: NWKZZXPPG677ZDKLHQOLFUMTCKAPBDED X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Another cppcheck package in Fedora, another bogus false positive. This one seems to not realise that a variable has been initialised by getsockopt() under a complicated set of circumstances. Signed-off-by: David Gibson --- tcp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tcp.c b/tcp.c index 48b1ef29..7da41797 100644 --- a/tcp.c +++ b/tcp.c @@ -1030,6 +1030,11 @@ int tcp_update_seqack_wnd(const struct ctx *c, struct tcp_tap_conn *conn, return 0; } + /* This trips a cppcheck bug in some versions, including + * cppcheck 2.18.3. + * https://sourceforge.net/p/cppcheck/discussion/general/thread/fecde59085/ + */ + /* cppcheck-suppress [uninitvar,unmatchedSuppression] */ conn->seq_ack_to_tap = tinfo->tcpi_bytes_acked + conn->seq_init_from_tap; -- 2.51.0