From: Stefano Brivio <sbrivio@redhat.com>
To: Paul Holzinger <pholzing@redhat.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 2/6] test: Add linting of Python test scripts
Date: Wed, 1 Oct 2025 12:48:36 +0200 [thread overview]
Message-ID: <20251001124836.32ea603f@elisabeth> (raw)
In-Reply-To: <779811c8-ec8b-4426-86ca-4fbeb31769ee@redhat.com>
On Wed, 1 Oct 2025 12:40:09 +0200
Paul Holzinger <pholzing@redhat.com> wrote:
> On 01/10/2025 12:23, Stefano Brivio wrote:
> > On Wed, 1 Oct 2025 19:51:58 +1000
> > David Gibson <david@gibson.dropbear.id.au> wrote:
> >
> >> We currently have one test moved to the new exeter based framwork written
> >> in Python. We plan to add many more, so add linting (flake8) and type
> >> checking (mypy) of those scripts. This can be invoked manually with
> >> "make flake8" or "make mypy" in test/, and is also added to the static
> >> checkers test set.
> > I never used a Python linter, so I'm not sure if it's as bad as Go or
> > Rust linters taking the whole poetry away, as it happened for instance
> > in my most recent experience with 'cargo fmt':
> >
> > https://github.com/AsahiLinux/muvm/compare/68094c02c19b6f5d5e3def6d29379c1244c9a5e4..9af11c334a1ce37f533c056d982f8608c8d80d27#diff-e1a95ce380b9a8a317f97cccce1cbfd3dccd343dc62169ed1340208ab304fab9L106
> >
> > https://github.com/AsahiLinux/muvm/pull/111#discussion_r1863551727
> > (you need to click around before you get to it, no idea how to share
> > a proper link that opens that comment right away)
>
> Not really on topic for this series but since you brought up rust there
> is actually a "#[rustfmt::skip]" attribute that can be used to skip the
> formatting selectively in case you need it in the future.
Ah, thanks, I didn't know about it. Now that you mention that, I just
found out that, with flake8, it looks like one can ignore the entire
file with "# flake8: noqa" on a line of its own:
https://stackoverflow.com/a/64431741
but still, my doubts remain.
--
Stefano
next prev parent reply other threads:[~2025-10-01 10:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 9:51 [PATCH 0/6] Test and linter fixups David Gibson
2025-10-01 9:51 ` [PATCH 1/6] test: Convince make not to accidentally delete exetool David Gibson
2025-10-02 3:26 ` David Gibson
2025-10-01 9:51 ` [PATCH 2/6] test: Add linting of Python test scripts David Gibson
2025-10-01 10:23 ` Stefano Brivio
2025-10-01 10:40 ` Paul Holzinger
2025-10-01 10:48 ` Stefano Brivio [this message]
2025-10-02 1:31 ` David Gibson
2025-10-02 1:09 ` David Gibson
2025-10-01 9:51 ` [PATCH 3/6] clang-tidy: Suppress redundant expression warning David Gibson
2025-10-01 9:52 ` [PATCH 4/6] cppcheck: Suppress the suppression of a suppression David Gibson
2025-10-01 9:52 ` [PATCH 5/6] cppcheck: Suppress a buggy cppcheck warning David Gibson
2025-10-01 9:52 ` [PATCH 6/6] cppcheck: Suppress variable scope warnings in dhcpv6() David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251001124836.32ea603f@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).