From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SaOKv7w9; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 1CC385A026F for ; Wed, 01 Oct 2025 12:48:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759315721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v+cYaqXgTCRWLuhDO8S1dS0KmlohmVSgtDMA2wJ+ECI=; b=SaOKv7w9zJ7CXoocKpy72SERKXt8OScSz9e5ImoFd73oyHdUJgBDqI+hPVbhNRazZXE7fg OUxHT85tRG0soP2ViKSekvZ3BA0PhzqjOOvVdjM01cx4MbXrVmzX+C23awHhaq4ElzE0fX Txa/sAaCFD/6iOqB/jKm9et0ykork70= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-4ykxhWzqOTe6Q3UxZDPOUQ-1; Wed, 01 Oct 2025 06:48:39 -0400 X-MC-Unique: 4ykxhWzqOTe6Q3UxZDPOUQ-1 X-Mimecast-MFC-AGG-ID: 4ykxhWzqOTe6Q3UxZDPOUQ_1759315719 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3ecdc9dbc5fso4906459f8f.1 for ; Wed, 01 Oct 2025 03:48:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759315718; x=1759920518; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=v+cYaqXgTCRWLuhDO8S1dS0KmlohmVSgtDMA2wJ+ECI=; b=fdovRx7wGN8sJpWb7CysTNVjqMB9fsa1Vv47zUVoSkLx7j4J0IwBkn17+ZEEy0dZtD C45ALl6elZBojIz7z7ly8kcDrums7AvXe0+THSkrJmNSbohszOxT5JUG1DOcy7JnN9cC r8fyQ9L1ODFcfUUmB6FkRY/C8fJLbA+8gW4xBkLLePchQ7RgF3zu77j8xao57PvI2q4m gDGYRYQSeaOpYbGBbKT/rc3iDfLt7py7LTJyvT1uc+gO6pGRUvm1XPdOa63s6FQg20hF tgPJ/bIHiIQpJErh+O28vM4wxFhgZmKEvMad7/451lR/S9S2pfQdwIjn9h9fHEAHZym4 YjXA== X-Gm-Message-State: AOJu0YzGOZpqRyER6s36ZbLPA6obqtljrRhQLdego2c/mGHdWGc6/ApA dTszjN84eSbz7lrtoFEI8Vvy/Sheh4LFI0rqcurrw5qTV2kSvnRN48Uo5p+QtU7jCdgHYJw2LPB J656bFhD8XXXl8hHbz6eV0aaxxqefPPEQ8FWrk0bJ1dt7D6M2AXYXJQ== X-Gm-Gg: ASbGncvclrh1UuWGrwXtH43Xw9vfTo7lBlmuLsfrdGVGVJPZzGWEjQReYeXUNl/GZj7 KvAFb82OGqdW/l0/E9ZWGoA2yoL9wzx0yFaTLG+EF43DWJ/QWf2TLfcrNkFKv0Jy48HqwHOcQrt tdTWXtbkoXT2j/W3pPU4SReQ44KIJbLEnCmuN4QpYClvquNL1n0k3mSzLS6+H6OzwFbB0t0yBuL SGiwKva1RqUr6sjPA9mwL1rTB5tFtbye3Csy9FhaYLMcF9nB8AxorPJP8xlnKhyb84PNtKrvcpk R1okULxWdSrl/ZwhZZC53kNRSNqlJ38UoG0kATy1p59OggGpm3WDFHaY X-Received: by 2002:a05:600c:8206:b0:46e:428a:b50e with SMTP id 5b1f17b1804b1-46e612624c7mr24540645e9.3.1759315718599; Wed, 01 Oct 2025 03:48:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGIrCl3SzvbMbyLVLdhfVKJY4OYGUlD702PJsbXevJBeqa1R7riPk51pSi0RgW+aBwuk+s8iQ== X-Received: by 2002:a05:600c:8206:b0:46e:428a:b50e with SMTP id 5b1f17b1804b1-46e612624c7mr24540425e9.3.1759315718088; Wed, 01 Oct 2025 03:48:38 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb89fb19fsm26974361f8f.21.2025.10.01.03.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Oct 2025 03:48:37 -0700 (PDT) Date: Wed, 1 Oct 2025 12:48:36 +0200 From: Stefano Brivio To: Paul Holzinger Subject: Re: [PATCH 2/6] test: Add linting of Python test scripts Message-ID: <20251001124836.32ea603f@elisabeth> In-Reply-To: <779811c8-ec8b-4426-86ca-4fbeb31769ee@redhat.com> References: <20251001095202.3875003-1-david@gibson.dropbear.id.au> <20251001095202.3875003-3-david@gibson.dropbear.id.au> <20251001122351.7020b79a@elisabeth> <779811c8-ec8b-4426-86ca-4fbeb31769ee@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xp-k2wy47_Jxvcuu_6l_NzVnRXQVcwfUmaIz7HXr00E_1759315719 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: FPWANPSES7IYPX4H5TEDRE2TUWACTEJH X-Message-ID-Hash: FPWANPSES7IYPX4H5TEDRE2TUWACTEJH X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 1 Oct 2025 12:40:09 +0200 Paul Holzinger wrote: > On 01/10/2025 12:23, Stefano Brivio wrote: > > On Wed, 1 Oct 2025 19:51:58 +1000 > > David Gibson wrote: > > > >> We currently have one test moved to the new exeter based framwork written > >> in Python. We plan to add many more, so add linting (flake8) and type > >> checking (mypy) of those scripts. This can be invoked manually with > >> "make flake8" or "make mypy" in test/, and is also added to the static > >> checkers test set. > > I never used a Python linter, so I'm not sure if it's as bad as Go or > > Rust linters taking the whole poetry away, as it happened for instance > > in my most recent experience with 'cargo fmt': > > > > https://github.com/AsahiLinux/muvm/compare/68094c02c19b6f5d5e3def6d29379c1244c9a5e4..9af11c334a1ce37f533c056d982f8608c8d80d27#diff-e1a95ce380b9a8a317f97cccce1cbfd3dccd343dc62169ed1340208ab304fab9L106 > > > > https://github.com/AsahiLinux/muvm/pull/111#discussion_r1863551727 > > (you need to click around before you get to it, no idea how to share > > a proper link that opens that comment right away) > > Not really on topic for this series but since you brought up rust there > is actually a "#[rustfmt::skip]" attribute that can be used to skip the > formatting selectively in case you need it in the future. Ah, thanks, I didn't know about it. Now that you mention that, I just found out that, with flake8, it looks like one can ignore the entire file with "# flake8: noqa" on a line of its own: https://stackoverflow.com/a/64431741 but still, my doubts remain. -- Stefano