From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=ZjJvflaq; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 2A6875A0275 for ; Thu, 02 Oct 2025 06:50:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759380614; bh=ED0T9r5tJShXeuvJ570wP85sY5VFm8xsl0k+YNBJGuk=; h=From:To:Cc:Subject:Date:From; b=ZjJvflaqu6PllWXlLr4/8LnQkobu/0HiyFb4t6qQF6Jsutb68o6CpR3G4r/gbeFl2 5y8THyTQryRWD7h2nuMe/DnhDRjxDymIVuv+qifMbDvkUhdxXsB4oyB3oPGn97ezUU gNk9TPsisRzdMICzdUN+kL32sNACI7JPPvo2gbdvedaXJhl7sNsLLyNE4yxjOgETxF wnECgxkVl8+tGhEm/I/54ohrqI9KRek1h0VExX3ylBnp43+mDRWsV8VTLZBKOlEmND kqZV2QG1Y9h4Yo04KwTZzHRHAycVFAEfzocAIlHHpUO1oMRQYoU5eNmE9EOjYH+F0W Yj2JVUX6cHtKQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ccfVZ50B0z4wDH; Thu, 2 Oct 2025 14:50:14 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 0/6] Test and linter fixups Date: Thu, 2 Oct 2025 14:50:06 +1000 Message-ID: <20251002045012.4047974-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.51.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: OQVO2Y4U7OET6ZD23X5QGFOF3RQYI3BI X-Message-ID-Hash: OQVO2Y4U7OET6ZD23X5QGFOF3RQYI3BI X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Before starting to convert testcases to use tunbridge, I wanted to add linting for the Python test scripts. While doing that I discovered a new crop of cppcheck and clang-tidy false positives, and a Makefile bug. Here's a batch of fixes. I didn't manage to get through the whole testsuite with this. I keep getting hangs on rampstream_out, which I *think* are unrelated. v2: * Actually understood why exetool was being deleted, and fixed it properly. David Gibson (6): test: Add linting of Python test scripts clang-tidy: Suppress redundant expression warning cppcheck: Suppress the suppression of a suppression cppcheck: Suppress a buggy cppcheck warning cppcheck: Suppress variable scope warnings in dhcpv6() test: Don't delete exetool on make clean dhcpv6.c | 8 ++++++++ linux_dep.h | 2 +- tcp.c | 5 +++++ test/Makefile | 19 +++++++++++++++---- test/build/build.py | 5 +++-- test/build/static_checkers.sh | 6 +++++- vhost_user.c | 1 + 7 files changed, 38 insertions(+), 8 deletions(-) -- 2.51.0