From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=UtBZ7+HO; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 078615A061A for ; Thu, 02 Oct 2025 06:50:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759380614; bh=f8DbnPbjvKtqiF2JNRXPsyxoUtmbpCwoj6WHMqSx9V0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UtBZ7+HOHdLhZ19s9K0nvvD9FqSkuo2cjKnLvDV5j9CTVHDC7a/lpXAPhHMUo9o6x DP2ttvpLPTsfiNfNNeCw29pFUfnWJFpnpX/qSXZ5yC7BAA7QcHX9DjC4P4tyjTL+tD oXOxqiq3Kmb+v9AyMlAH0xGkH8/TFZkUZEOStUDzv1p65o12IGnF43CuA0N0gxJ+qb KY4hDHzoLgdYNiOnHN9sOAFWrczXWf50fduiVl/cuWdfy/ZZJAZYsv6HnZlWIPddk2 ItRmATft0o5OWsTNMfN2z7/kZyTMDZl8joOUUBROdsqQYftAbPTlw+y1jc9ZPxDPHW 7AkRGzibn1o+g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ccfVZ5Q4Lz4w2S; Thu, 2 Oct 2025 14:50:14 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 2/6] clang-tidy: Suppress redundant expression warning Date: Thu, 2 Oct 2025 14:50:08 +1000 Message-ID: <20251002045012.4047974-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251002045012.4047974-1-david@gibson.dropbear.id.au> References: <20251002045012.4047974-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: ASWUQIMDHT32BO4MCYN67PZANYOLNVZS X-Message-ID-Hash: ASWUQIMDHT32BO4MCYN67PZANYOLNVZS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: clang-tidy 20.1.8 doesn't like (VHOST_USER_MAX_VQS / 2), because it expands to (2 / 2). But in the context of the #define, this makes logical sense, so suppress the warning. I'm not sure why it isn't firing on the debug() line just below. Possibly it only complains once per expression per function, so we only have to suppress it once? Signed-off-by: David Gibson --- vhost_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vhost_user.c b/vhost_user.c index fa343a86..223332d5 100644 --- a/vhost_user.c +++ b/vhost_user.c @@ -939,6 +939,7 @@ static bool vu_get_queue_num_exec(struct vu_dev *vdev, { (void)vdev; + /* NOLINTNEXTLINE(misc-redundant-expression) */ vmsg_set_reply_u64(vmsg, VHOST_USER_MAX_VQS / 2); debug("VHOST_USER_MAX_VQS %u", VHOST_USER_MAX_VQS / 2); -- 2.51.0