public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 6/6] test: Don't delete exetool on make clean
Date: Thu,  2 Oct 2025 14:50:12 +1000	[thread overview]
Message-ID: <20251002045012.4047974-7-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20251002045012.4047974-1-david@gibson.dropbear.id.au>

exetool is listed in $(LOCAL_ASSETS), which seems like it makes sense,
until you realise that $(LOCAL_ASSETS) are deleted on make clean, and we
can't rebuild exetool after deleting it (since it's just part of the
exeter tree we download).  Move it to $(DOWNLOAD_ASSETS) instead.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 test/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/test/Makefile b/test/Makefile
index 61ccb075..60fd12a7 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -54,15 +54,14 @@ UBUNTU_NEW_IMGS = xenial-server-cloudimg-powerpc-disk1.img \
 	jammy-server-cloudimg-s390x.img
 UBUNTU_IMGS = $(UBUNTU_OLD_IMGS) $(UBUNTU_NEW_IMGS)
 
-DOWNLOAD_ASSETS = exeter mbuto podman \
+DOWNLOAD_ASSETS = $(EXETOOL) mbuto podman \
 	$(DEBIAN_IMGS) $(FEDORA_IMGS) $(OPENSUSE_IMGS) $(UBUNTU_IMGS)
 TESTDATA_ASSETS = small.bin big.bin medium.bin \
 	rampstream
 LOCAL_ASSETS = mbuto.img mbuto.mem.img podman/bin/podman QEMU_EFI.fd \
 	$(DEBIAN_IMGS:%=prepared-%) $(FEDORA_IMGS:%=prepared-%) \
 	$(UBUNTU_NEW_IMGS:%=prepared-%) \
-	nstool guest-key guest-key.pub $(EXETOOL) \
-	$(TESTDATA_ASSETS)
+	nstool guest-key guest-key.pub $(TESTDATA_ASSETS)
 
 ASSETS = $(DOWNLOAD_ASSETS) $(LOCAL_ASSETS)
 
-- 
2.51.0


      parent reply	other threads:[~2025-10-02  4:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02  4:50 [PATCH v2 0/6] Test and linter fixups David Gibson
2025-10-02  4:50 ` [PATCH v2 1/6] test: Add linting of Python test scripts David Gibson
2025-10-02  4:50 ` [PATCH v2 2/6] clang-tidy: Suppress redundant expression warning David Gibson
2025-10-02  4:50 ` [PATCH v2 3/6] cppcheck: Suppress the suppression of a suppression David Gibson
2025-10-02  4:50 ` [PATCH v2 4/6] cppcheck: Suppress a buggy cppcheck warning David Gibson
2025-10-02  4:50 ` [PATCH v2 5/6] cppcheck: Suppress variable scope warnings in dhcpv6() David Gibson
2025-10-02  4:50 ` David Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251002045012.4047974-7-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).