public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v3 0/6] Test and linter fixups
Date: Thu,  2 Oct 2025 15:04:31 +1000	[thread overview]
Message-ID: <20251002050437.4175553-1-david@gibson.dropbear.id.au> (raw)

Before starting to convert testcases to use tunbridge, I wanted to add
linting for the Python test scripts.  While doing that I discovered a
new crop of cppcheck and clang-tidy false positives, and a Makefile
bug.

Here's a batch of fixes.

I didn't manage to get through the whole testsuite with this.  I keep
getting hangs on rampstream_out, which I *think* are unrelated.

v3:
 * Delete mypy's cache on make clean
v2:
 * Actually understood why exetool was being deleted, and fixed it
   properly.

David Gibson (6):
  clang-tidy: Suppress redundant expression warning
  cppcheck: Suppress the suppression of a suppression
  cppcheck: Suppress a buggy cppcheck warning
  cppcheck: Suppress variable scope warnings in dhcpv6()
  test: Don't delete exetool on make clean
  test: Add linting of Python test scripts

 dhcpv6.c                      |  8 ++++++++
 linux_dep.h                   |  2 +-
 tcp.c                         |  5 +++++
 test/Makefile                 | 20 ++++++++++++++++----
 test/build/build.py           |  5 +++--
 test/build/static_checkers.sh |  6 +++++-
 vhost_user.c                  |  1 +
 7 files changed, 39 insertions(+), 8 deletions(-)

-- 
2.51.0


             reply	other threads:[~2025-10-02  5:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02  5:04 David Gibson [this message]
2025-10-02  5:04 ` [PATCH v3 1/6] clang-tidy: Suppress redundant expression warning David Gibson
2025-10-02  5:04 ` [PATCH v3 2/6] cppcheck: Suppress the suppression of a suppression David Gibson
2025-10-02  5:04 ` [PATCH v3 3/6] cppcheck: Suppress a buggy cppcheck warning David Gibson
2025-10-02  5:04 ` [PATCH v3 4/6] cppcheck: Suppress variable scope warnings in dhcpv6() David Gibson
2025-10-02  5:04 ` [PATCH v3 5/6] test: Don't delete exetool on make clean David Gibson
2025-10-02  5:04 ` [PATCH v3 6/6] test: Add linting of Python test scripts David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251002050437.4175553-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).