From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 2/3] test: Add some missing quoting in exeter runner
Date: Thu, 2 Oct 2025 17:57:07 +1000 [thread overview]
Message-ID: <20251002075708.461931-3-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20251002075708.461931-1-david@gibson.dropbear.id.au>
exeter() quoted ${__testid}, but in some places we use it there's an
extra level of shell, which needs another layer of quoting. This breaks
if testids include ';', which is quite common in exeter tests created as
a composition/pipeline of two functions. Add the required extra quoting.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
test/lib/exeter | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/test/lib/exeter b/test/lib/exeter
index 3b19beaa..530c6909 100644
--- a/test/lib/exeter
+++ b/test/lib/exeter
@@ -47,9 +47,9 @@ exeter() {
[ ${CI} -eq 1 ] && video_link "${1}"
for __testid in $($EXETOOL list -- "$@"); do
- __desc="$($EXETOOL desc -- "$@" -- ${__testid})"
+ __desc="$($EXETOOL desc -- "$@" -- "${__testid}")"
status_test_start "${__desc}"
- context_run host "$@" "${__testid}" && status_test_ok || status_test_fail
+ context_run host "$* '${__testid}'" && status_test_ok || status_test_fail
done
cd ..
--
2.51.0
next prev parent reply other threads:[~2025-10-02 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 7:57 [PATCH 0/3] RFC: Preview of tunbridge based tests David Gibson
2025-10-02 7:57 ` [PATCH 1/3] test: Prepare for " David Gibson
2025-10-02 7:57 ` David Gibson [this message]
2025-10-02 7:57 ` [PATCH 3/3] test: Re-implement pasta NDP tests using tunbridge & exeter David Gibson
2025-10-02 7:57 ` [PATCH 0/3] RFC: Preview of tunbridge based tests David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002075708.461931-3-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).