From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EU0feCoI; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 6AD885A0619 for ; Tue, 07 Oct 2025 00:51:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759791092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hHOJQpL7OH6qOyeaEbXoxAO0G9DVymorYmq+7ZtC9B0=; b=EU0feCoIca/iD17+oWA648x5mkUMvCKygS2BLKg1rAWBa2YZEl1UpdOnbdEcSPay92qNa8 pHM4MF/AinzhdIq+87sYsFBrNIHyhmo6KlubZxdm/npFaS7GnOxAGfKT6MmijsummgckmW 8NRLxKeiuPxsiGeXNANIZiechcQgrxk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-KFaNJTsWOyq3yCQtpoHdSw-1; Mon, 06 Oct 2025 18:51:31 -0400 X-MC-Unique: KFaNJTsWOyq3yCQtpoHdSw-1 X-Mimecast-MFC-AGG-ID: KFaNJTsWOyq3yCQtpoHdSw_1759791090 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-46e3a049abaso28827535e9.0 for ; Mon, 06 Oct 2025 15:51:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759791090; x=1760395890; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hHOJQpL7OH6qOyeaEbXoxAO0G9DVymorYmq+7ZtC9B0=; b=OYBVfkfY97Ust/fNPRFuyYaF0HsvSl/j5+L0wyd4+ThgRLoOZKv8gfDisK9I5T40pe y/c3+EEm0sQf0Dfg46sHE65bb5CubSCsXIvL4rZppHV1s1kl8hT+vHzPeWd52p0sSV/C EWqejDa9iM9zYPFoq2E+v4WEL9YRHSB6/wkh2QNg9+VwshZcBlr7W5ZsH+kyKijdhU4s 7wPNlBhFQjJchb18rKxxrZ4siPAJobAmKmP/ToGlDCsZRlZXjJXNfHwmF3EOSV0ongJO isr1C+fk/mq+nFzBHu1+ca894s5D9oMTtDgT+twYiQrJi2zJBvt04mhzOFBbfOvNehIE gTdw== X-Forwarded-Encrypted: i=1; AJvYcCUAYpXHKIjf85hm9033LqFmDDnlcrButC+9qeJDq1O3TfklK66V1n2Kc3ODuiKAhlje7B5cBveUi3U=@passt.top X-Gm-Message-State: AOJu0Yxnm5dsZ7jjxhifFHpYHGmKbnuLXJss6EljKnCFEDA/+c1qKfqA 22b603Ik/Z7mIy8xLKsS2Vryl92Fcg/N4DPKDpLKmG7q8hHF/9Tu2pXYsMNZ/uOcn1vJUTAUG9m Dhzqqj/q1saZnX0nY8aMXTjf2Hs0gtFZa+VNQn5gHvD4LHfjT79LVqg== X-Gm-Gg: ASbGncuO2CFQ1zwHKSWMlZaVCJZJeETZEvShry99ERqC0bxPeR2pAzWwIbBG4oKLF+3 rNzd3CuDA5OWqV8Qs/401NvdA8isRKp306e3kPPVZ23CTOUtCGzfN/j4P0BmUdT1MWLxbCS6Ydg OTRCRnQvTOjZT/ekWzk4JD/W1lyOnfrJS+NIRQLLnnkKDo0e0Hal7fYfGE0/8N2nuRRuiFCdOhv p7zyfl+hMJP7Q5zCTOsmljJdqOON1EuGa5sLKSNHxuL3F24aeOPSoAwj5hVcqj8H/gZ0GthZu7S GwaJGLrqdrEyncKIjyJAI3tdrZeDqmw/vxan/FQ1vJPJm8wdtg7BL44MIL7LL4lhxf6b1QJNQA= = X-Received: by 2002:a05:600c:1f11:b0:46e:6d5f:f68 with SMTP id 5b1f17b1804b1-46e7110c4ccmr102853575e9.12.1759791090043; Mon, 06 Oct 2025 15:51:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpEWhckgXNWRrBo1Q9RKVRnijChLtIQ/nkmEfQ8qJYFTF42kFTzj+NeIxqxJiQB+nfwkXkcQ== X-Received: by 2002:a05:600c:1f11:b0:46e:6d5f:f68 with SMTP id 5b1f17b1804b1-46e7110c4ccmr102853485e9.12.1759791089644; Mon, 06 Oct 2025 15:51:29 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e61a0241bsm266569995e9.11.2025.10.06.15.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Oct 2025 15:51:29 -0700 (PDT) Date: Tue, 7 Oct 2025 00:51:27 +0200 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v12 3/9] arp/ndp: send ARP announcement / unsolicited NA when neigbour entry added Message-ID: <20251007005127.545350af@elisabeth> In-Reply-To: <20251003003412.588801-4-jmaloy@redhat.com> References: <20251003003412.588801-1-jmaloy@redhat.com> <20251003003412.588801-4-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LrVF0aBIzApRLJIBeD8D64NVg1Q7mC-CG_KxFZpY6rs_1759791090 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: J3OPI5ZPRBAQNBHW43R65OKJOKLRLQ36 X-Message-ID-Hash: J3OPI5ZPRBAQNBHW43R65OKJOKLRLQ36 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: dgibson@redhat.com, david@gibson.dropbear.id.au, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Nit, in the title: neighbour. On Thu, 2 Oct 2025 20:34:06 -0400 Jon Maloy wrote: > ARP announcements and unsolicited NAs should be handled with caution > because of the risk of malignant users emitting them to disturb > network communication. > > There is however one case we where we know it is legitimate > and safe for us to send out such messages: The one time we switch > from using ctx->own_tap_mac to a MAC address received via the > recently added neigbour subscription function. Later changes to ...same here. Other than this, and all the pending comments (including changes to consistently represent guest-side link-layer addresses), and the remaining part of 2/9, the rest looks good to me. -- Stefano