From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gBgYWYaB; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id DB5AA5A061C for ; Tue, 07 Oct 2025 16:13:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759846430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hKc9OQaA55kMPa8mcVFaj3U3uQQv62Eldcj+RDXJi7c=; b=gBgYWYaBj2ijFZ0E9sxNegfxBQyxmAGrXJdMQLiKMSexg0/52IkL5cDkp1msPEH1YKuawI CLfjlmjZhIycCBAPk2mCM3tEqw0cVVBUe2e0AGGCk/rnmYzTzElv/D9q1CzVKqmPEu5MbI d937R9T6XS8wB1wBjlDvboXXREM+5f4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-178-5QqofocYOkSS4EkyhYB0yQ-1; Tue, 07 Oct 2025 10:13:49 -0400 X-MC-Unique: 5QqofocYOkSS4EkyhYB0yQ-1 X-Mimecast-MFC-AGG-ID: 5QqofocYOkSS4EkyhYB0yQ_1759846428 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-46e2c11b94cso33281735e9.3 for ; Tue, 07 Oct 2025 07:13:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759846428; x=1760451228; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hKc9OQaA55kMPa8mcVFaj3U3uQQv62Eldcj+RDXJi7c=; b=kIUeTkduTvIB4f1CpWQyZJtfKnBShe+FSTY0dgFjX/jIaf8jrI3lX1b/Ew4EMgJlbG w9b/TNJqmtJ84iYUhMsPW1RR20HAC5IwGE4asaohOgkn7mpDoIsl3Z/BHDIZOdx/qc5O 3/cuFWc+3luo2VJhM3T3IrjYqI+ynITx6b47NsZ8CgZTTplxGYATllZva5jTZDduUxzD 8vQ9xclyOU8y5ZgVfDGrZEf17dTxP1MZFHIXumvQEieZEQdJujRYM8pyxoJPv1Pm/cT1 alognfzvvlNHFKlD8lChJ9vNq6RNcWwj5TY1tRZMr+Mp+Sp6jcYyEIgdexHKp/o9ULoo bdXQ== X-Gm-Message-State: AOJu0Yyv+CXQQ7LYsj/9k1FNQiWQt/kNNxGGwoM6UL0B5R6p6PJETnc7 PSxtO2zVQ2zqfVNEgIZrIqTva7iyOEeD8Wc2cTJzMeppE81II75v7JVPIcAO27PpVQL1K9LmHI/ RdEY8JwGEW7+t6VRm0/x7QtqEBS2nqK2YO+wJbkCDsYI4YzQnuDgepg== X-Gm-Gg: ASbGncufDccqA8sGIo9beK18U8KTsm+kwxKloC2soODvB1x72WH9AJYbltLfFTXYF8i W0LGWFlTpq3l7XfQvzgLf8EmepvwZoDfsjfy17V/ubic0xRHBGehlqowcqNOAdcGQQ/lykBPHVX tjpxmLSUWyBfUx5XUv1rFOEbjYIvJt7KgDt/hP39nXkKCyNgOC/UV/G48ygc9pKn3GAi4UIMZ69 zxvTCOv3VWMuAY3K26O46s+x1LbAhln3QmlUtEnGtDW640fbAN+fIfLXTkWvQJ+ZR3ZBQKerqsB iStv2P1TqvauXvqgaLAEYaJU/7ZKU5YVsW8ZocYDhvGwCo6vulUmzjC7 X-Received: by 2002:a05:600c:8b71:b0:46e:36fa:6b40 with SMTP id 5b1f17b1804b1-46e7113d33fmr116626785e9.24.1759846428167; Tue, 07 Oct 2025 07:13:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9tnYWTFJO0NXNiYLzaDroLRpNvWvKlvQzcTqWR2SlCpk3WJoIOgcetgf/VJ3Mn2enhpH0Lw== X-Received: by 2002:a05:600c:8b71:b0:46e:36fa:6b40 with SMTP id 5b1f17b1804b1-46e7113d33fmr116626405e9.24.1759846427626; Tue, 07 Oct 2025 07:13:47 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e7234f547sm226303895e9.9.2025.10.07.07.13.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 07:13:47 -0700 (PDT) Date: Tue, 7 Oct 2025 16:13:46 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 0/6] Test and linter fixups Message-ID: <20251007161346.7771a4f1@elisabeth> In-Reply-To: <20251002050437.4175553-1-david@gibson.dropbear.id.au> References: <20251002050437.4175553-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jWT0BJPHr7tk6WrpUEJFjn9AO6FeDS7h2WPwy8_n67s_1759846428 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 5QG7Q3WP6I3NSPIPE24DVIRSAIAMIZG4 X-Message-ID-Hash: 5QG7Q3WP6I3NSPIPE24DVIRSAIAMIZG4 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 2 Oct 2025 15:04:31 +1000 David Gibson wrote: > Before starting to convert testcases to use tunbridge, I wanted to add > linting for the Python test scripts. While doing that I discovered a > new crop of cppcheck and clang-tidy false positives, and a Makefile > bug. > > Here's a batch of fixes. > > I didn't manage to get through the whole testsuite with this. I keep > getting hangs on rampstream_out, which I *think* are unrelated. I saw this once too, a couple of weeks ago. Maybe it's the same issue I've been trying to find the time to work on for a while now, that is, the kernel not freezing queues of the sockets from the source instance once they switch to repair mode. But it happened just once so I didn't try re-running with PCAP=1. I might, if it happens again. > v3: > * Delete mypy's cache on make clean > v2: > * Actually understood why exetool was being deleted, and fixed it > properly. > > David Gibson (6): > clang-tidy: Suppress redundant expression warning > cppcheck: Suppress the suppression of a suppression > cppcheck: Suppress a buggy cppcheck warning > cppcheck: Suppress variable scope warnings in dhcpv6() > test: Don't delete exetool on make clean > test: Add linting of Python test scripts I'm applying this now, even though, strictly speaking, this breaks tests because test/README.md doesn't mention one needs to install flake8 and mypy, and I don't think they're very commonly installed, so I think you should update it. -- Stefano