From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NYblVLGV; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 9DAAE5A061A for ; Wed, 08 Oct 2025 17:07:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759936058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5aNU5fZV97g5DsteN6/AlZGqyeycH8gM6g80FBJqrvQ=; b=NYblVLGVkIlyFmOtQuChTpCP79MyvIP61mZYr+7BBmxHVRHQVweFI2JtyD4jG4Qb8e7QZX o1P/p/BULTQs5ry7WUpYetvFv6DKUy0MBr61MSz39tBIIL2RHxRv3cyfOltteXjOPzAVsn ihxOrsrz8PcCmpC5wofTjYpAyKbfJ8U= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-3Mh_hPaaOweCry8shK2UWg-1; Wed, 08 Oct 2025 11:07:37 -0400 X-MC-Unique: 3Mh_hPaaOweCry8shK2UWg-1 X-Mimecast-MFC-AGG-ID: 3Mh_hPaaOweCry8shK2UWg_1759936056 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3f4fbdf144dso16190f8f.2 for ; Wed, 08 Oct 2025 08:07:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759936055; x=1760540855; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5aNU5fZV97g5DsteN6/AlZGqyeycH8gM6g80FBJqrvQ=; b=ZnfVawP2Wja7U+WJdZpwrEPE+VNn8md8quEC+2+TKvjYeG+NYOzv2Qi6n9b7ItQuYU 05+AQZNrAJL9cLcNE6wRRebYk/jvVev4REVt5tckkjmX35xw8iu5V6zfgNI1r2g4aEU/ NvmUUQhqVXnB5iTtt3a9Ez6cY91iWADE2BkKbaCt1WpCgaxgiOSRZKqnrlqSWzE0VLZ4 U33P/mCWGC3zTXBeXcdvhbXPHf0hDUTXf6wTTAEvVvKwN/TPYpNBE8wcf0LeYRjL1A3G FDUgt/Au/xqGyE1BxAgLN8evh+9L3jePU0Ba+nWNZUzhRIy3OfKejmKt+Iw59sCCUR/v ACcQ== X-Gm-Message-State: AOJu0YxNNaQRMX5DRwoA5BijhnPWxC5pwWOivuX+8brmQJoL3pzaAssI XZNJLHFNt+iuR+WB64Mzofs+A8Rl3Wc4dW/xX+lNQ/FgfUyxo/kAjWZpn+0pqq1BXIBGwW6NMAp rotUFhcHa2mpWhAzdCqdWKfurRLZYEfbRdaknLFsiAYNYHQ1DLICKOh2DXE6HSQ== X-Gm-Gg: ASbGncv6gjc9JQPgls+xbszNwXBs0dw9UbsVGSFoeINwRmH+wRhD6c1dqb4tx9vGkKp B8g19N/niNbqy72adznfrCcD4K+b+r6tYRQUYJbQuz7gnElvnzb1oCdZbNxmAGvv8ioe9AHloZp mY7YKvke2QP6EkSkqkWFTlzBDmfRSqttJ+yUK8NuAQPJP7WeRZYAHsAj4EH9umoQUBZtqC3+mGy uqi7vDynrXXzvvpfGNzTyABPQ+MV44fl81+1VvXNIu+mV54y8OyxQ9Npyt3gACIv20UEVclddo+ Uj3o8zzT+hjPvHScq9pby7Jx2+sV0hGegOfmW3TUXqYbvJ5wO8d3E3Dm X-Received: by 2002:a5d:5d85:0:b0:425:7e45:a4df with SMTP id ffacd0b85a97d-42666ac60c3mr2408655f8f.11.1759936055306; Wed, 08 Oct 2025 08:07:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnqVDx8wu79jR6utK+ECdVXkQ9y/TPFVkkhZkuOJ+90sx3LKCrhfACEN/Go94TGK93yQnYSg== X-Received: by 2002:a5d:5d85:0:b0:425:7e45:a4df with SMTP id ffacd0b85a97d-42666ac60c3mr2408618f8f.11.1759936054655; Wed, 08 Oct 2025 08:07:34 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8abe9bsm30544364f8f.22.2025.10.08.08.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Oct 2025 08:07:34 -0700 (PDT) Date: Wed, 8 Oct 2025 17:07:33 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2] tcp: Clarify logic calculating how much guest data to ack Message-ID: <20251008170733.213133e0@elisabeth> In-Reply-To: <20251008012249.115243-1-david@gibson.dropbear.id.au> References: <20251008012249.115243-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: irmVLAK3PnA_S1PMq2GdzyJRfyW2ETSGFnWIJu9hnbA_1759936056 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ZG7BKEL54EYQYPEZNR3ZOMLI3IKTC4AP X-Message-ID-Hash: ZG7BKEL54EYQYPEZNR3ZOMLI3IKTC4AP X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 8 Oct 2025 12:22:49 +1100 David Gibson wrote: > This is fairly complex, because we have a method we prefer but we need to > fall back to a simpler one in a bunch of cases. Slightly reorganise the > code to make the flow clearer, and add a large comment giving the > rationale. > > Signed-off-by: David Gibson Applied. -- Stefano