From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=EKMpej05; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id C5A6D5A0619 for ; Thu, 09 Oct 2025 05:44:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1759981439; bh=jctwvlaegyhVXtKYjDeTfYgpMgQ0UECRJn6Oh5g6sq8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EKMpej05LO1iXULKkcH0Nl9vFGD8NzSYQ9cx6QLaw2FpLHUzYmqujulKqaBbPXK0R cWaEAvD4kI3NPoVuWsno5juXlF7kZZuwtASfP7+iUjoS2S+ejR5GYNNN0jZVs2dXdT 8Dc/uBt2aO/uRrfBRNNCPXJmn1cRGCU63s3yUmOP8O1Pn277N7NB3SXPMPexn9pAmy ZjOCCjBrtO4JCItJdBMl8BDvFwE8Z3ScAuUkHeN0swUsXvvvl+ekRsXEPfA0SYzDN0 Ny48al8CaHO8E+Z1NRdUarGjXnohTcgOk7hBWI+MTqIgy+DfHcOztjdCgXeQ2wtIx0 AHGzFmK2Wumfw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4chwhv4wGPz4wCl; Thu, 9 Oct 2025 14:43:59 +1100 (AEDT) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 1/2] test: Add some missing quoting in exeter runner Date: Thu, 9 Oct 2025 14:43:57 +1100 Message-ID: <20251009034358.1256908-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251009034358.1256908-1-david@gibson.dropbear.id.au> References: <20251009034358.1256908-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: UBGTXTX7VM5TUBBUIQRRWYWH33LUPQAL X-Message-ID-Hash: UBGTXTX7VM5TUBBUIQRRWYWH33LUPQAL X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: exeter() quoted ${__testid}, but in some places we use it there's an extra level of shell, which needs another layer of quoting. This breaks if testids include ';', which is quite common in exeter tests created as a composition/pipeline of two functions. Add the required extra quoting. Signed-off-by: David Gibson --- test/lib/exeter | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/lib/exeter b/test/lib/exeter index 3b19beaa..530c6909 100644 --- a/test/lib/exeter +++ b/test/lib/exeter @@ -47,9 +47,9 @@ exeter() { [ ${CI} -eq 1 ] && video_link "${1}" for __testid in $($EXETOOL list -- "$@"); do - __desc="$($EXETOOL desc -- "$@" -- ${__testid})" + __desc="$($EXETOOL desc -- "$@" -- "${__testid}")" status_test_start "${__desc}" - context_run host "$@" "${__testid}" && status_test_ok || status_test_fail + context_run host "$* '${__testid}'" && status_test_ok || status_test_fail done cd .. -- 2.51.0