From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 1/2] test: Add some missing quoting in exeter runner
Date: Thu, 9 Oct 2025 21:28:56 +0200 [thread overview]
Message-ID: <20251009212856.6d0aa833@elisabeth> (raw)
In-Reply-To: <20251009034358.1256908-2-david@gibson.dropbear.id.au>
On Thu, 9 Oct 2025 14:43:57 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> exeter() quoted ${__testid}, but in some places we use it there's an
> extra level of shell, which needs another layer of quoting. This breaks
> if testids include ';', which is quite common in exeter tests created as
> a composition/pipeline of two functions. Add the required extra quoting.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> test/lib/exeter | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/lib/exeter b/test/lib/exeter
> index 3b19beaa..530c6909 100644
> --- a/test/lib/exeter
> +++ b/test/lib/exeter
> @@ -47,9 +47,9 @@ exeter() {
> [ ${CI} -eq 1 ] && video_link "${1}"
>
> for __testid in $($EXETOOL list -- "$@"); do
> - __desc="$($EXETOOL desc -- "$@" -- ${__testid})"
> + __desc="$($EXETOOL desc -- "$@" -- "${__testid}")"
> status_test_start "${__desc}"
> - context_run host "$@" "${__testid}" && status_test_ok || status_test_fail
> + context_run host "$* '${__testid}'" && status_test_ok || status_test_fail
Nit: for consistency, given that @ and * are variable names, I would
enclose them in curly brackets as well, while at it.
--
Stefano
next prev parent reply other threads:[~2025-10-09 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 3:43 [PATCH 0/2] Fixes to exeter test integration David Gibson
2025-10-09 3:43 ` [PATCH 1/2] test: Add some missing quoting in exeter runner David Gibson
2025-10-09 19:28 ` Stefano Brivio [this message]
2025-10-10 2:28 ` David Gibson
2025-10-09 3:43 ` [PATCH 2/2] test: For missing static checkers, skip rather than failing tests David Gibson
2025-10-09 19:29 ` Stefano Brivio
2025-10-10 3:11 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251009212856.6d0aa833@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).