From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ci17zhG+; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id E33B05A061C for ; Thu, 09 Oct 2025 21:29:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760038142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+bZ8U69DRDaCFb/nefHvzQOB+2Zq5u0FQ9+57OU51c=; b=Ci17zhG+SXCrH0cR5Qw/n2pAhyKjtec0m4CrUcGHod6qWI6WcT4xx0vbHB+lhxZV/ibwwt 4k7AJ+GT6L0AuniEgdXxuQmAvmZLfkGkMExxBqlPDyKQtUVMR7Pbk5uWy5YLrU3eywLL7X DfrIPPhacnRrbpY16/9INygQjIe8GS8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-300-VT4Ih10QOXW2MZiC79dg0w-1; Thu, 09 Oct 2025 15:29:01 -0400 X-MC-Unique: VT4Ih10QOXW2MZiC79dg0w-1 X-Mimecast-MFC-AGG-ID: VT4Ih10QOXW2MZiC79dg0w_1760038140 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-46e407c600eso8482065e9.3 for ; Thu, 09 Oct 2025 12:29:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760038138; x=1760642938; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=k+bZ8U69DRDaCFb/nefHvzQOB+2Zq5u0FQ9+57OU51c=; b=vY3KFEE3iyjUE0NcdjWtB4i2rmJNGAk5FpAJMdINvjRcdS38m23IRuUOcy6ka/nSQk 7y1jZl/LTnLbXvY7uUR4hZnPpgmiEli2XUlUoIvTuB9oyFVjLLbkwT3f9rlxMbdFGPNU AsMzdgeFxLEeIoccoBqqopT3FoUmUbz3URXDwSV1d2sSSg0QmC3rpXdrhGQtwslaRvLq YoSvxy9tdyv5wN2At7Y7b4ZZhfGndO8mmAk+2jnUBGwQpcHXJ4DYBRronm5/w4xkhq/K M9NEqYgOEI1WaDijFGwIS/jSt4QOvcASsu7FGpDIUBk4qS9Z3jeIeZXTl/LRanOAly+w 2PSQ== X-Gm-Message-State: AOJu0YwYobGUqoRZsUbvOVuB+3AOwLbEI9XFMPrPVGVQ74vWvy1e1VnC 3v//r7SUR/wnX/Vxtwb8WTou7PFkhOrQjncTcBXhh89Re7YMCqZvBxr0iyQCPzSrehth8sxI04u MUc8CIMu8Kd29S/pIfC+Ek0kPa5MWlpDNGLaxrfFXoNDSuUPCaA2xRXMqzvE0sA== X-Gm-Gg: ASbGncv1dvtB38EU+gh6o/N8ucqPYbHppSTkY62hLL27dVv2pGKQnOsUousGWHvBKx1 QIJ7H5C+FtUe32Mnybts6g2myGhEYLG4JwGrx2KitEATKyYra0Nxtu8mNYFJQ4mk4grUx6OBsVS yIJ1iZ7aQFPxwE70BUZGLVmXxKqNYDSKOcJu0QWYFF2f3rKukAiu2n278uZqny6MdtJxY5zZnkQ Vgq29YTTTwENbodIJ3rKwrKZdh86yx7vctyzn2dj/fORut+5M3jvJHlLF0d5boe8On89A6iNIup Vx6uuVDjLtCJyPEwsRGcQ3+Nlbp8xKp9w/puvDJK6rtOx6sFhjKm4okn X-Received: by 2002:a05:600c:37cd:b0:46e:59dd:1b55 with SMTP id 5b1f17b1804b1-46fa9a8b3e3mr63159685e9.2.1760038138444; Thu, 09 Oct 2025 12:28:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiNpwwSmWVLpt4vIM7Gr+MpnTdmqaXq+C+haMwrPKGTmHdcozj//0rc+6Zi41UKcgILN8YyA== X-Received: by 2002:a05:600c:37cd:b0:46e:59dd:1b55 with SMTP id 5b1f17b1804b1-46fa9a8b3e3mr63159525e9.2.1760038138045; Thu, 09 Oct 2025 12:28:58 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fb497af18sm9561695e9.3.2025.10.09.12.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 12:28:57 -0700 (PDT) Date: Thu, 9 Oct 2025 21:28:56 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 1/2] test: Add some missing quoting in exeter runner Message-ID: <20251009212856.6d0aa833@elisabeth> In-Reply-To: <20251009034358.1256908-2-david@gibson.dropbear.id.au> References: <20251009034358.1256908-1-david@gibson.dropbear.id.au> <20251009034358.1256908-2-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: LLsINVnqNNmUmuwgqLq6Wy7h0MP-Baf024JtHw49FuA_1760038140 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: LPGNVW7AP36Z6IDBGVBY76HDLYMUHHEC X-Message-ID-Hash: LPGNVW7AP36Z6IDBGVBY76HDLYMUHHEC X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 9 Oct 2025 14:43:57 +1100 David Gibson wrote: > exeter() quoted ${__testid}, but in some places we use it there's an > extra level of shell, which needs another layer of quoting. This breaks > if testids include ';', which is quite common in exeter tests created as > a composition/pipeline of two functions. Add the required extra quoting. > > Signed-off-by: David Gibson > --- > test/lib/exeter | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/test/lib/exeter b/test/lib/exeter > index 3b19beaa..530c6909 100644 > --- a/test/lib/exeter > +++ b/test/lib/exeter > @@ -47,9 +47,9 @@ exeter() { > [ ${CI} -eq 1 ] && video_link "${1}" > > for __testid in $($EXETOOL list -- "$@"); do > - __desc="$($EXETOOL desc -- "$@" -- ${__testid})" > + __desc="$($EXETOOL desc -- "$@" -- "${__testid}")" > status_test_start "${__desc}" > - context_run host "$@" "${__testid}" && status_test_ok || status_test_fail > + context_run host "$* '${__testid}'" && status_test_ok || status_test_fail Nit: for consistency, given that @ and * are variable names, I would enclose them in curly brackets as well, while at it. -- Stefano