From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au
Authentication-Results: passt.top;
	dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=ceCY2u52;
	dkim-atps=neutral
Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])
	by passt.top (Postfix) with ESMTPS id BB9055A026F
	for <passt-dev@passt.top>; Fri, 10 Oct 2025 05:45:52 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=gibson.dropbear.id.au; s=202510; t=1760067950;
	bh=ezhmUAevK7pjqS/ptAGG55KSP+2CbrvD8XwKs97IyzE=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=ceCY2u52bJvuC83Mq/EMjd6TFZ5Rjr4zgml0GuPvWN55HC2IGtQADKvLKCMGkPXiz
	 ELv/WG9/TlD54PuL8MI0SULvfrX1aACmjHPh4/rS3ZerpHISVIRTe6SxeC7eCum+P+
	 WTDB4PFcLsHG0z4KKrq6KcShUOYT3LsDyLmVERGh3xrmneTov3YLL4bLuzqRV4TsNk
	 nxSRZAt8OReO2HXDm6RMPFrQOovcj9Rhm5GXAnf2hkMvL0hQxZC12afjAF2czCYf6p
	 InKApQmuJTw/Cwsm+kcg0JdrqUS50y4/bOjbKDW/I8fbh7urCaSQ3l7SPSjjdibwXT
	 0sd6YeOy8XHgQ==
Received: by gandalf.ozlabs.org (Postfix, from userid 1007)
	id 4cjXhZ5Mjtz4wBD; Fri, 10 Oct 2025 14:45:50 +1100 (AEDT)
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top,
	Stefano Brivio <sbrivio@redhat.com>
Subject: [PATCH v2 1/3] test: Use ${} consistently in lib/exeter
Date: Fri, 10 Oct 2025 14:45:47 +1100
Message-ID: <20251010034549.1821828-2-david@gibson.dropbear.id.au>
X-Mailer: git-send-email 2.51.0
In-Reply-To: <20251010034549.1821828-1-david@gibson.dropbear.id.au>
References: <20251010034549.1821828-1-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-ID-Hash: VSDUM2FO4O4JLTMBUMLTYUVFNHFFPXPS
X-Message-ID-Hash: VSDUM2FO4O4JLTMBUMLTYUVFNHFFPXPS
X-MailFrom: dgibson@gandalf.ozlabs.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: David Gibson <david@gibson.dropbear.id.au>
X-Mailman-Version: 3.3.8
Precedence: list
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/20251010034549.1821828-2-david@gibson.dropbear.id.au/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/VSDUM2FO4O4JLTMBUMLTYUVFNHFFPXPS/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>

Most of the test shell scripts use {} around variable names even when it's
not required, for consistency.  lib/exeter didn't do so consistently,
however.  Correct that.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 test/lib/exeter | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/test/lib/exeter b/test/lib/exeter
index 3b19beaa..0b361599 100644
--- a/test/lib/exeter
+++ b/test/lib/exeter
@@ -13,18 +13,18 @@
 # Copyright Red Hat
 # Author: David Gibson <david@gibson.dropbear.id.au>
 
-EXETOOL="$BASEPATH/exeter/exetool/exetool"
+EXETOOL="${BASEPATH}/exeter/exetool/exetool"
 
 # is_exeter() - Determine if a test file is an exeter program
 # $@:	Command line to invoke test program
 is_exeter() {
-	$EXETOOL probe -- "$@"
+	${EXETOOL} probe -- "${@}"
 }
 
 # exeter() - Run each test in an exeter program, logging each test separately
 # $@:	Command line to invoke exeter test program
 exeter() {
-	STATESETUP="${STATEBASE}/$1"
+	STATESETUP="${STATEBASE}/${1}"
 	mkdir -p "${STATESETUP}"
 
 	context_setup_host host
@@ -32,9 +32,9 @@ exeter() {
 
 	cd test
 
-	__ntests=$($EXETOOL list -- "$@" | wc -l)
-	if [ $? != 0 ]; then
-		info "Failed to get exeter manifest for $@"
+	__ntests=$(${EXETOOL} list -- "${@}" | wc -l)
+	if [ ${?} != 0 ]; then
+		info "Failed to get exeter manifest for ${@}"
 		pause_continue \
 			"Press any key to pause test session"		\
 			"Resuming in "					\
@@ -43,13 +43,13 @@ exeter() {
 		return
 	fi
 
-	status_file_start "$* (exeter)" ${__ntests}
+	status_file_start "${*} (exeter)" ${__ntests}
 	[ ${CI} -eq 1 ] && video_link "${1}"
 
-	for __testid in $($EXETOOL list -- "$@"); do
-		__desc="$($EXETOOL desc -- "$@" -- ${__testid})"
+	for __testid in $(${EXETOOL} list -- "${@}"); do
+		__desc="$(${EXETOOL} desc -- "${@}" -- ${__testid})"
 		status_test_start "${__desc}"
-		context_run host "$@" "${__testid}" && status_test_ok || status_test_fail
+		context_run host "${@}" "${__testid}" && status_test_ok || status_test_fail
 	done
 
 	cd ..
-- 
2.51.0