From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=KvMZL7wi; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id C2B685A061A for ; Fri, 10 Oct 2025 05:45:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1760067950; bh=gucuXSEzj4mmLwL3kSlz8Dvly5aPho+VpeTOFRC0e7M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KvMZL7wi/dV8w4DG/7szO+YsQnDsh82JSoPegHtxv3WFRzNJqjNI8d8fM8l/jfmhM Q3dpT9I+5w4SKYvU04RIhKUFFnHSgH/fUdavI+TbfYaAx7af3NujwEFSjZSjht6ERa 4BCmH9R0cWzrDOjvh1woTpaqsNptjpMKxW6Oq1t/LadHIAB3L6lhULV37+VK9xIkBk OoqqpCA9xpzrDJOBLPYZcPzR73WDOTzHwxdh4zmJbPZpV37rGDJrRgBdyA6/o9sx5/ 3y//CJI3l0HmKMIl4HJnMhGKqKvwLHYkhc3HzqBwW9hO14XLeGugLj6WVTCxnW2xBX p7t4zU27pxkZw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cjXhZ5Ytfz4wCw; Fri, 10 Oct 2025 14:45:50 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH v2 2/3] test: Add some missing quoting in exeter runner Date: Fri, 10 Oct 2025 14:45:48 +1100 Message-ID: <20251010034549.1821828-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010034549.1821828-1-david@gibson.dropbear.id.au> References: <20251010034549.1821828-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 5NHX3IIYP6IWIXBGGSYYHS4ASEUDH4IA X-Message-ID-Hash: 5NHX3IIYP6IWIXBGGSYYHS4ASEUDH4IA X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: exeter() quoted ${__testid}, but in some places we use it there's an extra level of shell, which needs another layer of quoting. This breaks if testids include ';', which is quite common in exeter tests created as a composition/pipeline of two functions. Add the required extra quoting. While we're there, improve consistency with other scripts by always using the optional {} around variable names. Signed-off-by: David Gibson --- test/lib/exeter | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/lib/exeter b/test/lib/exeter index 0b361599..7ea084a4 100644 --- a/test/lib/exeter +++ b/test/lib/exeter @@ -47,9 +47,9 @@ exeter() { [ ${CI} -eq 1 ] && video_link "${1}" for __testid in $(${EXETOOL} list -- "${@}"); do - __desc="$(${EXETOOL} desc -- "${@}" -- ${__testid})" + __desc="$(${EXETOOL} desc -- "${@}" -- "${__testid}")" status_test_start "${__desc}" - context_run host "${@}" "${__testid}" && status_test_ok || status_test_fail + context_run host "${*} '${__testid}'" && status_test_ok || status_test_fail done cd .. -- 2.51.0