From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=r/LQXppD; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 34D835A061C for ; Sat, 11 Oct 2025 06:49:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1760158165; bh=0see5dTzKiwVj1msA0MNTbtxjITar0vyUOcFYgZrKjQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r/LQXppDfvA2rBn0yYmsOPziLbU25YXPmJ9+JsStkC11UKE6OWUMrp9s0NYUF67wk dlvILfpesRceY2tV04X7DqliuvXz60M1vTNqkFwizSwVyG3PW4yWEKNYUaF7mbaavp nNct6H7lxYsmp2hTey2C8pg+sErgSW5UM6AvMKsvmnJ5jPB7JLJ5bRCANAUZVjNOcG 21yDWphoauNRef4P09zh0Hxlq3Dn2ga98b0DHTEV6uF1bfovfp/UACzVkpNuxsvqB0 0Ywt2z6X2OS3b0AvhXk/STXwR7lMtWMxp2PMoqkerCbrvNlggTYvhbvPrY7innFXfp ziyFU007QUB2A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ckB3T4vglz4wC6; Sat, 11 Oct 2025 15:49:25 +1100 (AEDT) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 1/8] icmp: Remove vestiges of ICMP timer Date: Sat, 11 Oct 2025 15:48:20 +1100 Message-ID: <20251011044827.862757-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251011044827.862757-1-david@gibson.dropbear.id.au> References: <20251011044827.862757-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: IB27DXJNYQ4ZGTFUW5ZCRSSWVCYKLMUM X-Message-ID-Hash: IB27DXJNYQ4ZGTFUW5ZCRSSWVCYKLMUM X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We no longer have a global ICMP timer (timers for individual flows are handled through the flow timer). We still have an ICMP_TIMER_INTERVAL define, though. Remove it. Signed-off-by: David Gibson --- icmp.h | 2 -- passt.c | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/icmp.h b/icmp.h index d1cecb20..1a0e6205 100644 --- a/icmp.h +++ b/icmp.h @@ -6,8 +6,6 @@ #ifndef ICMP_H #define ICMP_H -#define ICMP_TIMER_INTERVAL 10000 /* ms */ - struct ctx; struct icmp_ping_flow; diff --git a/passt.c b/passt.c index 31fbb75b..b877659e 100644 --- a/passt.c +++ b/passt.c @@ -56,8 +56,7 @@ #define EPOLL_EVENTS 8 -#define TIMER_INTERVAL__ MIN(TCP_TIMER_INTERVAL, UDP_TIMER_INTERVAL) -#define TIMER_INTERVAL_ MIN(TIMER_INTERVAL__, ICMP_TIMER_INTERVAL) +#define TIMER_INTERVAL_ MIN(TCP_TIMER_INTERVAL, UDP_TIMER_INTERVAL) #define TIMER_INTERVAL MIN(TIMER_INTERVAL_, FLOW_TIMER_INTERVAL) char pkt_buf[PKT_BUF_BYTES] __attribute__ ((aligned(PAGE_SIZE))); -- 2.51.0