From: Jon Maloy <jmaloy@redhat.com>
To: sbrivio@redhat.com, dgibson@redhat.com,
david@gibson.dropbear.id.au, jmaloy@redhat.com,
passt-dev@passt.top
Subject: [PATCH v14 00/10] Use true MAC address of LAN local remote hosts
Date: Tue, 14 Oct 2025 22:55:11 -0400 [thread overview]
Message-ID: <20251015025521.1449156-1-jmaloy@redhat.com> (raw)
Bug #120 asks us to use the true MAC addresses of LAN local
remote hosts, since some programs need this information.
These commits introduces this for ARP, NDP, UDP, TCP and
ICMP.
---
v3: Updated according to feedback from Stefano and David:
- Made the ARP/NDP lookup call filter out the requested address
by itself, qualified by the index if the template interface
- Moved the flow specific MAC address from struct flowside to
struct flow_common.
v4: - Updated according to feedback from David and Stefan
- Added a cache table for ARP/NDP table contents
v5: - Updated according to feedback from David and Stefan
- Added cache table entries to FIFO/LRU queue
- New criteria for when to consult ARP/NDP
v6: - Simplified and merged mac cache table commits
- Other changes after feedback from David.
v7: - Fixes in patch #2 based on feedback from David
and Stefano.
v8: - Redesigned netlink and cache table part to be based
on a subscription model.
v8: - Small fix to patch #2 so that we cover the case
when a MAC addess for a host has changed.
- Added a commit where we send a gratuitous ARP/
unsolicitated NA to the guest when a new host is
added to the neighbour cache table.
v10: - Some fixes after feedback from David Gibson
- Reordered: Moved patch #9 to position #3.
- Added synchronization step between ARP/NDP
table contents and the neigbour table at
initialization. This reduces the number of
"false" ARP/NDP replies drastically, but not
completly.
- (Next step could be to scan over the flow table
and update affeced entries when we receive
a MAC address update.)
v11: - Corrected the gratuitous ARP implementation to use
the "ARP Announcement" model instead of the
"Gratuitous ARP reply" model.
v12: - Updated based on feedback from David and Stefano
- Added special handling of default GW and loopback
addresses.
v13: - Updated based on discussion with David and Stefano
- Conceptually moved to only considering guest-side
visible addresss. A lot of things became simpler
and clearer through this change. Thank you, David.
- Introduced a 'permanent' flag in the special
entries representing addessed mapping to own host
and conditionally the guest gw. This flag indicates
those entries cannot be altered by possible remote hosts
shadowed by these addresses. Suggested by Stefano.
- Reordered patch ##4 and 5, since #5 cannot work
correctly for NDP unsolicited NA until #4 is in place.
- Added a new commit #2 to get later access to the flag
no_map_gw. It was wrong to call fwd_neigh_table_init()
from inside conf(), it has to be done in main() after
random_init() and tap_backend_init().
v14: - Some fixes after feedback from David Gibson, notably
- Moved the call to nat_inbound() from fwd.c to netlink.c
- Added RFC quotes to explain the format of ARP announce
messages.
Jon Maloy (10):
netlink: add subscription on changes in NDP/ARP table
passt: add no_map_gw flag to struct ctx
fwd: Add cache table for ARP/NDP contents
arp/ndp: respond with true MAC address of LAN local remote hosts
arp/ndp: send ARP announcement / unsolicited NA when neigbour entry
added
flow: add MAC address of LAN local remote hosts to flow
udp: forward external source MAC address through tap interface
tcp: forward external source MAC address through tap interface
tap: change signature of function tap_push_l2h()
icmp: let icmp use mac address from flowside structure
arp.c | 58 ++++++++++++-
arp.h | 2 +
conf.c | 10 +--
epoll_type.h | 2 +
flow.c | 2 +
flow.h | 2 +
fwd.c | 227 +++++++++++++++++++++++++++++++++++++++++++++++++
fwd.h | 7 ++
icmp.c | 8 +-
inany.c | 1 +
ndp.c | 16 +++-
ndp.h | 1 +
netlink.c | 215 +++++++++++++++++++++++++++++++++++++++++++++-
netlink.h | 4 +
passt.c | 17 ++--
passt.h | 4 +-
pasta.c | 2 +-
tap.c | 24 +++---
tap.h | 7 +-
tcp.c | 20 ++++-
tcp.h | 2 +-
tcp_buf.c | 37 ++++----
tcp_internal.h | 4 +-
tcp_vu.c | 5 +-
udp.c | 57 ++++++++-----
udp.h | 2 +-
util.h | 2 +
27 files changed, 650 insertions(+), 88 deletions(-)
--
2.50.1
next reply other threads:[~2025-10-15 2:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 2:55 Jon Maloy [this message]
2025-10-15 2:55 ` [PATCH v14 01/10] netlink: add subscription on changes in NDP/ARP table Jon Maloy
2025-10-17 2:36 ` David Gibson
2025-10-19 10:07 ` Stefano Brivio
2025-10-20 0:17 ` David Gibson
2025-10-15 2:55 ` [PATCH v14 02/10] passt: add no_map_gw flag to struct ctx Jon Maloy
2025-10-19 10:07 ` Stefano Brivio
2025-10-15 2:55 ` [PATCH v14 03/10] fwd: Add cache table for ARP/NDP contents Jon Maloy
2025-10-17 3:05 ` David Gibson
2025-10-17 18:49 ` Jon Maloy
2025-10-20 0:06 ` David Gibson
2025-10-20 10:00 ` Jon Maloy
2025-10-22 1:20 ` David Gibson
2025-10-19 10:07 ` Stefano Brivio
2025-10-15 2:55 ` [PATCH v14 04/10] arp/ndp: respond with true MAC address of LAN local remote hosts Jon Maloy
2025-10-17 3:06 ` David Gibson
2025-10-15 2:55 ` [PATCH v14 05/10] arp/ndp: send ARP announcement / unsolicited NA when neigbour entry added Jon Maloy
2025-10-17 3:08 ` David Gibson
2025-10-19 10:08 ` Stefano Brivio
2025-10-15 2:55 ` [PATCH v14 06/10] flow: add MAC address of LAN local remote hosts to flow Jon Maloy
2025-10-15 2:55 ` [PATCH v14 07/10] udp: forward external source MAC address through tap interface Jon Maloy
2025-10-15 2:55 ` [PATCH v14 08/10] tcp: " Jon Maloy
2025-10-15 2:55 ` [PATCH v14 09/10] tap: change signature of function tap_push_l2h() Jon Maloy
2025-10-15 2:55 ` [PATCH v14 10/10] icmp: let icmp use mac address from flowside structure Jon Maloy
2025-10-19 10:08 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015025521.1449156-1-jmaloy@redhat.com \
--to=jmaloy@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).