From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Do1Ilu6x; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 46C645A026F for ; Thu, 16 Oct 2025 01:46:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760571989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0XEbw7k8AvZVEWxDzMSvFiounhFj0w6kGrxHXSgVOcQ=; b=Do1Ilu6xX49Yu1anogL0Z6r2O5GENEMQfBveIKdfXfJhEZWVl8O3kRxaCnX7QLQr0LO0q4 Mzfbadi1ZboOM47cgPs13ne3v1IXK8gK+Zf/fuXdYsSiMJWDgI1E7W4OFokUuDGFypeyoH d4AzrAoWqjcDlmOY3VLK0PMK0PHd+DY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-333-QppynISxMQ675S_go3wfjg-1; Wed, 15 Oct 2025 19:46:27 -0400 X-MC-Unique: QppynISxMQ675S_go3wfjg-1 X-Mimecast-MFC-AGG-ID: QppynISxMQ675S_go3wfjg_1760571986 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47105bfcf15so504685e9.2 for ; Wed, 15 Oct 2025 16:46:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760571986; x=1761176786; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0XEbw7k8AvZVEWxDzMSvFiounhFj0w6kGrxHXSgVOcQ=; b=jw73mwgxcHzHGydvrnSQ3YFroIC15eXPGwig7l2UZTaRWybc30RcKTRNZW1uo/y5b2 xftaTiDqEwwnmd4QHj9m4HnHKEpM6iF3dGl/OY1BPRcXekrHWrN7so8oqpbvNGjI5aLI H6DHWYfK2iZk7ngC/8QaQD50EsqFgRqu+4JZv2GDWjRAXHtN1ce7scn1U5TZsn8lCrhH a2jnYVXvOXDsWkD+LWo57sR8XCrtG5zYcGbPMJTWpfF7s+ZVhUNtc4ABKp4dUwe8tpLO ilkyVXuDUKY7qLiJHi3ghFmft3JFd1AmUfz64KT0yyPYvKMEViQiNzhxTEKhbKetdqJz iO2w== X-Gm-Message-State: AOJu0YxDrkn8MIqVrdk1fkpiTPXKXxKoRgq8UsvtFMu8JxfNABFY1aRF eDeBQWJTawNFDVYg6ABaTzS6dxo9uEm5XmROevXiMB+nzUHfKu+QfmM8+xZoRZIf8NgziSHxfSC lOAsmMOvgSpL+9WWvEcBRvgtd+MhZOGOt+lVHQf6t29jzs2xnJAI+Ag== X-Gm-Gg: ASbGncsP4u9MJIOE/TAiFNaEwZFwN8m8sqZ7Qb9cA4c90Ojjic+oF3N/MHpIClKmHR7 QDqfdzEXKQp7nJJ2e7cHfB34H+QgcFPS5t7/OE6DnP4MKHCaCMtY2lVtLvNTubDH8Kgdhn3od+U m7v/AK1dtiOVArWJLEmT+48sbJKAgToBplajk2jrQiqxoEtfl7GxOol2LYqbQ6S5yIFD/Rw+yvu yymLMvKAP9ytKeN4SXUThabRb6veMFMP8zuaAa/R7EOUI/NQQUXulirKVbYZMTyMZdQGbPTieXe 2kbLP/4zc30c0osBB+UG3wCLy3UfxuNqDsJRtJ2pOTIYHitqAGTA8XMd0hzM+Q+G1n90iAOB2Ok XPp/1VOMT75Zlk7anp/M7Ycs2qys= X-Received: by 2002:a05:600d:416b:b0:46e:4922:6855 with SMTP id 5b1f17b1804b1-46fa9a86398mr226620275e9.3.1760571986395; Wed, 15 Oct 2025 16:46:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTxVfpmGesNNIC69cXKBS2e7kqchlxPRorGmNZssuPWNYI+9B+DaIZguR3c/7J3NTPH9lMwQ== X-Received: by 2002:a05:600d:416b:b0:46e:4922:6855 with SMTP id 5b1f17b1804b1-46fa9a86398mr226620195e9.3.1760571985942; Wed, 15 Oct 2025 16:46:25 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4710cb36e7csm5679285e9.2.2025.10.15.16.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Oct 2025 16:46:25 -0700 (PDT) Date: Thu, 16 Oct 2025 01:46:24 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2] tap: Update some function comments for accuracy Message-ID: <20251016014624.4e2e9bc8@elisabeth> In-Reply-To: <20251012234941.1433683-1-david@gibson.dropbear.id.au> References: <20251012234941.1433683-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5vLAFkSNs4JdrgBSs2VU5DOTmw8YHiLq42YZZ7cCHfA_1760571986 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: XOYP3Q6PVFBLHR5EYUP2VTSQPFIIMUZ7 X-Message-ID-Hash: XOYP3Q6PVFBLHR5EYUP2VTSQPFIIMUZ7 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 13 Oct 2025 10:49:41 +1100 David Gibson wrote: > Several of the tap_push_*() functions have doc comments claiming they take > the context pointer, but don't. Some (tap_push_uh[46]) were broken fairly > recently, but others (tap_push_ip[46]h) have been broken for a long time. > > Regardless, fix all the doc comments. > > Reported-by: Stefano Brivio > Fixes: 82a839be9 ("tap: break out building of udp header from tap_udp4_send function") > Fixes: 87e6a4644 ("tap: break out building of udp header from tap_udp6_send function") > Fixes: 2dbc622f5 ("tap: Split tap_ip4_send() into UDP and ICMP variants") > Fixes: 9d8dd8b6f ("tap: Split tap_ip6_send() into UDP and ICMP variants") > > Signed-off-by: David Gibson Applied, with one minor change to tags (I plan to add some stuff, including this bit, to the new CONTRIBUTING.md). For consistency with the Linux kernel, we use SHAs abbreviated to 12 digits there, even though 9-digit abbreviations (produced by default git-publish settings, I guess) are unlikely to ever lead to any conflict for us. Well, that's true at least until the day you all discover https://github.com/not-an-aardvark/lucky-commit, but at that point the number of digits wouldn't make a difference. So, to keep the consistency consistent, I changed those to 12-digit forms and dropped the extra newline (also added by git-publish). If you fancy a script checking that for you, see: https://lore.kernel.org/all/20190220213729.49deb54f@redhat.com/ I pondered about adding that to hooks/, but it feels a bit like overstepping. And I can "fix" those in seconds anyway (I regularly do, I'm just pointing it out on this example as it's rather visible here). -- Stefano