From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AVtwWarJ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 71D7F5A026F for ; Sun, 19 Oct 2025 12:08:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760868488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b8JjW5LPwqzNYZqKtFCJ26WHY7CHmHjuHjN7QtQrSRc=; b=AVtwWarJbVG27QAPdBav8nzF1lgY4fvX+WmfLi6ftxMLaO/p6hvSzZk2o21ukk/+t14rJy QNdhi0QEV3v8jaYeBbhAtjRILhAcyRDMjWlaqXg9saPiKDrnMbIkc9qFI+QJ96GE+/QQSw oHJHRecgPTdntgQr0AIi1yvPL7r3AXU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-fM0BQloqMDeZh7PoyzZatg-1; Sun, 19 Oct 2025 06:08:06 -0400 X-MC-Unique: fM0BQloqMDeZh7PoyzZatg-1 X-Mimecast-MFC-AGG-ID: fM0BQloqMDeZh7PoyzZatg_1760868485 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47107fcb257so50845745e9.0 for ; Sun, 19 Oct 2025 03:08:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760868485; x=1761473285; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=b8JjW5LPwqzNYZqKtFCJ26WHY7CHmHjuHjN7QtQrSRc=; b=lS2JjGW79umC07RM3+U4/AE/TSvX4Qg9syxCmyKFdyycKl8rRsoHHjGoE+9eGudFfJ Ldd8klEFbM0P34EQRsEIPp2J9PRyDjqAqSiizs1FvdSw5a6v3CFF1PRlPDRIHyUWnVB0 1LJ0wCiHqVVOfDlaTDk3GHxyXxBWo/eb0FWAlMqTTE+u0yXxpsIxdmnXasGE6fUTvYG5 UOrW1FIQdcSSyAUL0iaZelF7+zpLCIhW82ADoHqKv6GVIr+JvaRR4R6x+7HikBGLYw3U bac9IcBUpuniZUcpKnWPWdn37HraCQP7zNihWcBLgso/aQxovqP8ADQW1wNOATj+z6oF k7uA== X-Forwarded-Encrypted: i=1; AJvYcCVm0V+mP/oxCd95bZTwgwmQ1I5BAaLvYeGSF2k1zYfMu4KBGTsRxB9+PIM+RudDzvzaxa7TAFX1e2s=@passt.top X-Gm-Message-State: AOJu0Yw2Xh/QhMNHpCqTh2jTNYUTwGInUp/REkh3v1XJyIEPh7yDyfl6 gkdGm9hBDofLvC1qhYQLFoyh3t1sIQqZ/+YmJHQ3am6JrMR2dFQkAJVjipguvYoXKvr9Fy58hqz 5q8F+93YcL4Ln8kzlfALsWN/0cRbs5YB02KuUdXqBAHOACNs9KrTFQQ== X-Gm-Gg: ASbGncstfNW/5Ov1lHFnxIcQ32PGD75ymjMer09yp5QkrwPlvOmzgtDJ1ImWEJhFGBe w5f9eUcm3ZapJYEENmHbw/FG8FWh8zn4EU5OKBctA+VdMQEcZuyijIUAPXelhzy6dLm7FXD13Ja +RwzkAq7Sx+MC6H8RjHO4xMQSCseQvR9dSAP0yQ+toMUp2Uh35SreaXMgU6O3KuqXc4PQtvnzIu YurbUGznBJh9vlavC2NOEBSWlud5WUl2kRG+B6QvRewCNAx4w5VRq+zCGdRdexrb1awcvfBUiG5 fB5rchhWGjUjc9gxIedquoBKBF4DHhvTnApp+OV7u8NH5UDsgGavW/HVWL7iHwlVRNhUeAOh52N e5V/i0KXl2ZCwXiIrzT3S4aqCTCA= X-Received: by 2002:a05:6000:400a:b0:427:492:79e6 with SMTP id ffacd0b85a97d-42704d83d9amr5904755f8f.2.1760868485270; Sun, 19 Oct 2025 03:08:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhteYMCdBG49QDonY0QT4b/1Xr6/eX8LOcGkYfwisMZiuW/287uI7ztF5pnCow/Z2Oom+IPA== X-Received: by 2002:a05:6000:400a:b0:427:492:79e6 with SMTP id ffacd0b85a97d-42704d83d9amr5904739f8f.2.1760868484820; Sun, 19 Oct 2025 03:08:04 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427f00ce586sm9421656f8f.49.2025.10.19.03.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Oct 2025 03:08:04 -0700 (PDT) Date: Sun, 19 Oct 2025 12:08:02 +0200 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v14 05/10] arp/ndp: send ARP announcement / unsolicited NA when neigbour entry added Message-ID: <20251019120802.7557f1e0@elisabeth> In-Reply-To: <20251015025521.1449156-6-jmaloy@redhat.com> References: <20251015025521.1449156-1-jmaloy@redhat.com> <20251015025521.1449156-6-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GMyJDnBKEx8LUqY2PEIoj3nrtDYMNyKSYnSojTsju7E_1760868485 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BALAKYH5U2S7DWIJIIW6R37KUYKYPJBJ X-Message-ID-Hash: BALAKYH5U2S7DWIJIIW6R37KUYKYPJBJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: dgibson@redhat.com, david@gibson.dropbear.id.au, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 14 Oct 2025 22:55:16 -0400 Jon Maloy wrote: > ARP announcements and unsolicited NAs should be handled with caution > because of the risk of malignant users emitting them to disturb > network communication. > > There is however one case we where we know it is legitimate > and safe for us to send out such messages: The one time we switch > from using ctx->own_tap_mac to a MAC address received via the > recently added neigbour subscription function. Later changes to > the MAC address of a host in an existing entry cannot be fully > trusted, so we abstain from doing it in such cases. > > When sending this type of messages, we notice that the guest accepts > the update, but shortly later asks for a confirmation in the form of > a regular ARP/NS request. This is responded to with the new value, > and we have exactly the effect we wanted. > > This commit adds this functionality. > > Signed-off-by: Jon Maloy > > --- > v10: -Made small changes based of feedback from David G. > v11: -Moved from 'Gratuitous ARP reply' model to 'ARP Announcement' > model. > v12: -Excluding loopback and default GW addresses from the ARP/NA > announcement to be sent to the guest > v13: -Filtering out all announcements of our_tap_mac instead of > explicitly comparing a set of IP addresses. > -Changed annc.am.tha in arp_announce() to MAC_ZERO, which is > 'unknown' according to RFC826. > -Renamed ndp_send_unsolicited_na() to ndp_unsolicited_na() > v14: -Added quotes from RFC5227 to explain the format of ARP > announce messages, as suggested by David. > --- > arp.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ > arp.h | 2 ++ > fwd.c | 10 ++++++++++ > ndp.c | 10 ++++++++++ > ndp.h | 1 + > 5 files changed, 73 insertions(+) > > diff --git a/arp.c b/arp.c > index b4a686f..0a89ae3 100644 > --- a/arp.c > +++ b/arp.c > @@ -150,3 +150,53 @@ void arp_send_init_req(const struct ctx *c) > debug("Sending initial ARP request for guest MAC address"); > tap_send_single(c, &req, sizeof(req)); > } > + > +/** > + * arp_announce() - Send an ARP announcement for an IPv4 host > + * @c: Execution context > + * @ip: IPv4 address we announce as owned by @mac > + * @mac: MAC address to advertise for @ip > + */ > +void arp_announce(const struct ctx *c, struct in_addr *ip, > + const unsigned char *mac) > +{ > + char ip_str[INET_ADDRSTRLEN]; > + char mac_str[ETH_ADDRSTRLEN]; > + struct { > + struct ethhdr eh; > + struct arphdr ah; > + struct arpmsg am; > + } __attribute__((__packed__)) annc; I'm not sure if it's universally clear that "annc" refers to an announcement, I might sound dumb but it took me a bit to figure out. Perhaps 'msg' is more vague but actually less confusing. > + > + /* Ethernet header */ > + annc.eh.h_proto = htons(ETH_P_ARP); > + memcpy(annc.eh.h_dest, MAC_BROADCAST, sizeof(annc.eh.h_dest)); > + memcpy(annc.eh.h_source, mac, sizeof(annc.eh.h_source)); > + > + /* ARP header */ > + annc.ah.ar_op = htons(ARPOP_REQUEST); > + annc.ah.ar_hrd = htons(ARPHRD_ETHER); > + annc.ah.ar_pro = htons(ETH_P_IP); > + annc.ah.ar_hln = ETH_ALEN; > + annc.ah.ar_pln = 4; > + > + /* RFC5227, section 2.1.1, about Probe messages: "The client MUST fill > + * in the 'sender hardware address' field of the ARP Request with the > + * hardware address of the interface through which it is sending the > + * packet. [...] The 'target hardware address' field is ignored and > + * SHOULD be set to all zeroes." Nit: an extra newline here would make it obvious that you're referring to two different sections. > + * RFC5227, section 2.3: "An ARP Announcement is identical to the ARP > + * Probe described above, except that now the sender and target IP > + * addresses are both set to the host's newly selected IPv4 address." > + */ > + memcpy(annc.am.sha, mac, sizeof(annc.am.sha)); > + memcpy(annc.am.sip, ip, sizeof(annc.am.sip)); > + memcpy(annc.am.tha, MAC_ZERO, sizeof(annc.am.tha)); > + memcpy(annc.am.tip, ip, sizeof(annc.am.tip)); > + > + inet_ntop(AF_INET, ip, ip_str, sizeof(ip_str)); > + eth_ntop(mac, mac_str, sizeof(mac_str)); > + debug("Announcing ARP for %s / %s", ip_str, mac_str); Strictly speaking, you're not announcing a protocol. You're using a protocol to announce an address. Maybe "ARP announcement for ..."? > + > + tap_send_single(c, &annc, sizeof(annc)); > +} > diff --git a/arp.h b/arp.h > index d5ad0e1..4862e90 100644 > --- a/arp.h > +++ b/arp.h > @@ -22,5 +22,7 @@ struct arpmsg { > > int arp(const struct ctx *c, struct iov_tail *data); > void arp_send_init_req(const struct ctx *c); > +void arp_announce(const struct ctx *c, struct in_addr *ip, > + const unsigned char *mac); > > #endif /* ARP_H */ > diff --git a/fwd.c b/fwd.c > index f70e4fc..df92db8 100644 > --- a/fwd.c > +++ b/fwd.c > @@ -27,6 +27,8 @@ > #include "lineread.h" > #include "flow_table.h" > #include "netlink.h" > +#include "arp.h" > +#include "ndp.h" > > /* Empheral port range: values from RFC 6335 */ > static in_port_t fwd_ephemeral_min = (1 << 15) + (1 << 14); > @@ -140,6 +142,14 @@ void fwd_neigh_table_update(const struct ctx *c, const union inany_addr *addr, > memcpy(&e->addr, addr, sizeof(*addr)); > memcpy(e->mac, mac, ETH_ALEN); > e->permanent = permanent; > + > + if (!memcmp(mac, c->our_tap_mac, ETH_ALEN)) > + return; > + > + if (inany_v4(addr)) > + arp_announce(c, inany_v4(addr), e->mac); > + else > + ndp_unsolicited_na(c, &addr->a6); > } > > /** > diff --git a/ndp.c b/ndp.c > index 7e2ae2a..430d420 100644 > --- a/ndp.c > +++ b/ndp.c > @@ -220,6 +220,16 @@ static void ndp_na(const struct ctx *c, const struct in6_addr *dst, > ndp_send(c, dst, &na, sizeof(na)); > } > > +/** > + * ndp_unsolicited_na() - Send unsolicited NA > + * @c: Execution context > + * @addr: IPv6 address to advertise > + */ > +void ndp_unsolicited_na(const struct ctx *c, const struct in6_addr *addr) > +{ > + ndp_na(c, &in6addr_ll_all_nodes, addr); > +} > + > /** > * ndp_ra() - Send an NDP Router Advertisement (RA) message > * @c: Execution context > diff --git a/ndp.h b/ndp.h > index 781ea86..56b756d 100644 > --- a/ndp.h > +++ b/ndp.h > @@ -12,5 +12,6 @@ int ndp(const struct ctx *c, const struct in6_addr *saddr, > struct iov_tail *data); > void ndp_timer(const struct ctx *c, const struct timespec *now); > void ndp_send_init_req(const struct ctx *c); > +void ndp_unsolicited_na(const struct ctx *c, const struct in6_addr *addr); > > #endif /* NDP_H */ -- Stefano