From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hgV7+PdU; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 441005A061B for ; Sun, 19 Oct 2025 12:08:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760868492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YZQ867e2eJ6hZNryIF297T+y9CBVKGVO7z/JT2XXbXA=; b=hgV7+PdU/V1vygryeaXlcez7lrIMtlexVXQmxr/4tFuneRCzRixregkIJ+0g+RjKFvpKut trB1WOcuDaBZVySsdOi60pbqOprjM50p/9H7l/+mUk6CTGhWc/g94CmwV/1Sf+qg3puwR7 dBPewGpUgZmZbz8tSi/mvh0r2CvDki8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-4Mk2EykHMtSj-amOtqpM-w-1; Sun, 19 Oct 2025 06:08:11 -0400 X-MC-Unique: 4Mk2EykHMtSj-amOtqpM-w-1 X-Mimecast-MFC-AGG-ID: 4Mk2EykHMtSj-amOtqpM-w_1760868490 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-426ec5e9278so4776847f8f.0 for ; Sun, 19 Oct 2025 03:08:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760868489; x=1761473289; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YZQ867e2eJ6hZNryIF297T+y9CBVKGVO7z/JT2XXbXA=; b=BvTQV2EnNZZVhfaKU1+fSwKjGk/8B2AzrwgQb0uvMaicCY30GJaSTOFdQRLlLrXkIW xoJfPSujXVz5x65QZe8PQpFa9RZD63lDDwSqLFyjt6JTFGbJ+VEHVIzmI7RGUrrT6Ulu suHzRs4XJuasTOrNg3FWgO75HVVVEwOHdhxPN0tf9jmpdP25vTw8y84BBdizxk+N3NiQ jtERuXyX0/Vzl5n4M7QNFdKibr8IepNlJZJMeOgA9JED7xcdZZ6D1XSe14HgozcPc4jQ KKfb7wCGjhy9LJYf4tAgujZAee9qQi1wxgjcpCBbVYEpPw+saukL82+bpPmTzlNWsfb6 haQw== X-Forwarded-Encrypted: i=1; AJvYcCXDvU0jyJJsthJUaDK3lHoj0WJ1Q0C3a6FFg+vIYhfXsM7FhLM91aGHZQVdWV+nkhl3fiSYzLH6lv4=@passt.top X-Gm-Message-State: AOJu0Yy1nMrXWnWH8H4j6lfwYMF9SVygk6VgtbwoSWYZBz+Tf7+F6Wxz xmqWcP97/yg6w7SENB2FMU8PvsLEkZK9NdgtkSdZQnKiDJEbzf27eEJMeaL0Gs/cxri0OFrdKxr EuSM55ixKdtugy4VT9SL9Cq0BeGx5TZKc1OrTKQ7SfdI+JUunGcWN0Rzs8Os8Dg== X-Gm-Gg: ASbGncvtdY1ArJE/x+INYBI7KNSA/3DtkkvKIRhdvdFPOZKrHFWOnhLTUe8yOBbllfD E6FHdssg53o7mqaXBsKKWVJHkyB4zwFOIseMnImXUIgXVyjrzxX15OgLSbWsCZsRvFPYBEey/7H rTqvOFiXvquZyG71TTfiYn1RcegbH6eZTj1TjrCFy5mGhVelOkUCPvINMVmZLp1Civ3+vt8V6KD kKXBM1MSpv0JRrEtr0jLLP3eTj+WA2FggTwiMKXMcmsdxFidZrAsbFgkv0QojZtDpOonH6oh1oV Vl0vp9RaGy2jMfGcDL+U5KcyIOf+p4M7AbB2UQZXXLlgGtpovq4yp7rY4MOxlDEUaMZbT2oqoJG +NegxRGjeM+4WY5XrNuQpdYVMPJs= X-Received: by 2002:a05:6000:41f7:b0:427:546:4378 with SMTP id ffacd0b85a97d-42705464602mr7088691f8f.20.1760868489485; Sun, 19 Oct 2025 03:08:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHvXe9J/ezTt/k3FDacPjMf1LuiDs4zvnvi7ae8WTPG3zX+8cdWMESjcdp9wN9H79/ZtJrocw== X-Received: by 2002:a05:6000:41f7:b0:427:546:4378 with SMTP id ffacd0b85a97d-42705464602mr7088678f8f.20.1760868489096; Sun, 19 Oct 2025 03:08:09 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5a0f88sm9191555f8f.7.2025.10.19.03.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Oct 2025 03:08:08 -0700 (PDT) Date: Sun, 19 Oct 2025 12:08:07 +0200 From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v14 10/10] icmp: let icmp use mac address from flowside structure Message-ID: <20251019120807.48df9e96@elisabeth> In-Reply-To: <20251015025521.1449156-11-jmaloy@redhat.com> References: <20251015025521.1449156-1-jmaloy@redhat.com> <20251015025521.1449156-11-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: g6aym3hOvSKmLiGy_r6EK6sGgz2e3Go40DbsFJs8juY_1760868490 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: VG5ABXVCYG2RYDD2BRXC2TT7VLF7V2NH X-Message-ID-Hash: VG5ABXVCYG2RYDD2BRXC2TT7VLF7V2NH X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: dgibson@redhat.com, david@gibson.dropbear.id.au, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 14 Oct 2025 22:55:21 -0400 Jon Maloy wrote: > Even ICMP needs to be updated to use the external MAC address instead > of just the own tap address when applicable. We do that here. > > Signed-off-by: Jon Maloy > Reviewed-by: David Gibson > > --- > v3: - Adapted to the move of external MAC address from struct flowside > to struct flow_common > v4: - Adapted to name changes in previous commits in this series > v5: - Added conditional lookup in ARP/NDP if the flow's tap_omac is > undefined > v6: - Looking up MAC of ICMP generating node in udp_send_tap_icmp4/6() > when available, instead trusting the contents of flow->tap_omac. > v12: - Using MAC_IS_UNDEF() instead of MAC_IS_ZERO() > - Comment update after feedback from Stefano > v13: - No changes > --- > icmp.c | 8 ++++++-- > ndp.c | 2 +- > tap.c | 10 ++++++---- > tap.h | 4 ++-- > udp.c | 12 ++++++++++-- > 5 files changed, 25 insertions(+), 11 deletions(-) > > diff --git a/icmp.c b/icmp.c > index 6dffafb..93b394a 100644 > --- a/icmp.c > +++ b/icmp.c > @@ -125,17 +125,21 @@ void icmp_sock_handler(const struct ctx *c, union epoll_ref ref) > flow_dbg(pingf, "echo reply to tap, ID: %"PRIu16", seq: %"PRIu16, > ini->eport, seq); > > + /* Find if neighbour table has a recorded MAC address */ Nit: "check if", or "find out if", or "find MAC address ...", but "find if" is not really a common way to express this. The rest of the series looks good to me. -- Stefano