From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Yumei Huang <yuhuang@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] Add pyramid style rule to CONTRIBUTING.md
Date: Thu, 23 Oct 2025 04:27:54 +0200 [thread overview]
Message-ID: <20251023042754.6112f428@elisabeth> (raw)
In-Reply-To: <aPl5aoORi2p8QzMm@zatzit>
On Thu, 23 Oct 2025 11:40:10 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Wed, Oct 22, 2025 at 12:30:54PM +0800, Yumei Huang wrote:
> > Also fix the copyright line.
> >
> > Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> > Signed-off-by: Yumei Huang <yuhuang@redhat.com>
>
> Stefano, do we actually encourage that style for any "list of similar
> items"? Or just for local variable declarations?
Just for local variable declarations, thanks for noticing.
I was rather focusing on the fact (https://lwn.net/Articles/758552/)
that it's actually called "Reverse Christmas tree", not pyramid style.
I can't find a convenient reference right now, maybe it's hidden
somewhere in https://lore.kernel.org/netdev/?q=reverse+christmas+tree,
...or maybe it's actually "documented" in checkpatch.pl?
Or prehaps just trust us/me on that, sorry, I know it's not ideal :(
...but I can absolutely guarantee it's called Reverse Christmas tree.
--
Stefano
next prev parent reply other threads:[~2025-10-23 2:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 4:30 Yumei Huang
2025-10-23 0:40 ` David Gibson
2025-10-23 2:27 ` Stefano Brivio [this message]
2025-10-27 3:05 ` Yumei Huang
2025-10-27 6:46 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023042754.6112f428@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).