From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=faibYvQL; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id DD6D85A0619 for ; Thu, 23 Oct 2025 04:28:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761186485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rfFo1z78Byg22zgvJfLcODFdCps1knl7RTgR3Rpv7ww=; b=faibYvQLgwEvJdQePc5v4GPtlWsBFYDDyxyPDl1o4wVzjSBdVC4YnURXbPYXUv/+UGHdwC 5yAfBsfhsml2C/jGs7ECrDZxdrSD0zB6zr8zfaG01wVX3nZOH9sRdCsX1PLUqwPEq5HYqD c9E175xcTQxxLFo2VzSBF4fhEnC3duo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-539--wk3OkZ0Nuy0AgD-_UXlyw-1; Wed, 22 Oct 2025 22:28:04 -0400 X-MC-Unique: -wk3OkZ0Nuy0AgD-_UXlyw-1 X-Mimecast-MFC-AGG-ID: -wk3OkZ0Nuy0AgD-_UXlyw_1761186483 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4721b4f3afbso818435e9.0 for ; Wed, 22 Oct 2025 19:28:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761186483; x=1761791283; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rfFo1z78Byg22zgvJfLcODFdCps1knl7RTgR3Rpv7ww=; b=NWDXe/uGunUM8DNLEGEQaqIAifDIHOwbRTKpx4fdbDpRb2lNB/dtGah1rYBKMC88NK sz/thMJW/L0heUfgA6tQw7k7x9Sm8bcdhU/Ef2R62KM7/qwEDeaKuzv3j7NTKz1hK+x4 bLPbVquNB9TxbIaQ4gUYicIS5Df7pZJ5nUyJG7umQnROKu3/RfXOrJW/Qa3U2k862qLH t1pRpUjrWWlwTjYJRZ25Wg95a5XQL2a7PEHmnIZa+2xaoNopT5aDmBswbw3ODbwL42dN 1mMTaVPfs9IW0habwglS+/O7AO0wm5BZoQal5tC840ZKFJjaV3KNDv7eLjZTMr705jQR p84g== X-Gm-Message-State: AOJu0YzeTJ1Qtq9wdA9+GihAMoR34zd743zXRG9CpjCcailqPvh9NxYp lnIxuqWVrCZpo+Lhisp4JdhLcXSuThCbukC+sfx7DDHRaV5n+/8rPMUvevQ5HNasK2TWejAyGA8 nAbi/Uihvujn2AuNKdzneWk1jtm33bk43xkforZbTSAs4W46yDI5jyg== X-Gm-Gg: ASbGncssfrp8VPXh8uKJJJtaV3kKIu97G4+YpUOfYr49I3BkzrcSVQ3BPHhtOhgiW8c JG8RCU8rqkZkvp7UBaJ90iqflaqeRRTVwB4E9V16WqgPk+jC9QksW7/xv//L+jbyiVV4m618uxy mTrKmK5orQIl2Jg7ZynrZ4zKF+GCaTnPHm/jvwL0UiWzVOyzdBs4GUzJKIClmU3nMrQUwT7kE3i 7EQgX19bPKNDHgHBHWCayYLM7be7hYEiEN3QXQPpk/h8Jisb1DaR+W85M8yZz2bOnyndwplrUfy HoZ9B73Ov+rLqf9BA5APb1Yp92iL7L3oSJUiFq49v+TLtuKX6hRADB/tNa+NBeWVqPJZ5JxvC/H qKsKQXJ+/wA0SHWypN4owmiEprlg= X-Received: by 2002:a05:600c:444d:b0:45b:79fd:cb3d with SMTP id 5b1f17b1804b1-471179202famr158003535e9.36.1761186482914; Wed, 22 Oct 2025 19:28:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJz5jcRkbOgczVfS/4kfMsX7IpQPY4vZPs747gMEvFdShsCwq1VokBHuTp28NVdDQpxfEAOA== X-Received: by 2002:a05:600c:444d:b0:45b:79fd:cb3d with SMTP id 5b1f17b1804b1-471179202famr158003365e9.36.1761186482428; Wed, 22 Oct 2025 19:28:02 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475c4342946sm70233425e9.10.2025.10.22.19.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 19:28:01 -0700 (PDT) Date: Thu, 23 Oct 2025 04:27:54 +0200 From: Stefano Brivio To: David Gibson , Yumei Huang Subject: Re: [PATCH] Add pyramid style rule to CONTRIBUTING.md Message-ID: <20251023042754.6112f428@elisabeth> In-Reply-To: References: <20251022043054.12491-1-yuhuang@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fM7Bt_TtQTLPV6KtXYjSoHoH_ETA6EhxR3HF3sxgB6A_1761186483 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: CJKR6V5CSHH4IIVXHZQVNHFQ3TBPU6DJ X-Message-ID-Hash: CJKR6V5CSHH4IIVXHZQVNHFQ3TBPU6DJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 23 Oct 2025 11:40:10 +1100 David Gibson wrote: > On Wed, Oct 22, 2025 at 12:30:54PM +0800, Yumei Huang wrote: > > Also fix the copyright line. > > > > Suggested-by: Stefano Brivio > > Signed-off-by: Yumei Huang > > Stefano, do we actually encourage that style for any "list of similar > items"? Or just for local variable declarations? Just for local variable declarations, thanks for noticing. I was rather focusing on the fact (https://lwn.net/Articles/758552/) that it's actually called "Reverse Christmas tree", not pyramid style. I can't find a convenient reference right now, maybe it's hidden somewhere in https://lore.kernel.org/netdev/?q=reverse+christmas+tree, ...or maybe it's actually "documented" in checkpatch.pl? Or prehaps just trust us/me on that, sorry, I know it's not ideal :( ...but I can absolutely guarantee it's called Reverse Christmas tree. -- Stefano