From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Jon Maloy <jmaloy@redhat.com>, dgibson@redhat.com, passt-dev@passt.top
Subject: Re: [PATCH v15 2/9] fwd: Add cache table for ARP/NDP contents
Date: Fri, 24 Oct 2025 11:11:43 +0200 [thread overview]
Message-ID: <20251024111143.1ad93bc7@elisabeth> (raw)
In-Reply-To: <aPsT84ceh52Bt8BB@zatzit>
On Fri, 24 Oct 2025 16:51:47 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Thu, Oct 23, 2025 at 09:29:26PM -0400, Jon Maloy wrote:
> > We add a cache table to keep track of the contents of the kernel ARP
> > and NDP tables. The table is fed from the just introduced netlink based
> > neigbour subscription function.
> >
> > Signed-off-by: Jon Maloy <jmaloy@redhat.com>
>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
> > diff --git a/fwd.c b/fwd.c
> > index 250cf56..93d83e3 100644
> > --- a/fwd.c
> > +++ b/fwd.c
> > @@ -26,6 +26,7 @@
> > #include "passt.h"
> > #include "lineread.h"
> > #include "flow_table.h"
> > +#include "netlink.h"
> >
> > /* Empheral port range: values from RFC 6335 */
>
> Not relevant to this review, but just noticed this mispelling of mine.
Misspelling. :)
--
Stefano
next prev parent reply other threads:[~2025-10-24 9:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 1:29 [PATCH v15 0/9] Use true MAC address of LAN local remote hosts Jon Maloy
2025-10-24 1:29 ` [PATCH v15 1/9] netlink: add subscription on changes in NDP/ARP table Jon Maloy
2025-10-24 4:03 ` David Gibson
2025-10-24 8:14 ` Stefano Brivio
2025-10-24 1:29 ` [PATCH v15 2/9] fwd: Add cache table for ARP/NDP contents Jon Maloy
2025-10-24 5:51 ` David Gibson
2025-10-24 9:11 ` Stefano Brivio [this message]
2025-10-24 10:43 ` David Gibson
2025-10-24 1:29 ` [PATCH v15 3/9] arp/ndp: respond with true MAC address of LAN local remote hosts Jon Maloy
2025-10-24 5:52 ` David Gibson
2025-10-24 1:29 ` [PATCH v15 4/9] arp/ndp: send ARP announcement / unsolicited NA when neigbour entry added Jon Maloy
2025-10-24 5:54 ` David Gibson
2025-10-29 12:30 ` Stefano Brivio
2025-10-24 1:29 ` [PATCH v15 5/9] flow: add MAC address of LAN local remote hosts to flow Jon Maloy
2025-10-24 1:29 ` [PATCH v15 6/9] udp: forward external source MAC address through tap interface Jon Maloy
2025-10-24 1:29 ` [PATCH v15 7/9] tcp: " Jon Maloy
2025-10-24 1:29 ` [PATCH v15 8/9] tap: change signature of function tap_push_l2h() Jon Maloy
2025-10-24 1:29 ` [PATCH v15 9/9] icmp: let icmp use mac address from flowside structure Jon Maloy
2025-10-30 12:37 ` [PATCH v15 0/9] Use true MAC address of LAN local remote hosts Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251024111143.1ad93bc7@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).