From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cuPf4Wm2; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id E4A575A0619 for ; Fri, 24 Oct 2025 11:11:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761297110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i3yiNBnYnrS6b5uJ2cazsWOPTV1vZV8uQBxivOJ5wkY=; b=cuPf4Wm2oaA4Y5OJ562bD6Msd2WXxmyaGgV6NwS2CdhejZr1lYzN5eQ5WaYcWnDijM1pik TGe6LZmNbfCkRP4clIBw2NwbTbjHR2SdB2VznHoTM4a41EJRPBGWeHMfW/gLKCdfyuEvnV C0kh38Ynqaz/gKorKbPTXy+vKViAPds= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-362-LDZgNuPFOWq6nLWD160mMw-1; Fri, 24 Oct 2025 05:11:47 -0400 X-MC-Unique: LDZgNuPFOWq6nLWD160mMw-1 X-Mimecast-MFC-AGG-ID: LDZgNuPFOWq6nLWD160mMw_1761297106 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-475c422fd70so10738355e9.2 for ; Fri, 24 Oct 2025 02:11:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761297106; x=1761901906; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=i3yiNBnYnrS6b5uJ2cazsWOPTV1vZV8uQBxivOJ5wkY=; b=BDVbfrMjMMM+3MnB+aZ/997Y2lZ8Irnnz+46OdsL79EFC3kOwZXN7QgujSL4aBAhsz Zp+crMYpv85QnFgaoVKGqklUxD7kNE/+VgBK0osqUya5v5FfnYGd6jL1VzJFH9Ljx4F+ izzj++hQMJ7S8jtt/CJpkxClzuBN46X36Zc/qEI1SEfJg/nMnkP2PEjjRQ59fab4zjlg 3Pf2jshwdm11qyFOvxFAopCfw0uH9Fc4C7qbKqeBWkrowz0d+hwWsih6v2NYfYJJPxw/ f39ggV5eg8/pbJRMdoCABn8lwmVAYGzl073fIgxbBc8d0oXTWNg6ZEx/ITA8D4LFh4/0 XbSw== X-Forwarded-Encrypted: i=1; AJvYcCXzoQWI5hZpWdgLU+OMTTf+/2P+wt5+0wiyjyOQp0C7BmdYIXe+jys84whqkgGPkvDxufTvAdFs6bA=@passt.top X-Gm-Message-State: AOJu0YwBChz0quYgekVNe2cr1f3UuG7y7Vy5QzoyGKYypes7/qp8WGX2 6XJmGRpTSCL8h4C3gWje6uZVjT4C4gRJ0IDE5mF0OdnK4CjfDRmyBrJW+7zpFyR7dX58hHzeQdB mzcMLNN9/hZERnMBSKX9YFAqStJlxZeokeQMKiqVjiMIMU01lSfbrQw== X-Gm-Gg: ASbGncvcm0yL0GXww0hTsULhBRsgBSOL6JYkHazqW19ap5L4rm0TCuG1qIm/Y4JR9Xa 51SONLJH/Q1MOsKoCVe+OCDo6YPnaKQCgNvQZkwcoiciu1QmsGxyK5B/d7ZwqirOh2Ayw/W2DSw Lu/nZ/+69+fm8PWkG4o5ID5Cv78WY6nx/Rv8dXFrBVWBYinn8YdkBukGODu36qOQ1p+AxngBMyZ F414XZuWmGciUcytDBnzRSUkukL7wj9M446LWPK+544GRgJHuBQ6IxPAlpiGkJwjWgUsc2/dnvH PXvvszxfjcW1B2q00afj/meJTflLM3cxneiYzp4xFMHqdoURpsPYvrhiatT2K75OPdnmtC9ll+I OMXCxEvb0KA== X-Received: by 2002:a05:600c:4e93:b0:471:1435:b0ea with SMTP id 5b1f17b1804b1-471179121ffmr167577985e9.24.1761297105895; Fri, 24 Oct 2025 02:11:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyJTfJV0q7y8f895qOtQUzC+okiZhsfFDJsTUVra+iySXa8CmKma0UH9lB167LHxwRx5zZyQ== X-Received: by 2002:a05:600c:4e93:b0:471:1435:b0ea with SMTP id 5b1f17b1804b1-471179121ffmr167577835e9.24.1761297105425; Fri, 24 Oct 2025 02:11:45 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429898cceebsm8284437f8f.37.2025.10.24.02.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Oct 2025 02:11:45 -0700 (PDT) Date: Fri, 24 Oct 2025 11:11:43 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v15 2/9] fwd: Add cache table for ARP/NDP contents Message-ID: <20251024111143.1ad93bc7@elisabeth> In-Reply-To: References: <20251024012933.1933642-1-jmaloy@redhat.com> <20251024012933.1933642-3-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KkFlBozy5YfJTtvD3eU5IeFssLSXjTb6DbkDDe5t3qo_1761297106 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: Q6A2EQM5U67IYO6C25JEHXV5Y3XJEPGF X-Message-ID-Hash: Q6A2EQM5U67IYO6C25JEHXV5Y3XJEPGF X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jon Maloy , dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 24 Oct 2025 16:51:47 +1100 David Gibson wrote: > On Thu, Oct 23, 2025 at 09:29:26PM -0400, Jon Maloy wrote: > > We add a cache table to keep track of the contents of the kernel ARP > > and NDP tables. The table is fed from the just introduced netlink based > > neigbour subscription function. > > > > Signed-off-by: Jon Maloy > > Reviewed-by: David Gibson > > > diff --git a/fwd.c b/fwd.c > > index 250cf56..93d83e3 100644 > > --- a/fwd.c > > +++ b/fwd.c > > @@ -26,6 +26,7 @@ > > #include "passt.h" > > #include "lineread.h" > > #include "flow_table.h" > > +#include "netlink.h" > > > > /* Empheral port range: values from RFC 6335 */ > > Not relevant to this review, but just noticed this mispelling of mine. Misspelling. :) -- Stefano