From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=eRagOaYD; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id B3D325A026F for ; Mon, 27 Oct 2025 07:47:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761547620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ordaOxZj9uaw2vlxmhtsU22ydeOXMlU3qsvgJnF3G3Y=; b=eRagOaYDmem0Oq590YHEcpzh1QgJsAT+3zq+wzeFmzLHCqGdtiPgfaWSxfyAju4uYWNtUY NseUUjTLwjLIaEGYmVzXTw2SQln2ZR/xsAfIzr8LJobY+d9x6wWYenYv0CrwUS+a5+WF0S rLTOG4AKl1Vs/tvMucwm9WPK8WFBOUY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-gmaYC1dHMqmjIW1J3fzEFQ-1; Mon, 27 Oct 2025 02:46:58 -0400 X-MC-Unique: gmaYC1dHMqmjIW1J3fzEFQ-1 X-Mimecast-MFC-AGG-ID: gmaYC1dHMqmjIW1J3fzEFQ_1761547617 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-42855d6875fso3883234f8f.3 for ; Sun, 26 Oct 2025 23:46:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761547617; x=1762152417; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=JhBo9FbnBdxdGyzi4oekNGcuCOgsSY9zW+NTU4IGwJ0=; b=t/TNSVGYoG0al6qA6SZNndIj/rsWa+rnavKjFTOVTRWsez1Dcp7UzAT2IRZzM2MwaZ MlE4IfrdGB9bLtFXbFD0HYR+zJQ6vg+VhXRymfNhOniodkIg63106/EdrUKrK2BTCjS+ XzOhd3n0zjv6EN2O2R93/4klwpRxWcVitvGrJfs7ZdXVLvtUj/SE7+TYWJSn1OsbbU/V IFa0fz2yw7tAqFZbwB9BPcV+nTvhUezyHNF3rJIJQQzak0ktXnqXpP3tuDeV3DacSikM tQPQGSRFLk+0CR/VDZMjR36NGAoCCuykck2AJ0lBC1WQF4YOpQAHdW9b6u6B9GrxQSiO DvQA== X-Forwarded-Encrypted: i=1; AJvYcCUtk728oUFHvpE0as5/B/HpaBM4xVTdLYb+U/ORRnPUSlQ4D4LUZTJ6XPrqjhqdQyb1RwX8euiYoLE=@passt.top X-Gm-Message-State: AOJu0Yy3ckiQBxrAC1cQyn7TU8ycYNGDL/aHYH2GOCeYsS2YF5JlfEjC zE2AOMX+Yx0aAiOK/2K0CW2TzVsQ+rZ1+jatgufDX2oLwED1c6KZJNyS6wNNjL9W7N/k2Q+5cii 28GryPupA034/5ItFIsLxS7rBB6h2BSH8xCwfGM194t7qXXZ7fc4lHA== X-Gm-Gg: ASbGnct0camW8yXH07+X0vjFUQyuWvNvq3/xPqrXaj+3PNUwEXq2asFN81QvxaLnX8I yTKUWNug1A4UxMiQhZIR2J+g5SKIDnbLixtmJiLv02CbGB94cwpGxP/e+LzdkZcs/kAwv5Kv+eW zEFbFP/htLj1RGjJDiy+1KRj+Y/oxo3IDSJuUCUrF5Hy3RYg9Ch2DDEaU7oA+t8yykRXYEh4EqY uWDvvejtnA5PlO+7E99SpNrCUrQmIcFTMxLb+mT8KsjkDSZTEUZYNHAVEuBt16TnZJc7hfv17hl +y7lOlN1+qyyoF8KabXq5PEWK0LMagveLt8nG6CtrfeBrJihvHeEjL50m0S2wiQxPqD21U5LslA nLFzLCpHO354PGv1fAmcpcXAtrxg= X-Received: by 2002:a05:6000:4285:b0:3ea:80ec:855d with SMTP id ffacd0b85a97d-42704d6c57amr24558550f8f.19.1761547616671; Sun, 26 Oct 2025 23:46:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGnkTT/bLecujjm/2BzWorrXCcWK/82ZStx2V+9gZWWdf6j2l5hLl5hnV7wl9oWzN5jQ9P68A== X-Received: by 2002:a05:6000:4285:b0:3ea:80ec:855d with SMTP id ffacd0b85a97d-42704d6c57amr24558532f8f.19.1761547616160; Sun, 26 Oct 2025 23:46:56 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952d4494sm12433034f8f.21.2025.10.26.23.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Oct 2025 23:46:55 -0700 (PDT) Date: Mon, 27 Oct 2025 07:46:51 +0100 From: Stefano Brivio To: Yumei Huang Subject: Re: [PATCH] Add pyramid style rule to CONTRIBUTING.md Message-ID: <20251027074651.25b72af9@elisabeth> In-Reply-To: References: <20251022043054.12491-1-yuhuang@redhat.com> <20251023042754.6112f428@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8C6lT2EY-bGZxsEYEGbMQAF2iHlKsKyUl7qALWFVwyo_1761547617 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: OUFUOW3Z2DHOQAO2NZDQ2VQ64Y3WJYST X-Message-ID-Hash: OUFUOW3Z2DHOQAO2NZDQ2VQ64Y3WJYST X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 27 Oct 2025 11:05:09 +0800 Yumei Huang wrote: > On Thu, Oct 23, 2025 at 10:28=E2=80=AFAM Stefano Brivio wrote: > > > > On Thu, 23 Oct 2025 11:40:10 +1100 > > David Gibson wrote: > > =20 > > > On Wed, Oct 22, 2025 at 12:30:54PM +0800, Yumei Huang wrote: =20 > > > > Also fix the copyright line. > > > > > > > > Suggested-by: Stefano Brivio > > > > Signed-off-by: Yumei Huang =20 > > > > > > Stefano, do we actually encourage that style for any "list of similar > > > items"? Or just for local variable declarations? =20 > > > > Just for local variable declarations, thanks for noticing. > > > > I was rather focusing on the fact (https://lwn.net/Articles/758552/) > > that it's actually called "Reverse Christmas tree", not pyramid style. > > > > I can't find a convenient reference right now, maybe it's hidden > > somewhere in https://lore.kernel.org/netdev/?q=3Dreverse+christmas+tree= , > > ...or maybe it's actually "documented" in checkpatch.pl? =20 >=20 > I found it in Documentation/process/maintainer-kvm-x86.rst as below: >=20 > " > Using reverse fir tree, a.k.a. reverse Christmas tree or reverse XMAS tre= e, for > variable declarations isn't strictly required, though it is still preferr= ed. > " >=20 > I will update the name and make it only for local variable declarations. Ah, thanks. > Do I need to update the reference link as well? The name would be > different from the current pyramids link > (https://hisham.hm/2018/06/16/when-listing-repeated-things-make-pyramids/= ). > Not sure if it would be a little bit confusing if not. The "pyramid" link explains the reason why, it just uses a different name. Maybe we should mention both: the kernel link calls it that way, and the pyramid link explains the rationale why it's used / preferred. --=20 Stefano