From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=gi+98Re+; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 43EF15A026F for ; Mon, 27 Oct 2025 10:07:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761556078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5SABeTUqI45TgUxR73JASlJB5NeR6+Sqy/rb4yslq4g=; b=gi+98Re+Hgo8DM31upUjdDjPrXH3mBCchyjyq4XUbQhFlMzbXKitKvK+4f3ad0OxY77MZ2 DGuVUTwqD2Lju40Qz0fpSntMDsbQeQD4yTFH06vVJhWC+XH/2yj77LEQ5/kRmnUjOwZggP EZJgqaP/n95cdc6fov6L201r/+0q9Vo= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-0d_x1ElzMi2O8yhD9bdqBg-1; Mon, 27 Oct 2025 05:07:56 -0400 X-MC-Unique: 0d_x1ElzMi2O8yhD9bdqBg-1 X-Mimecast-MFC-AGG-ID: 0d_x1ElzMi2O8yhD9bdqBg_1761556076 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0BF0B1956070; Mon, 27 Oct 2025 09:07:55 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.72.112.174]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2231319560AD; Mon, 27 Oct 2025 09:07:51 +0000 (UTC) From: Yumei Huang To: passt-dev@passt.top, sbrivio@redhat.com Subject: [PATCH v2] Add reverse Christmas tree to CONTRIBUTING.md Date: Mon, 27 Oct 2025 17:07:48 +0800 Message-ID: <20251027090748.12307-1-yuhuang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Qn2GGROy9yo43HptEt8iEJcQNa-5vjQda82Fy039I-g_1761556076 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: THNQ4CXXGGMSRW52LNLRMKEDB5OU5EBE X-Message-ID-Hash: THNQ4CXXGGMSRW52LNLRMKEDB5OU5EBE X-MailFrom: yuhuang@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: david@gibson.dropbear.id.au, yuhuang@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Also fix the copyright line. Suggested-by: Stefano Brivio Signed-off-by: Yumei Huang --- CONTRIBUTING.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 75ad2a7..64c191f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,6 @@ @@ -24,6 +24,10 @@ to prepare patches and participate in the email-based review process. * Edit the source code or documentation following the [Linux kernel coding style](https://www.kernel.org/doc/html/latest/process/coding-style.html). + When adding or editing local variable declarations, please use the reverse + Christmas tree as described + [here](https://www.kernel.org/doc/Documentation/process/maintainer-kvm-x86.rst) + and [here](https://hisham.hm/2018/06/16/when-listing-repeated-things-make-pyramids/). * Stage your changes: -- 2.51.0