From: Stefano Brivio <sbrivio@redhat.com>
To: Yumei Huang <yuhuang@redhat.com>
Cc: passt-dev@passt.top, david@gibson.dropbear.id.au
Subject: Re: [PATCH v2] Add reverse Christmas tree to CONTRIBUTING.md
Date: Tue, 28 Oct 2025 01:10:32 +0100 [thread overview]
Message-ID: <20251028011032.3c917c23@elisabeth> (raw)
In-Reply-To: <20251027090748.12307-1-yuhuang@redhat.com>
On Mon, 27 Oct 2025 17:07:48 +0800
Yumei Huang <yuhuang@redhat.com> wrote:
> Also fix the copyright line.
As far as I know, in some jurisdictions, the year *as stated in the
copyright notice* isn't _entirely_ irrelevant, but I don't think we
care about these small details after all.
Both forms are totally fine I think, so it's not something we really
need to fix. It's up to single contributors (and, possibly, where they
live / work).
>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>
> ---
> CONTRIBUTING.md | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> index 75ad2a7..64c191f 100644
> --- a/CONTRIBUTING.md
> +++ b/CONTRIBUTING.md
> @@ -1,6 +1,6 @@
> <!---
> SPDX-License-Identifier: GPL-2.0-or-later
> -Copyright (c) 2025 Red Hat
> +Copyright Red Hat
> Author: Yumei Huang <yuhuang@redhat.com>
> -->
>
> @@ -24,6 +24,10 @@ to prepare patches and participate in the email-based review process.
>
> * Edit the source code or documentation following the
> [Linux kernel coding style](https://www.kernel.org/doc/html/latest/process/coding-style.html).
> + When adding or editing local variable declarations, please use the reverse
> + Christmas tree as described
> + [here](https://www.kernel.org/doc/Documentation/process/maintainer-kvm-x86.rst)
> + and [here](https://hisham.hm/2018/06/16/when-listing-repeated-things-make-pyramids/).
>
> * Stage your changes:
Applied, thanks for following up.
--
Stefano
prev parent reply other threads:[~2025-10-28 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 9:07 Yumei Huang
2025-10-27 22:20 ` David Gibson
2025-10-28 0:10 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028011032.3c917c23@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).