[PATCH v2] Add reverse Christmas tree to CONTRIBUTING.md

[PATCH v2] Add reverse Christmas tree to CONTRIBUTING.md

[Yumei Huang]

Also fix the copyright line.

Suggested-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Yumei Huang <yuhuang@redhat.com>
---
 CONTRIBUTING.md | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 75ad2a7..64c191f 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -1,6 +1,6 @@
 <!---
 SPDX-License-Identifier: GPL-2.0-or-later
-Copyright (c) 2025 Red Hat
+Copyright Red Hat
 Author: Yumei Huang <yuhuang@redhat.com>
 -->
 
@@ -24,6 +24,10 @@ to prepare patches and participate in the email-based review process.
 
 * Edit the source code or documentation following the
   [Linux kernel coding style](https://www.kernel.org/doc/html/latest/process/coding-style.html).
+  When adding or editing local variable declarations, please use the reverse
+  Christmas tree as described
+  [here](https://www.kernel.org/doc/Documentation/process/maintainer-kvm-x86.rst)
+  and [here](https://hisham.hm/2018/06/16/when-listing-repeated-things-make-pyramids/).
 
 * Stage your changes:
 
-- 
2.51.0

Re: [PATCH v2] Add reverse Christmas tree to CONTRIBUTING.md

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

On Mon, Oct 27, 2025 at 05:07:48PM +0800, Yumei Huang wrote:
> Also fix the copyright line.
> 
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  CONTRIBUTING.md | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> index 75ad2a7..64c191f 100644
> --- a/CONTRIBUTING.md
> +++ b/CONTRIBUTING.md
> @@ -1,6 +1,6 @@
>  <!---
>  SPDX-License-Identifier: GPL-2.0-or-later
> -Copyright (c) 2025 Red Hat
> +Copyright Red Hat
>  Author: Yumei Huang <yuhuang@redhat.com>
>  -->
>  
> @@ -24,6 +24,10 @@ to prepare patches and participate in the email-based review process.
>  
>  * Edit the source code or documentation following the
>    [Linux kernel coding style](https://www.kernel.org/doc/html/latest/process/coding-style.html).
> +  When adding or editing local variable declarations, please use the reverse
> +  Christmas tree as described
> +  [here](https://www.kernel.org/doc/Documentation/process/maintainer-kvm-x86.rst)
> +  and [here](https://hisham.hm/2018/06/16/when-listing-repeated-things-make-pyramids/).
>  
>  * Stage your changes:
>  
> -- 
> 2.51.0
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2] Add reverse Christmas tree to CONTRIBUTING.md

[Stefano Brivio]

On Mon, 27 Oct 2025 17:07:48 +0800
Yumei Huang <yuhuang@redhat.com> wrote:

> Also fix the copyright line.

As far as I know, in some jurisdictions, the year *as stated in the
copyright notice* isn't _entirely_ irrelevant, but I don't think we
care about these small details after all.

Both forms are totally fine I think, so it's not something we really
need to fix. It's up to single contributors (and, possibly, where they
live / work).

> 
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>
> ---
>  CONTRIBUTING.md | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> index 75ad2a7..64c191f 100644
> --- a/CONTRIBUTING.md
> +++ b/CONTRIBUTING.md
> @@ -1,6 +1,6 @@
>  <!---
>  SPDX-License-Identifier: GPL-2.0-or-later
> -Copyright (c) 2025 Red Hat
> +Copyright Red Hat
>  Author: Yumei Huang <yuhuang@redhat.com>
>  -->  
>  
> @@ -24,6 +24,10 @@ to prepare patches and participate in the email-based review process.
>  
>  * Edit the source code or documentation following the
>    [Linux kernel coding style](https://www.kernel.org/doc/html/latest/process/coding-style.html).
> +  When adding or editing local variable declarations, please use the reverse
> +  Christmas tree as described
> +  [here](https://www.kernel.org/doc/Documentation/process/maintainer-kvm-x86.rst)
> +  and [here](https://hisham.hm/2018/06/16/when-listing-repeated-things-make-pyramids/).
>  
>  * Stage your changes:

Applied, thanks for following up.

-- 
Stefano