From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NlFdeXwy; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 5F6F45A026F for ; Tue, 28 Oct 2025 01:10:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761610237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WJ0OKnCEaQEVikgLR716wtZEhqUx9O72gEgp8NPKseY=; b=NlFdeXwyLG9xBYAmz83BAu83j+vOEZZaHDI9h6JJmHzMvmsfLybHSZ5jnnKz/bB2xCJeFD ffSyggKvG289M7n1rRfGXV5m4b9SOu93455A+xv3PKLyU9CTnvoZPoASNrHdsxWSTRESgj IO9b1+vTUQBOb7GwrVAHSvR9oZIkhBc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-NeSMWL3-OQ2Y7Qmz0O1F_A-1; Mon, 27 Oct 2025 20:10:35 -0400 X-MC-Unique: NeSMWL3-OQ2Y7Qmz0O1F_A-1 X-Mimecast-MFC-AGG-ID: NeSMWL3-OQ2Y7Qmz0O1F_A_1761610234 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-475dca91610so13267825e9.3 for ; Mon, 27 Oct 2025 17:10:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761610234; x=1762215034; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WJ0OKnCEaQEVikgLR716wtZEhqUx9O72gEgp8NPKseY=; b=FDbmpz2+xqGnu0nTyf0pjIr/+mviofGCO4rUUxfbp/wCroXHcTp+VwbxpCNsljLUxX V7Y/j/qnQ4uP/T2gOWS1hzLxPl2ID0s9LV0vsmKWI01/sCkqZJaN3UF2lLpAGt41J8o8 fmG7zGhxXVaE/5t21t+XelESJ+6NuYzKqkVLLmnGi+UlWLaJYmyw8AFTux81X1bwyMB8 Ym+Z84PBEqFXYvEax+rKGp8vYwfaEBNEyW1A2xPT+tY5Ws+5AH+9YK7TExz1Py02M5od /fD3CSM6asYdp5P6n1YtNeHxiiBhR8l7moRkTX2hHUzvXIWvJIcpQiePcTQkpDLT0f/u B0tQ== X-Gm-Message-State: AOJu0YzabjtgSnlEhYBFrMil88ATYUhsrFwLpISXekaLXNsXHwD+m0RP paPAxW76jeby8ZB0EMiIcTUUpqSxY57nQDYyAFcoz0xi7kw5zFT+WsT7Yz4Atg4NawiWepZ2X7B D4L7ljQxCkStV15Qot0NUoGjDkpdC3usGOyTT6UOIe55KbQsj0gOTusRWFBb+xQ== X-Gm-Gg: ASbGncsJHjDFLIn8uzIRDzC0wa7avmaI0FAMIqhUuxPMfqHhdpNj0dsfM2Ac8gsU/jv iogYFWdXBkwsATfVfMuNW9yXxK94SsVRWqloBErsXqp+o35hdC9gLLvfwncEuSoItt3PiRdpkaW ZEq/yb9YMwSXN/TuiAP2cKrunY67aZHWiOR6SU/DTOUgOEJXyr8fM9foayjlsXeShMfw8Be0DMM FCnR9YREXq5WXbh9j6CYJAeNJ6TS8DEmM7+tGrVn1eGkspp7oQqmOiNu79sTUO9LgNh5L/jWOUu 2jQJdGXhpdc/J5ERU7Ca5xO+Bd9RBcrzW3WU/e4oQoG+jQHsaSdl4ENV4df18TeVuyS5FozprX0 Bx0C1AX02qrYNcHA8vWJmwRuloOY= X-Received: by 2002:a05:600c:83c3:b0:475:de68:3c30 with SMTP id 5b1f17b1804b1-47717dfaa4bmr10203995e9.16.1761610234031; Mon, 27 Oct 2025 17:10:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFALckRJwBCCYGZarbAstmxIDudqMVjb71c1oMz3zqonPigweyChEdXLuakuYlrHEI1d//tvw== X-Received: by 2002:a05:600c:83c3:b0:475:de68:3c30 with SMTP id 5b1f17b1804b1-47717dfaa4bmr10203865e9.16.1761610233604; Mon, 27 Oct 2025 17:10:33 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475dd477c92sm161603415e9.2.2025.10.27.17.10.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 17:10:33 -0700 (PDT) Date: Tue, 28 Oct 2025 01:10:32 +0100 From: Stefano Brivio To: Yumei Huang Subject: Re: [PATCH v2] Add reverse Christmas tree to CONTRIBUTING.md Message-ID: <20251028011032.3c917c23@elisabeth> In-Reply-To: <20251027090748.12307-1-yuhuang@redhat.com> References: <20251027090748.12307-1-yuhuang@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ztY8uVqjctS50ZNTS8A_Tfgd955G-tvTfsn-KbSDSmo_1761610234 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7Q6NGSFQYPXU5XWQQJAE3PJO6RYJF7EP X-Message-ID-Hash: 7Q6NGSFQYPXU5XWQQJAE3PJO6RYJF7EP X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 27 Oct 2025 17:07:48 +0800 Yumei Huang wrote: > Also fix the copyright line. As far as I know, in some jurisdictions, the year *as stated in the copyright notice* isn't _entirely_ irrelevant, but I don't think we care about these small details after all. Both forms are totally fine I think, so it's not something we really need to fix. It's up to single contributors (and, possibly, where they live / work). > > Suggested-by: Stefano Brivio > Signed-off-by: Yumei Huang > --- > CONTRIBUTING.md | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md > index 75ad2a7..64c191f 100644 > --- a/CONTRIBUTING.md > +++ b/CONTRIBUTING.md > @@ -1,6 +1,6 @@ > > > @@ -24,6 +24,10 @@ to prepare patches and participate in the email-based review process. > > * Edit the source code or documentation following the > [Linux kernel coding style](https://www.kernel.org/doc/html/latest/process/coding-style.html). > + When adding or editing local variable declarations, please use the reverse > + Christmas tree as described > + [here](https://www.kernel.org/doc/Documentation/process/maintainer-kvm-x86.rst) > + and [here](https://hisham.hm/2018/06/16/when-listing-repeated-things-make-pyramids/). > > * Stage your changes: Applied, thanks for following up. -- Stefano