From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IY6tooLQ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 961FF5A0619 for ; Wed, 29 Oct 2025 00:13:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761693200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=goNoxkwIwEYpfK/5EUF01ZQ0n8y2BDS02ZJ1QT29enE=; b=IY6tooLQJbhTM9NqpRpNJmIMZvN87NN9Dgt9NI7h50xEp/Li6YZF/WQ5cwjXud7Ga5da4P 5XwcsqIftqEUG16wZcpw7DjKcJaX7Uns4T0WdLoYa2TfJJm5JJFIDodBan808pHnw3QmJ5 LOj3itA2vAxstoYSBmnXB+gCKaH1lfw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-PFv7o83lOQ2hU1NF-5El4Q-1; Tue, 28 Oct 2025 19:13:19 -0400 X-MC-Unique: PFv7o83lOQ2hU1NF-5El4Q-1 X-Mimecast-MFC-AGG-ID: PFv7o83lOQ2hU1NF-5El4Q_1761693198 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4771e696e76so2367335e9.0 for ; Tue, 28 Oct 2025 16:13:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761693197; x=1762297997; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=goNoxkwIwEYpfK/5EUF01ZQ0n8y2BDS02ZJ1QT29enE=; b=Uj6t4DDWRrK3oQXrbsyuBLf/gWDNL2l91ywEeruc2ghZgNseOdL/ayRy8dCBH4wrF9 g+yEkDKr4S4dHEp4bHiDKwYwlxlgO997xSwoliqd+jvK1zISxX/9n7Ly8J1HDLjuihdw xl8ZurN7F+Tngj6tpFArOshyDoPBuIPKtH4iq4uNAXEvaAo9gUt0HNldCvPA/7pcL/GT KXsUpa+tB302maRidyZktOKJa0N4sUpBsxKYZshmRbI5WTlFIC78zf9SwYEtY32kHJdI 7w5+QCKiScBSCu0LN9+pVAGjMZ8aS9uYQNsYhQGvcmCBqSirFt273wV8/6cBuhu/a7Jq XFow== X-Gm-Message-State: AOJu0YyZxnAr9tpf2oR1uqmumEF48uAx5kDmB1pKpKkoz5XsKWfFshFc SWNP7PfxcwCUCJ1cbUEgBhx2jjrMCM9tQ+CXVbfSRUvdyYFivkBDwmQyYReROqEjgvhypiidwT6 dN5GRTnUHJfo2oK6TclHE8j51BcsMj8TKGUDV1Q6QmySU6z2/5VshbIB1Pf+Taw== X-Gm-Gg: ASbGncsEuEKOpeWEJBy/wksIU7I/a9kI9pqK2X9qAtpNjylO5MoI7XTxWFnhVhpABPM uQ5cJJMZ0JZAGi7guhA2cXFtDYl7GsWWgcudZ8xnc4cGkdiWxacUhwRukuNLRNoPzXHRfA/bAU+ ni9YoEdSNJFJlLQyMvjrTHaXJBtmfwTfV7kZpcippi0ooULihgjGl8ffNw4YDeUZPzv2AAM2nEL oacV4JWedrpSdSFQSt7z56GQIjBj1aKtW9Z9RNJCZnn1cJciurWdlhZv5LJ/wLcXg2E3QbB6Wl5 j7DTeVD8/fEqSgHg5Xv3F/3wLxRgTiaayJG9M8+Q0t1T0vBr6h1K2OWOL+OYAtQ2rIoPf2rlvrq ZSFfUVegmWw== X-Received: by 2002:a05:600c:37c8:b0:475:dc85:4667 with SMTP id 5b1f17b1804b1-4771e182102mr8600155e9.15.1761693197386; Tue, 28 Oct 2025 16:13:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEVILnWEX9UWgrMbFa++himZXcYl937Mvj87Hye2ArqTrSEELMA7AgBauyRBQ1xeXAyAp55gw== X-Received: by 2002:a05:600c:37c8:b0:475:dc85:4667 with SMTP id 5b1f17b1804b1-4771e182102mr8600025e9.15.1761693196952; Tue, 28 Oct 2025 16:13:16 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4771e202182sm16157625e9.10.2025.10.28.16.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Oct 2025 16:13:16 -0700 (PDT) Date: Wed, 29 Oct 2025 00:13:14 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2] tap: Update some function comments for accuracy Message-ID: <20251029001314.1abb8993@elisabeth> In-Reply-To: References: <20251012234941.1433683-1-david@gibson.dropbear.id.au> <20251016014624.4e2e9bc8@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GoWL--_QwcGu6_T-xzI9dBAm-lCkd6v--alYzUmb4ZE_1761693198 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 73QXODNCJKC75PP75BVPRMMACQDGOK6J X-Message-ID-Hash: 73QXODNCJKC75PP75BVPRMMACQDGOK6J X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 16 Oct 2025 11:47:22 +1100 David Gibson wrote: > On Thu, Oct 16, 2025 at 01:46:24AM +0200, Stefano Brivio wrote: > > On Mon, 13 Oct 2025 10:49:41 +1100 > > David Gibson wrote: > > > > > Several of the tap_push_*() functions have doc comments claiming they take > > > the context pointer, but don't. Some (tap_push_uh[46]) were broken fairly > > > recently, but others (tap_push_ip[46]h) have been broken for a long time. > > > > > > Regardless, fix all the doc comments. > > > > > > Reported-by: Stefano Brivio > > > Fixes: 82a839be9 ("tap: break out building of udp header from tap_udp4_send function") > > > Fixes: 87e6a4644 ("tap: break out building of udp header from tap_udp6_send function") > > > Fixes: 2dbc622f5 ("tap: Split tap_ip4_send() into UDP and ICMP variants") > > > Fixes: 9d8dd8b6f ("tap: Split tap_ip6_send() into UDP and ICMP variants") > > > > > > Signed-off-by: David Gibson > > > > Applied, with one minor change to tags (I plan to add some stuff, > > including this bit, to the new CONTRIBUTING.md). > > > > For consistency with the Linux kernel, we use SHAs abbreviated to 12 > > digits there, even though 9-digit abbreviations (produced by default > > git-publish settings, I guess) > > No, git-publish doesn't manage Fixes tags. It is the default for git > blame, though, which is where I would have copied them from > > > are unlikely to ever lead to any > > conflict for us. > > > > Well, that's true at least until the day you all discover > > https://github.com/not-an-aardvark/lucky-commit, but at that point the > > number of digits wouldn't make a difference. > > > > So, to keep the consistency consistent, I changed those to 12-digit > > forms and dropped the extra newline (also added by git-publish). If > > you fancy a script checking that for you, see: > > > > https://lore.kernel.org/all/20190220213729.49deb54f@redhat.com/ > > Thanks, I've put that into my local hooks. Thanks. By the way, there's still the occasional blank line before Signed-off-tag: in your patches, which I'm fairly sure comes from git-publish. Maybe it would be good to propose a patch for some kind of "Linux kernel mode" for git-publish omitting that extra line, and probably a couple of other tweaks? I don't remember what the other differences (compared to QEMU) were. It takes me less than a second to drop that line on merge though, so it's definitely not an issue. -- Stefano