From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NsQvPim9; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id D5C1B5A0619 for ; Wed, 29 Oct 2025 05:38:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761712691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dfadRMZO1pzvRawRJep+HtS6JfyleURb/4uwd1jOZgg=; b=NsQvPim9FyXc0WZFozb/x1KF0oYPV5LsHS18H71ub2gF0LV0K9EXP5HhfbgWTOQohCUHwX 9b6/gPxkSSzVCoURMZkS7e6MBaeJl5zEHfp14SGXAgFuycYymSSaSv9y5aQd2P7LKCVi9X 7+rkBy+xPDQtF6SW9g0rB0dYX9Y9sJU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-hYTkQSg7PiGLx_vPOXznqQ-1; Wed, 29 Oct 2025 00:38:09 -0400 X-MC-Unique: hYTkQSg7PiGLx_vPOXznqQ-1 X-Mimecast-MFC-AGG-ID: hYTkQSg7PiGLx_vPOXznqQ_1761712688 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-475dca91610so19293645e9.3 for ; Tue, 28 Oct 2025 21:38:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761712688; x=1762317488; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=eMuTjlXQWtqyOWRXGhHAiBlegQ998rtHtezKUZ7uS1c=; b=PAp6M/Stbf6VFAm5kGibqclk0ADaw58LuS7ITVgge8aJoH0ukw/vFqknNw/ZUtutkO qbVI8Rdv2Wl/YMBUr+it3DEvB+C6kAOFtQ3GP2QtcH8H+20YtdLNC5uLEjFIzQaVcuOw nc3NFdS+uf89KCvQGxYZgVj+PR/0jkkknAfKHAvf7QmBCeXZl6aSc2Q8RJDIYL28OiZ4 8WkwWD901WTG7fHbUFXyrCkll0MHN8FFqVqeu1goaGWUr2MQPsjWBe+fTGG3+W9UqNrh IKOs1Jn0mJWWvr3syd7ZjX+EsyOtGnzcyq+BjoLCVSFfJLAvigHNJ5ztStRo9oyavYSr 2Wtw== X-Gm-Message-State: AOJu0YzHG4S8XD2OCfB+bqyW8d2R2QwV+DdxjXnZMiDy1Y56ifEZpxT2 p52+pRxJEVsRw00h+wLDCTujJtKdbH+7cMOh63l2K/Oht/8uK3QNB2e4m7U7dXp9IN0r73IKRUt DvLHuCHEblfamttlyFYz+r9KVh5wOEjMye+NkwBMyCj2eU7QbkfDcww== X-Gm-Gg: ASbGncuAmB4KZmerP9Nv6QTLDpf6c9Ls/wWWmrMEC2CcC8UZaPb6IWcj/33EocenqED RUCfMm1SH5TNpYqmDEGvRppM8W5cAj+EoHcp7o0Gzp2V8Q45/ja8U8SymcisuwDOIfhGNKvVhVU vRyL7iYQNzp1y1US/p2P0JExT8gFjZlKgKYc1GE4VDCl5ZlO0Lk52cVb7tW6KJ9EXbMZGRpWJuY 3DLY+vJbGmDYUcoRtBGvLYI3SHFoPV0VMSBinAJXvd/lVDHHjQPiazDbqT7g+uVhw7lsjKZj/zQ vxrWyFpUto0D52modruzxQ5dTKENf23wYD6Y346eWEXubkaq43oDhjI/2yLWO5q5NkDlhTKc9Tx o22Nb+kxBew== X-Received: by 2002:a5d:5887:0:b0:427:7cd:7b1d with SMTP id ffacd0b85a97d-429aefbdf10mr1017935f8f.40.1761712687903; Tue, 28 Oct 2025 21:38:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHWzhxhlmntMA3l4FcRm7UjJvfaPkIHxf0G5OllNYD9xTZersXScVe1FHQ+rogOtd8fOSvrNw== X-Received: by 2002:a5d:5887:0:b0:427:7cd:7b1d with SMTP id ffacd0b85a97d-429aefbdf10mr1017917f8f.40.1761712687341; Tue, 28 Oct 2025 21:38:07 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952cbb2bsm24336033f8f.13.2025.10.28.21.38.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Oct 2025 21:38:06 -0700 (PDT) Date: Wed, 29 Oct 2025 05:38:04 +0100 From: Stefano Brivio To: Yumei Huang Subject: Re: [PATCH v6 4/4] tcp: Update data retransmission timeout Message-ID: <20251029053804.711716aa@elisabeth> In-Reply-To: References: <20251017062838.21041-1-yuhuang@redhat.com> <20251017062838.21041-5-yuhuang@redhat.com> <20251024010438.16e19757@elisabeth> <20251028124426.534fd236@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OsxSq_2BPBdyNqkQKzrvWwEugXclA_6yyE7OZl9EOBY_1761712688 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ICUVN5MYSZ3CEVPPBA4EZPENOFW7LVXT X-Message-ID-Hash: ICUVN5MYSZ3CEVPPBA4EZPENOFW7LVXT X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, david@gibson.dropbear.id.au X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 29 Oct 2025 11:06:44 +0800 Yumei Huang wrote: > On Tue, Oct 28, 2025 at 7:44=E2=80=AFPM Stefano Brivio wrote: > > > > On Tue, 28 Oct 2025 16:09:03 +0800 > > Yumei Huang wrote: > > =20 > > > On Fri, Oct 24, 2025 at 7:04=E2=80=AFAM Stefano Brivio wrote: =20 > > > > > > > > On Fri, 17 Oct 2025 14:28:38 +0800 > > > > Yumei Huang wrote: > > > > =20 > > > > > Use an exponential backoff timeout for data retransmission accord= ing > > > > > to RFC 2988 and RFC 6298. Set the initial RTO to one second as di= scussed > > > > > in Appendix A of RFC 6298. > > > > > > > > > > Also combine the macros defining the initial RTO for both SYN and= ACK. > > > > > > > > > > Signed-off-by: Yumei Huang > > > > > Reviewed-by: David Gibson > > > > > --- > > > > > tcp.c | 27 ++++++++++++--------------- > > > > > 1 file changed, 12 insertions(+), 15 deletions(-) > > > > > > > > > > diff --git a/tcp.c b/tcp.c > > > > > index 9385132..dc0ec6c 100644 > > > > > --- a/tcp.c > > > > > +++ b/tcp.c > > > > > @@ -179,16 +179,14 @@ > > > > > * > > > > > * Timeouts are implemented by means of timerfd timers, set base= d on flags: > > > > > * > > > > > - * - SYN_TIMEOUT_INIT: if no ACK is received from tap/guest duri= ng handshake > > > > > - * (flag ACK_FROM_TAP_DUE without ESTABLISHED event) within th= is time, resend > > > > > - * SYN. It's the starting timeout for the first SYN retry. If = this persists > > > > > - * for more than TCP_MAX_RETRIES or (tcp_syn_retries + > > > > > - * tcp_syn_linear_timeouts) times in a row, reset the connecti= on > > > > > - * > > > > > - * - ACK_TIMEOUT: if no ACK segment was received from tap/guest,= after sending > > > > > - * data (flag ACK_FROM_TAP_DUE with ESTABLISHED event), re-sen= d data from the > > > > > - * socket and reset sequence to what was acknowledged. If this= persists for > > > > > - * more than TCP_MAX_RETRIES times in a row, reset the connect= ion > > > > > + * - RTO_INIT: if no ACK segment was received from tap/guest, ei= ther during > > > > > + * handshake (flag ACK_FROM_TAP_DUE without ESTABLISHED event)= or after > > > > > + * sending data (flag ACK_FROM_TAP_DUE with ESTABLISHED event)= , re-send data > > > > > + * from the socket and reset sequence to what was acknowledged= . This is the > > > > > + * timeout for the first retry, in seconds. If this persists t= oo many times > > > > > + * in a row, reset the connection: TCP_MAX_RETRIES for establi= shed > > > > > + * connections, or (tcp_syn_retries + tcp_syn_linear_timeouts)= during the > > > > > + * handshake. > > > > > * > > > > > * - FIN_TIMEOUT: if a FIN segment was sent to tap/guest (flag A= CK_FROM_TAP_DUE > > > > > * with TAP_FIN_SENT event), and no ACK is received within thi= s time, reset > > > > > @@ -342,8 +340,7 @@ enum { > > > > > #define WINDOW_DEFAULT 14600 /* = RFC 6928 */ > > > > > > > > > > #define ACK_INTERVAL 10 /* ms */ > > > > > -#define SYN_TIMEOUT_INIT 1 /* s */ > > > > > -#define ACK_TIMEOUT 2 > > > > > +#define RTO_INIT 1 /* s, RFC 6= 298 */ > > > > > #define FIN_TIMEOUT 60 > > > > > #define ACT_TIMEOUT 7200 > > > > > > > > > > @@ -588,13 +585,13 @@ static void tcp_timer_ctl(const struct ctx = *c, struct tcp_tap_conn *conn) > > > > > } else if (conn->flags & ACK_FROM_TAP_DUE) { > > > > > if (!(conn->events & ESTABLISHED)) { > > > > > if (conn->retries < c->tcp.syn_linear_timeo= uts) > > > > > - it.it_value.tv_sec =3D SYN_TIMEOUT_= INIT; > > > > > + it.it_value.tv_sec =3D RTO_INIT; > > > > > else > > > > > - it.it_value.tv_sec =3D SYN_TIMEOUT_= INIT << > > > > > + it.it_value.tv_sec =3D RTO_INIT << > > > > > (conn->retries - c->tcp.syn= _linear_timeouts); > > > > > } > > > > > else > > > > > - it.it_value.tv_sec =3D ACK_TIMEOUT; > > > > > + it.it_value.tv_sec =3D RTO_INIT << conn->re= tries; =20 > > > > > > > > Same as on 3/4, but here it's clearly more convenient: just assign > > > > RTO_INIT, and multiply as needed in the if / else clauses. =20 > > > > > > I guess we can't just assign RTO_INIT. Maybe assign it only when > > > retries=3D=3D0, otherwise multiply as it.it_value.tv_sec <<=3D1. =20 > > > > Why can't you do that? Say: > > > > it.it_value.tv_sec =3D RTO_INIT > > if (!(conn->events & ESTABLISHED)) { > > if (conn->retries >=3D c->tcp.syn_linear_timeouts) > > it.it_value.tv_sec <<=3D (conn->retries - > > c->tcp.syn_linear_timeo= uts); > > > > but anyway, see below. > > =20 > > > But it seems more complicated. What do you think? =20 > > > > Or maybe, building on my latest comment to 3/4: > > > > int factor =3D conn->retries; > > > > if (!(conn->events & ESTABLISHED)) > > factor -=3D c->tcp.syn_linear_timeouts; > > > > it.it_value.tv_sec =3D RTO_INIT << MAX(factor, 0); > > > > ? =20 >=20 > Yeah, I understand this part now. >=20 > > =20 > > > > =20 > > > > > } else if (CONN_HAS(conn, SOCK_FIN_SENT | TAP_FIN_ACKED)) { > > > > > it.it_value.tv_sec =3D FIN_TIMEOUT; > > > > > } else { =20 > > > > > > > > The rest of the series looks good to me. > > > > > > > > It might be slightly more practical to factor in directly the RTO > > > > clamp, and I don't think it's complicated now that you have the hel= per > > > > from 2/4, but it's not a strong preference from my side, as the ser= ies > > > > makes sense in any case. =20 > > > > > > Reading tcp_rto_max_ms can be easy with the helper. My concern is > > > about the way we get the total time for retries. > > > > > > I used to do it like this in v2, > > > https://archives.passt.top/passt-dev/20251010074700.22177-4-yuhuang@r= edhat.com/: > > > > > > +#define RETRY_ELAPSED(timeout_init, retries) \ > > > + ((timeout_init) * ((1 << ((retries) + 1)) - 2)) > > > > > > Though the formula is not quite right, we could refine it as below: > > > > > > #define RETRY_ELAPSED(retries) ((RTO_INIT) * ((1 << ((retries) + 1)) = - 1)) > > > > > > Does it make sense to get the time this way? =20 > > > > Well, it also depends on c->tcp.syn_linear_timeouts, right? =20 >=20 > Not really, it's only used for data retransmission, so > syn_linear_timeouts is not relevant. Hmm, no, why? RFC 6298 covers SYN retries as well, and that's the one stating: (2.5) A maximum value MAY be placed on RTO provided it is at least 60 seconds. ...the only thing that I don't see implemented in this version of the patch is paragraph 5.7: (5.7) If the timer expires awaiting the ACK of a SYN segment and the TCP implementation is using an RTO less than 3 seconds, the RTO MUST be re-initialized to 3 seconds when data transmission begins (i.e., after the three-way handshake completes). I missed that while reviewing earlier versions. I guess we need to use a MAX(x, 3) clamp if (c->conn->events & ESTABLISHED). I think it's simpler than re-introducing separate starting values (one second and three seconds). > Probably I should name it more clearly. >=20 > > > > But in any case, do you really need to calculate that explicitly? I was > > thinking that you can just clamp the value when you use it in > > tcp_timer_ctl(). > > > > If c->tcp.rto_max is DIV_ROUND_CLOSEST(x, 1000), where 'x' is the value > > you read from the kernel, then I guess it's just: > > > > --- > > it.it_value.tv_sec =3D MIN(it.it_value.tv_sec, c->tcp.r= to_max); =20 >=20 > After reading the comments in v3 when tcp_rto_max_ms was first > mentioned again, I realized I got something wrong again. I thought it > was for the total timeout for all retries, so I need to calculate that > and decide to reset the connection as in v2. I think it actually applies to all the retries. > Anyway, you are right. We don't need to do that. Thanks for your patience= . >=20 > > } ... > > > > if (timerfd_settime(conn->timer, 0, &it, NULL)) > > flow_perror(conn, "failed to set timer"); > > --- --=20 Stefano